All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] [RFC] kconfig: warn if an unknown symbol is selected
Date: Mon, 29 Sep 2014 16:41:39 +0200	[thread overview]
Message-ID: <54296FA3.8080902@suse.cz> (raw)
In-Reply-To: <1411769309.15241.37.camel@x220>

On 2014-09-27 00:08, Paul Bolle wrote:
> A select of an unknown symbol is basically treated as a nop and is
> silently skipped. This is annoying if the selected symbol contains a
> typo. It can also hide the fact that a treewide symbol cleanup was only
> done partially.
> 
> There are also a few cases were this might have been done on purpose.
> But that anti-pattern should be discouraged. Almost all select
> statements point to a known and reachable symbol. So people will likely
> assume that any selected symbol is actually set. Violating that
> assumption might lead to (subtle) bugs.
> 
> So let's warn when we notice a select of a symbol that is not known in
> the configuration we're creating.
> 
> Rfced-by: Paul Bolle <pebolle@tiscali.nl>

I think this is a good idea, it fits well next to the already present
warning about selecting symbols with unmet dependencies. Feel free to
submit as a regular patch with

Acked-by: Michal Marek <mmarek@suse.cz>

Michal

      reply	other threads:[~2014-09-29 14:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-26 22:08 [PATCH 1/1] [RFC] kconfig: warn if an unknown symbol is selected Paul Bolle
2014-09-29 14:41 ` Michal Marek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54296FA3.8080902@suse.cz \
    --to=mmarek@suse.cz \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.