From: David Vrabel <david.vrabel@citrix.com>
To: Chen Gang <gang.chen.5i5j@gmail.com>, <konrad.wilk@oracle.com>,
<ian.campbell@citrix.com>, <wei.liu2@citrix.com>,
<boris.ostrovsky@oracle.com>, <bhelgaas@google.com>,
<jgross@suse.com>, <yongjun_wei@trendmicro.com.cn>,
<mukesh.rathor@oracle.com>
Cc: <xen-devel@lists.xenproject.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
<linux-pci@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xen/xenbus: Use 'void' instead of 'int' for the return of xenbus_switch_state()
Date: Tue, 30 Sep 2014 10:55:26 +0100 [thread overview]
Message-ID: <542A7E0E.9050702@citrix.com> (raw)
In-Reply-To: <5425961A.5000604@gmail.com>
On 26/09/14 17:36, Chen Gang wrote:
> When xenbus_switch_state() fails, it will call xenbus_switch_fatal()
> internally, so need not return any status value, then use 'void' instead
> of 'int' for xenbus_switch_state() and __xenbus_switch_state().
>
> Also need be sure that all callers which check the return value must let
> 'err' be 0.
>
> And also need change the related comments for xenbus_switch_state().
Since this patch does not fix a bug and there is no unanimous agreement
on the API change I'm not going to apply it (nor the previous version).
David
WARNING: multiple messages have this Message-ID (diff)
From: David Vrabel <david.vrabel@citrix.com>
To: Chen Gang <gang.chen.5i5j@gmail.com>,
konrad.wilk@oracle.com, ian.campbell@citrix.com,
wei.liu2@citrix.com, boris.ostrovsky@oracle.com,
bhelgaas@google.com, jgross@suse.com,
yongjun_wei@trendmicro.com.cn, mukesh.rathor@oracle.com
Cc: xen-devel@lists.xenproject.org,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xen/xenbus: Use 'void' instead of 'int' for the return of xenbus_switch_state()
Date: Tue, 30 Sep 2014 10:55:26 +0100 [thread overview]
Message-ID: <542A7E0E.9050702@citrix.com> (raw)
In-Reply-To: <5425961A.5000604@gmail.com>
On 26/09/14 17:36, Chen Gang wrote:
> When xenbus_switch_state() fails, it will call xenbus_switch_fatal()
> internally, so need not return any status value, then use 'void' instead
> of 'int' for xenbus_switch_state() and __xenbus_switch_state().
>
> Also need be sure that all callers which check the return value must let
> 'err' be 0.
>
> And also need change the related comments for xenbus_switch_state().
Since this patch does not fix a bug and there is no unanimous agreement
on the API change I'm not going to apply it (nor the previous version).
David
next prev parent reply other threads:[~2014-09-30 9:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 16:36 [PATCH] xen/xenbus: Use 'void' instead of 'int' for the return of xenbus_switch_state() Chen Gang
2014-09-26 18:07 ` [Xen-devel] " David Vrabel
2014-09-26 18:07 ` David Vrabel
2014-09-27 9:20 ` Chen Gang
2014-09-27 9:20 ` [Xen-devel] " Chen Gang
2014-09-29 8:41 ` Wei Liu
2014-09-29 8:41 ` Wei Liu
2014-09-29 8:41 ` Wei Liu
2014-09-29 14:03 ` Konrad Rzeszutek Wilk
2014-09-29 14:03 ` [Xen-devel] " Konrad Rzeszutek Wilk
2014-09-26 18:07 ` David Vrabel
2014-09-29 5:09 ` Juergen Gross
2014-09-29 5:09 ` [Xen-devel] " Juergen Gross
2014-09-29 13:35 ` Bjorn Helgaas
2014-09-29 13:35 ` Bjorn Helgaas
2014-09-29 14:02 ` Konrad Rzeszutek Wilk
2014-09-29 14:02 ` Konrad Rzeszutek Wilk
2014-09-29 14:17 ` David Vrabel
2014-09-29 14:17 ` David Vrabel
2014-09-29 15:40 ` Konrad Rzeszutek Wilk
2014-09-29 15:40 ` Konrad Rzeszutek Wilk
2014-09-29 17:14 ` David Vrabel
2014-09-29 17:14 ` David Vrabel
2014-09-29 17:14 ` David Vrabel
2014-09-29 14:17 ` David Vrabel
2014-09-30 8:04 ` Chen Gang
2014-09-30 8:04 ` Chen Gang
2014-09-30 9:55 ` David Vrabel [this message]
2014-09-30 9:55 ` David Vrabel
2014-09-30 10:10 ` Chen Gang
2014-09-30 10:10 ` Chen Gang
2014-09-30 9:55 ` David Vrabel
-- strict thread matches above, loose matches on Subject: below --
2014-09-26 16:36 Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542A7E0E.9050702@citrix.com \
--to=david.vrabel@citrix.com \
--cc=bhelgaas@google.com \
--cc=boris.ostrovsky@oracle.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=ian.campbell@citrix.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mukesh.rathor@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.