* [PATCH] net: xilinx: Remove unnecessary ether_setup after alloc_etherdev @ 2014-10-01 6:00 ` Michal Simek 0 siblings, 0 replies; 4+ messages in thread From: Michal Simek @ 2014-10-01 6:00 UTC (permalink / raw) To: linux-arm-kernel From: Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@xilinx.com> Calling ether_setup is redundant since alloc_etherdev calls it. Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com> Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- drivers/net/ethernet/xilinx/ll_temac_main.c | 1 - drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c index fda5891835d4..629077050fce 100644 --- a/drivers/net/ethernet/xilinx/ll_temac_main.c +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c @@ -1012,7 +1012,6 @@ static int temac_of_probe(struct platform_device *op) if (!ndev) return -ENOMEM; - ether_setup(ndev); platform_set_drvdata(op, ndev); SET_NETDEV_DEV(ndev, &op->dev); ndev->flags &= ~IFF_MULTICAST; /* clear multicast */ diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index c8fd94133ecd..4ea2d4e6f1d1 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -1485,7 +1485,6 @@ static int axienet_of_probe(struct platform_device *op) if (!ndev) return -ENOMEM; - ether_setup(ndev); platform_set_drvdata(op, ndev); SET_NETDEV_DEV(ndev, &op->dev); -- 1.8.2.3 -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141001/a19b1ab4/attachment-0001.sig> ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] net: xilinx: Remove unnecessary ether_setup after alloc_etherdev @ 2014-10-01 6:00 ` Michal Simek 0 siblings, 0 replies; 4+ messages in thread From: Michal Simek @ 2014-10-01 6:00 UTC (permalink / raw) To: linux-kernel, monstr Cc: Subbaraya Sundeep Bhatta, Anirudha Sarangi, John Linn, David S. Miller, Manuel Schölling, Paul Gortmaker, Julia Lawall, Joe Perches, Ricardo Ribalda, Eric Dumazet, netdev, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 1380 bytes --] From: Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@xilinx.com> Calling ether_setup is redundant since alloc_etherdev calls it. Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com> Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- drivers/net/ethernet/xilinx/ll_temac_main.c | 1 - drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c index fda5891835d4..629077050fce 100644 --- a/drivers/net/ethernet/xilinx/ll_temac_main.c +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c @@ -1012,7 +1012,6 @@ static int temac_of_probe(struct platform_device *op) if (!ndev) return -ENOMEM; - ether_setup(ndev); platform_set_drvdata(op, ndev); SET_NETDEV_DEV(ndev, &op->dev); ndev->flags &= ~IFF_MULTICAST; /* clear multicast */ diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index c8fd94133ecd..4ea2d4e6f1d1 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -1485,7 +1485,6 @@ static int axienet_of_probe(struct platform_device *op) if (!ndev) return -ENOMEM; - ether_setup(ndev); platform_set_drvdata(op, ndev); SET_NETDEV_DEV(ndev, &op->dev); -- 1.8.2.3 [-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] net: xilinx: Remove unnecessary ether_setup after alloc_etherdev 2014-10-01 6:00 ` Michal Simek @ 2014-10-01 8:25 ` Michal Simek -1 siblings, 0 replies; 4+ messages in thread From: Michal Simek @ 2014-10-01 8:25 UTC (permalink / raw) To: linux-arm-kernel On 10/01/2014 08:00 AM, Michal Simek wrote: > From: Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@xilinx.com> > > Calling ether_setup is redundant since alloc_etherdev calls it. > > Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > drivers/net/ethernet/xilinx/ll_temac_main.c | 1 - > drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c > index fda5891835d4..629077050fce 100644 > --- a/drivers/net/ethernet/xilinx/ll_temac_main.c > +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c > @@ -1012,7 +1012,6 @@ static int temac_of_probe(struct platform_device *op) > if (!ndev) > return -ENOMEM; > > - ether_setup(ndev); > platform_set_drvdata(op, ndev); > SET_NETDEV_DEV(ndev, &op->dev); > ndev->flags &= ~IFF_MULTICAST; /* clear multicast */ > diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > index c8fd94133ecd..4ea2d4e6f1d1 100644 > --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > @@ -1485,7 +1485,6 @@ static int axienet_of_probe(struct platform_device *op) > if (!ndev) > return -ENOMEM; > > - ether_setup(ndev); > platform_set_drvdata(op, ndev); > > SET_NETDEV_DEV(ndev, &op->dev); > -- > 1.8.2.3 > Please ignore this one it is already applied for axienet. Will send v2 just for ll_temac. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: OpenPGP digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141001/355efe0e/attachment.sig> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: xilinx: Remove unnecessary ether_setup after alloc_etherdev @ 2014-10-01 8:25 ` Michal Simek 0 siblings, 0 replies; 4+ messages in thread From: Michal Simek @ 2014-10-01 8:25 UTC (permalink / raw) To: Michal Simek, linux-kernel Cc: Subbaraya Sundeep Bhatta, Anirudha Sarangi, John Linn, David S. Miller, Manuel Schölling, Paul Gortmaker, Julia Lawall, Joe Perches, Ricardo Ribalda, Eric Dumazet, netdev, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 1965 bytes --] On 10/01/2014 08:00 AM, Michal Simek wrote: > From: Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@xilinx.com> > > Calling ether_setup is redundant since alloc_etherdev calls it. > > Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > drivers/net/ethernet/xilinx/ll_temac_main.c | 1 - > drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c > index fda5891835d4..629077050fce 100644 > --- a/drivers/net/ethernet/xilinx/ll_temac_main.c > +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c > @@ -1012,7 +1012,6 @@ static int temac_of_probe(struct platform_device *op) > if (!ndev) > return -ENOMEM; > > - ether_setup(ndev); > platform_set_drvdata(op, ndev); > SET_NETDEV_DEV(ndev, &op->dev); > ndev->flags &= ~IFF_MULTICAST; /* clear multicast */ > diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > index c8fd94133ecd..4ea2d4e6f1d1 100644 > --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > @@ -1485,7 +1485,6 @@ static int axienet_of_probe(struct platform_device *op) > if (!ndev) > return -ENOMEM; > > - ether_setup(ndev); > platform_set_drvdata(op, ndev); > > SET_NETDEV_DEV(ndev, &op->dev); > -- > 1.8.2.3 > Please ignore this one it is already applied for axienet. Will send v2 just for ll_temac. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-01 8:25 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-10-01 6:00 [PATCH] net: xilinx: Remove unnecessary ether_setup after alloc_etherdev Michal Simek 2014-10-01 6:00 ` Michal Simek 2014-10-01 8:25 ` Michal Simek 2014-10-01 8:25 ` Michal Simek
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.