From: Tomasz Figa <tomasz.figa@gmail.com>
To: Pankaj Dubey <pankaj.dubey@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Cc: kgene.kim@samsung.com, linux@arm.linux.org.uk,
thomas.ab@samsung.com, vikas.sajjan@samsung.com,
linux@roeck-us.net, naushad@samsung.com
Subject: Re: [PATCH 2/2] ARM: EXYNOS: PMU: move restart code into pmu driver
Date: Wed, 01 Oct 2014 12:36:56 +0200 [thread overview]
Message-ID: <542BD948.8040600@gmail.com> (raw)
In-Reply-To: <1412142540-3667-3-git-send-email-pankaj.dubey@samsung.com>
Hi Pankaj,
Please see my comments inline.
On 01.10.2014 07:49, Pankaj Dubey wrote:
> Let's register reboot_notifier from PMU driver for reboot
> functionality. So that we can remove restart hooks from
> machine specific file, and thus moving ahead when PMU moved
> to driver folder, this functionality can be reused for ARM64
> based Exynos SoC's.
[snip]
> +static int pmu_reboot_notify_handler(struct notifier_block *this,
> + unsigned long code, void *unused)
> +{
> + if (code == SYS_RESTART) {
> + u32 val = 0x1;
> +
> + pmu_raw_writel(val, EXYNOS_SWRESET);
As already mentioned for patch 1, no need for the variable, because this
is just a constant 1.
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: EXYNOS: PMU: move restart code into pmu driver
Date: Wed, 01 Oct 2014 12:36:56 +0200 [thread overview]
Message-ID: <542BD948.8040600@gmail.com> (raw)
In-Reply-To: <1412142540-3667-3-git-send-email-pankaj.dubey@samsung.com>
Hi Pankaj,
Please see my comments inline.
On 01.10.2014 07:49, Pankaj Dubey wrote:
> Let's register reboot_notifier from PMU driver for reboot
> functionality. So that we can remove restart hooks from
> machine specific file, and thus moving ahead when PMU moved
> to driver folder, this functionality can be reused for ARM64
> based Exynos SoC's.
[snip]
> +static int pmu_reboot_notify_handler(struct notifier_block *this,
> + unsigned long code, void *unused)
> +{
> + if (code == SYS_RESTART) {
> + u32 val = 0x1;
> +
> + pmu_raw_writel(val, EXYNOS_SWRESET);
As already mentioned for patch 1, no need for the variable, because this
is just a constant 1.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-10-01 10:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 5:48 [PATCH 0/2] Handle reboot for Exynos SoC via reboot_notifier Pankaj Dubey
2014-10-01 5:48 ` Pankaj Dubey
2014-10-01 5:48 ` [PATCH 1/2] clk: samsung: exynos5440: move restart code into clock driver Pankaj Dubey
2014-10-01 5:48 ` Pankaj Dubey
2014-10-01 10:33 ` Tomasz Figa
2014-10-01 10:33 ` Tomasz Figa
2014-10-01 5:49 ` [PATCH 2/2] ARM: EXYNOS: PMU: move restart code into pmu driver Pankaj Dubey
2014-10-01 5:49 ` Pankaj Dubey
2014-10-01 10:36 ` Tomasz Figa [this message]
2014-10-01 10:36 ` Tomasz Figa
2014-10-01 11:42 ` Pankaj Dubey
2014-10-01 11:42 ` Pankaj Dubey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542BD948.8040600@gmail.com \
--to=tomasz.figa@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@roeck-us.net \
--cc=naushad@samsung.com \
--cc=pankaj.dubey@samsung.com \
--cc=thomas.ab@samsung.com \
--cc=vikas.sajjan@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.