From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Kevin Hilman <khilman@linaro.org>,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tomasz Figa <tomasz.figa@gmail.com>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Philipp Zabel <philipp.zabel@gmail.com>,
Mark Brown <broonie@kernel.org>, Wolfram Sang <wsa@the-dreams.de>,
Russell King <linux@arm.linux.org.uk>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jack Dai <jack.dai@rock-chips.com>,
Jinkun Hong <jinkun.hong@rock-chips.com>,
Beata Michalska <b.michalska@samsung.com>
Subject: Re: [PATCH v2 1/4] PM / Domains: Remove pm_genpd_dev_need_restore() API
Date: Wed, 01 Oct 2014 18:36:47 +0200 [thread overview]
Message-ID: <542C2D9F.8060005@samsung.com> (raw)
In-Reply-To: <1412174494-15346-2-git-send-email-ulf.hansson@linaro.org>
On 01/10/14 16:41, Ulf Hansson wrote:
> There are currently no users of this API, let's remove it.
The sad fact is that removal of pm_genpd_dev_need_restore() calls
from arch/arm/mach-exynos/pm_domains.c introduces regressions in
multiple exynos drivers (I'm sure it breaks media drivers).
I think before doing such changes all relevant drivers should be
updated first. I need to take a closer look again, but it seems
after dropping the pm_genpd_dev_need_restore() calls, client
driver's runtime_resume() callback is not being called in response
to first pm_runtime_get(_sync) call, even if a device is runtime
pm active.
More details can be found in commit ebc35c726298ba3fdebba316a
'ARM: EXYNOS: register devices in 'need_restore' state for pm_domains'.
The above only happens when devices are added to an inactive power
domain, then I guess patch 2/4 is also an attempt to address this
issue ?
--
Thanks,
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/4] PM / Domains: Remove pm_genpd_dev_need_restore() API
Date: Wed, 01 Oct 2014 18:36:47 +0200 [thread overview]
Message-ID: <542C2D9F.8060005@samsung.com> (raw)
In-Reply-To: <1412174494-15346-2-git-send-email-ulf.hansson@linaro.org>
On 01/10/14 16:41, Ulf Hansson wrote:
> There are currently no users of this API, let's remove it.
The sad fact is that removal of pm_genpd_dev_need_restore() calls
from arch/arm/mach-exynos/pm_domains.c introduces regressions in
multiple exynos drivers (I'm sure it breaks media drivers).
I think before doing such changes all relevant drivers should be
updated first. I need to take a closer look again, but it seems
after dropping the pm_genpd_dev_need_restore() calls, client
driver's runtime_resume() callback is not being called in response
to first pm_runtime_get(_sync) call, even if a device is runtime
pm active.
More details can be found in commit ebc35c726298ba3fdebba316a
'ARM: EXYNOS: register devices in 'need_restore' state for pm_domains'.
The above only happens when devices are added to an inactive power
domain, then I guess patch 2/4 is also an attempt to address this
issue ?
--
Thanks,
Sylwester
next prev parent reply other threads:[~2014-10-01 16:36 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 14:41 [PATCH v2 0/4] PM / Domains: Fix race conditions during boot Ulf Hansson
2014-10-01 14:41 ` Ulf Hansson
2014-10-01 14:41 ` [PATCH v2 1/4] PM / Domains: Remove pm_genpd_dev_need_restore() API Ulf Hansson
2014-10-01 14:41 ` Ulf Hansson
2014-10-01 16:36 ` Sylwester Nawrocki [this message]
2014-10-01 16:36 ` Sylwester Nawrocki
2014-10-02 9:09 ` Ulf Hansson
2014-10-02 9:09 ` Ulf Hansson
2014-10-02 12:00 ` Sylwester Nawrocki
2014-10-02 12:00 ` Sylwester Nawrocki
2014-10-02 13:30 ` Ulf Hansson
2014-10-02 13:30 ` Ulf Hansson
2014-10-02 15:54 ` Sylwester Nawrocki
2014-10-02 15:54 ` Sylwester Nawrocki
2014-10-03 10:36 ` Ulf Hansson
2014-10-03 10:36 ` Ulf Hansson
2014-11-06 15:57 ` Sylwester Nawrocki
2014-11-06 15:57 ` Sylwester Nawrocki
2014-11-06 19:05 ` Ulf Hansson
2014-11-06 19:05 ` Ulf Hansson
2014-10-01 14:41 ` [PATCH v2 2/4] ARM: exynos: Ensure PM domains are powered at initialization Ulf Hansson
2014-10-01 14:41 ` Ulf Hansson
2014-10-01 16:18 ` Sylwester Nawrocki
2014-10-01 16:18 ` Sylwester Nawrocki
2014-10-01 19:50 ` Rafael J. Wysocki
2014-10-01 19:50 ` Rafael J. Wysocki
2014-10-02 9:42 ` Ulf Hansson
2014-10-02 9:42 ` Ulf Hansson
2014-10-02 9:55 ` Ulf Hansson
2014-10-02 9:55 ` Ulf Hansson
2014-10-01 14:41 ` [PATCH v2 3/4] PM / Domains: Expect PM domains being " Ulf Hansson
2014-10-01 14:41 ` Ulf Hansson
2014-10-01 23:50 ` Simon Horman
2014-10-01 23:50 ` Simon Horman
2014-10-01 14:41 ` [PATCH v2 4/4] PM / Domains: Enforce PM domains to stay powered during boot Ulf Hansson
2014-10-01 14:41 ` Ulf Hansson
2014-10-03 1:14 ` [PATCH v2 0/4] PM / Domains: Fix race conditions " Kevin Hilman
2014-10-03 1:14 ` Kevin Hilman
2014-10-03 9:47 ` Ulf Hansson
2014-10-03 9:47 ` Ulf Hansson
2014-10-03 15:10 ` Kevin Hilman
2014-10-03 15:10 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542C2D9F.8060005@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=b.michalska@samsung.com \
--cc=ben-linux@fluff.org \
--cc=broonie@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=horms@verge.net.au \
--cc=jack.dai@rock-chips.com \
--cc=jinkun.hong@rock-chips.com \
--cc=kgene.kim@samsung.com \
--cc=khilman@linaro.org \
--cc=len.brown@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=pavel@ucw.cz \
--cc=philipp.zabel@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=stern@rowland.harvard.edu \
--cc=tomasz.figa@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.