All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: atull <atull@opensource.altera.com>
Cc: jdelvare@suse.de, lm-sensors@lm-sensors.org, lgirdwood@gmail.com,
	broonie@kernel.org, robh+dt@kernel.org, pawel.moll@arm.com,
	mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
	galak@codeaurora.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, delicious.quinoa@gmail.com,
	dinguyen@opensource.altera.com, yvanderv@opensource.altera.com
Subject: Re: [lm-sensors] [PATCH v4 4/4] pmbus: ltc2978: add regulator support
Date: Thu, 02 Oct 2014 01:26:17 +0000	[thread overview]
Message-ID: <542CA9B9.4050602@roeck-us.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1410011713150.5194@atx-linux-37>

On 10/01/2014 03:20 PM, atull wrote:
> On Wed, 1 Oct 2014, Guenter Roeck wrote:
>
>> On Wed, Oct 01, 2014 at 03:18:20PM -0500, atull@opensource.altera.com wrote:
>>> From: Alan Tull <atull@opensource.altera.com>
>>>
>>> Add simple on/off regulator support for ltc2978 and
>>> other pmbus parts supported by ltc2978.c
>>>
>>> Signed-off-by: Alan Tull <atull@opensource.altera.com>
>>>
>>> v2: Remove '#include <linux/regulator/machine.h>'
>>>      Only one regulator per pmbus device
>>>      Get regulator_init_data from pdata or device tree
>>>
>>> v3: Support multiple regulators for each chip
>>>      Move most code to pmbus_core.c
>>>      fixed values for on/off
>>>
>>> v4: fix a #endif comment
>>>      simplify probe code, remove added switch statement
>>>      remove BUG_ON(), add error message and fix num_regulators
>>> ---
>>>   drivers/hwmon/pmbus/Kconfig   |    7 +++++++
>>>   drivers/hwmon/pmbus/ltc2978.c |   37 +++++++++++++++++++++++++++++++++++++
>>>   2 files changed, 44 insertions(+)
>>>
>>> diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
>>> index 6e1e493..79117b7 100644
>>> --- a/drivers/hwmon/pmbus/Kconfig
>>> +++ b/drivers/hwmon/pmbus/Kconfig
>>> @@ -56,6 +56,13 @@ config SENSORS_LTC2978
>>>   	  This driver can also be built as a module. If so, the module will
>>>   	  be called ltc2978.
>>>
>>> +config SENSORS_LTC2978_REGULATOR
>>> +	boolean "Regulator support for LTC2974, LTC2978, LTC3880, and LTC3883"
>>
>> We will need to update this and SENSORS_LTC2978 and add LTC2977 as well as
>> LTM4646 to the list of supported chips.
>>
>> Guenter
>
> I will add the whole list to the 'help' sections of SENSORS_LTC2978 and
> SENSORS_LTC2978_REGULATOR.
>
> For the tristate/boolean lines, I can't fit the whole list, so I will
> leave them as they are.  Or I could change to 'LTC2978 and compatibles' as
> many others in this Kconfig have.
>
Yes, that makes sense.

Thanks,
Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: atull <atull@opensource.altera.com>
Cc: jdelvare@suse.de, lm-sensors@lm-sensors.org, lgirdwood@gmail.com,
	broonie@kernel.org, robh+dt@kernel.org, pawel.moll@arm.com,
	mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
	galak@codeaurora.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, delicious.quinoa@gmail.com,
	dinguyen@opensource.altera.com, yvanderv@opensource.altera.com
Subject: Re: [PATCH v4 4/4] pmbus: ltc2978: add regulator support
Date: Wed, 01 Oct 2014 18:26:17 -0700	[thread overview]
Message-ID: <542CA9B9.4050602@roeck-us.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1410011713150.5194@atx-linux-37>

On 10/01/2014 03:20 PM, atull wrote:
> On Wed, 1 Oct 2014, Guenter Roeck wrote:
>
>> On Wed, Oct 01, 2014 at 03:18:20PM -0500, atull@opensource.altera.com wrote:
>>> From: Alan Tull <atull@opensource.altera.com>
>>>
>>> Add simple on/off regulator support for ltc2978 and
>>> other pmbus parts supported by ltc2978.c
>>>
>>> Signed-off-by: Alan Tull <atull@opensource.altera.com>
>>>
>>> v2: Remove '#include <linux/regulator/machine.h>'
>>>      Only one regulator per pmbus device
>>>      Get regulator_init_data from pdata or device tree
>>>
>>> v3: Support multiple regulators for each chip
>>>      Move most code to pmbus_core.c
>>>      fixed values for on/off
>>>
>>> v4: fix a #endif comment
>>>      simplify probe code, remove added switch statement
>>>      remove BUG_ON(), add error message and fix num_regulators
>>> ---
>>>   drivers/hwmon/pmbus/Kconfig   |    7 +++++++
>>>   drivers/hwmon/pmbus/ltc2978.c |   37 +++++++++++++++++++++++++++++++++++++
>>>   2 files changed, 44 insertions(+)
>>>
>>> diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
>>> index 6e1e493..79117b7 100644
>>> --- a/drivers/hwmon/pmbus/Kconfig
>>> +++ b/drivers/hwmon/pmbus/Kconfig
>>> @@ -56,6 +56,13 @@ config SENSORS_LTC2978
>>>   	  This driver can also be built as a module. If so, the module will
>>>   	  be called ltc2978.
>>>
>>> +config SENSORS_LTC2978_REGULATOR
>>> +	boolean "Regulator support for LTC2974, LTC2978, LTC3880, and LTC3883"
>>
>> We will need to update this and SENSORS_LTC2978 and add LTC2977 as well as
>> LTM4646 to the list of supported chips.
>>
>> Guenter
>
> I will add the whole list to the 'help' sections of SENSORS_LTC2978 and
> SENSORS_LTC2978_REGULATOR.
>
> For the tristate/boolean lines, I can't fit the whole list, so I will
> leave them as they are.  Or I could change to 'LTC2978 and compatibles' as
> many others in this Kconfig have.
>
Yes, that makes sense.

Thanks,
Guenter

  reply	other threads:[~2014-10-02  1:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-01 20:18 [lm-sensors] [PATCH v4 4/4] pmbus: ltc2978: add regulator support atull
2014-10-01 20:18 ` atull
2014-10-01 20:18 ` atull
2014-10-01 21:36 ` [lm-sensors] " Guenter Roeck
2014-10-01 21:36   ` Guenter Roeck
2014-10-01 21:36   ` Guenter Roeck
2014-10-01 22:09   ` [lm-sensors] " atull
2014-10-01 22:09     ` atull
2014-10-01 22:09     ` atull
2014-10-01 22:20   ` [lm-sensors] " atull
2014-10-01 22:20     ` atull
2014-10-01 22:20     ` atull
2014-10-02  1:26     ` Guenter Roeck [this message]
2014-10-02  1:26       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=542CA9B9.4050602@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=atull@opensource.altera.com \
    --cc=broonie@kernel.org \
    --cc=delicious.quinoa@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@opensource.altera.com \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jdelvare@suse.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=yvanderv@opensource.altera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.