From: Peter Hurley <peter@hurleysoftware.com>
To: lkp@lists.01.org
Subject: Re: [rfcomm_run] WARNING: CPU: 1 PID: 79 at kernel/sched/core.c:7156 __might_sleep()
Date: Thu, 02 Oct 2014 08:38:46 -0400 [thread overview]
Message-ID: <542D4756.4030100@hurleysoftware.com> (raw)
In-Reply-To: <20141002123150.GC6324@worktop.programming.kicks-ass.net>
[-- Attachment #1: Type: text/plain, Size: 1365 bytes --]
On 10/02/2014 08:31 AM, Peter Zijlstra wrote:
> On Thu, Oct 02, 2014 at 01:09:27PM +0200, Peter Zijlstra wrote:
>> On Tue, Sep 30, 2014 at 04:02:28PM +0800, Fengguang Wu wrote:
>>> Hi Peter,
>>>
>>> We possibly find a rfcomm bug (maintainers CCed) exposed by your debug patch
>>>
>>> [ 1.861895] NET: Registered protocol family 5
>>> [ 1.862978] Bluetooth: RFCOMM TTY layer initialized
>>> [ 1.863099] ------------[ cut here ]------------
>>> [ 1.863105] WARNING: CPU: 1 PID: 79 at kernel/sched/core.c:7156 __might_sleep+0x17d/0x1a1()
>>> [ 1.863112] do not call blocking ops when !TASK_RUNNING; state=1 set at [<c14dc381>] rfcomm_run+0xdf/0x130e
>>> [ 1.863591] [<c1058b73>] ? kthread_stop+0x53/0x53
>>> [ 1.864906] [<c155a411>] dump_stack+0x48/0x60
>>> [ 1.866298] [<c14dc381>] ? rfcomm_run+0xdf/0x130e
>>
>> Ha yes, rfcomm_run is a complete buggy mess indeed. Lemme go see what I
>> can make of it.
>
> ---
> Subject: rfcomm: Fix broken wait construct
>
> rfcomm_run() is a tad broken in that is has a nested wait loop. One
> cannot rely on p->state for the outer wait because the inner wait will
> overwrite it.
>
> While at it, rename rfcomm_schedule to rfcomm_wake, since that is what
> it actually does.
rfcomm_schedule() as in schedule_work(), which is how it's used.
Regards,
Peter Hurley
WARNING: multiple messages have this Message-ID (diff)
From: Peter Hurley <peter@hurleysoftware.com>
To: Peter Zijlstra <peterz@infradead.org>,
Fengguang Wu <fengguang.wu@intel.com>
Cc: Jet Chen <jet.chen@intel.com>, Su Tao <tao.su@intel.com>,
Yuanhan Liu <yuanhan.liu@intel.com>, LKP <lkp@01.org>,
linux-kernel@vger.kernel.org,
Marcel Holtmann <marcel@holtmann.org>
Subject: Re: [rfcomm_run] WARNING: CPU: 1 PID: 79 at kernel/sched/core.c:7156 __might_sleep()
Date: Thu, 02 Oct 2014 08:38:46 -0400 [thread overview]
Message-ID: <542D4756.4030100@hurleysoftware.com> (raw)
In-Reply-To: <20141002123150.GC6324@worktop.programming.kicks-ass.net>
On 10/02/2014 08:31 AM, Peter Zijlstra wrote:
> On Thu, Oct 02, 2014 at 01:09:27PM +0200, Peter Zijlstra wrote:
>> On Tue, Sep 30, 2014 at 04:02:28PM +0800, Fengguang Wu wrote:
>>> Hi Peter,
>>>
>>> We possibly find a rfcomm bug (maintainers CCed) exposed by your debug patch
>>>
>>> [ 1.861895] NET: Registered protocol family 5
>>> [ 1.862978] Bluetooth: RFCOMM TTY layer initialized
>>> [ 1.863099] ------------[ cut here ]------------
>>> [ 1.863105] WARNING: CPU: 1 PID: 79 at kernel/sched/core.c:7156 __might_sleep+0x17d/0x1a1()
>>> [ 1.863112] do not call blocking ops when !TASK_RUNNING; state=1 set at [<c14dc381>] rfcomm_run+0xdf/0x130e
>>> [ 1.863591] [<c1058b73>] ? kthread_stop+0x53/0x53
>>> [ 1.864906] [<c155a411>] dump_stack+0x48/0x60
>>> [ 1.866298] [<c14dc381>] ? rfcomm_run+0xdf/0x130e
>>
>> Ha yes, rfcomm_run is a complete buggy mess indeed. Lemme go see what I
>> can make of it.
>
> ---
> Subject: rfcomm: Fix broken wait construct
>
> rfcomm_run() is a tad broken in that is has a nested wait loop. One
> cannot rely on p->state for the outer wait because the inner wait will
> overwrite it.
>
> While at it, rename rfcomm_schedule to rfcomm_wake, since that is what
> it actually does.
rfcomm_schedule() as in schedule_work(), which is how it's used.
Regards,
Peter Hurley
next prev parent reply other threads:[~2014-10-02 12:38 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 8:02 [rfcomm_run] WARNING: CPU: 1 PID: 79 at kernel/sched/core.c:7156 __might_sleep() Fengguang Wu
2014-10-02 11:09 ` Peter Zijlstra
2014-10-02 11:09 ` Peter Zijlstra
2014-10-02 12:31 ` Peter Zijlstra
2014-10-02 12:31 ` Peter Zijlstra
2014-10-02 12:38 ` Peter Hurley [this message]
2014-10-02 12:38 ` Peter Hurley
2014-10-02 12:54 ` Peter Zijlstra
2014-10-02 12:54 ` Peter Zijlstra
2014-10-02 13:05 ` Peter Hurley
2014-10-02 13:05 ` Peter Hurley
2014-10-02 13:41 ` Peter Zijlstra
2014-10-02 13:41 ` Peter Zijlstra
2014-10-02 12:42 ` Peter Zijlstra
2014-10-02 12:42 ` Peter Zijlstra
2014-10-02 13:49 ` Peter Hurley
2014-10-02 13:49 ` Peter Hurley
2014-10-02 13:52 ` Peter Zijlstra
2014-10-02 13:52 ` Peter Zijlstra
2014-10-02 13:58 ` Peter Zijlstra
2014-10-02 13:58 ` Peter Zijlstra
2014-10-02 14:16 ` Peter Hurley
2014-10-02 14:16 ` Peter Hurley
2014-10-02 16:57 ` Peter Zijlstra
2014-10-02 16:57 ` Peter Zijlstra
2014-10-02 19:18 ` Oleg Nesterov
2014-10-02 19:18 ` Oleg Nesterov
2014-10-02 19:11 ` Oleg Nesterov
2014-10-02 19:11 ` Oleg Nesterov
2014-10-02 19:49 ` Peter Hurley
2014-10-02 19:49 ` Peter Hurley
2014-10-02 19:57 ` Peter Zijlstra
2014-10-02 19:57 ` Peter Zijlstra
2014-10-02 20:10 ` Oleg Nesterov
2014-10-02 20:10 ` Oleg Nesterov
2014-10-03 11:50 ` Peter Zijlstra
2014-10-03 11:50 ` Peter Zijlstra
2014-10-03 17:56 ` Oleg Nesterov
2014-10-03 17:56 ` Oleg Nesterov
2014-10-03 19:30 ` Oleg Nesterov
2014-10-03 19:30 ` Oleg Nesterov
2014-10-04 8:42 ` Peter Zijlstra
2014-10-04 8:42 ` Peter Zijlstra
2014-10-06 0:25 ` Oleg Nesterov
2014-10-06 0:25 ` Oleg Nesterov
2014-10-06 9:19 ` Peter Zijlstra
2014-10-06 9:19 ` Peter Zijlstra
2014-10-06 10:59 ` Paul E. McKenney
2014-10-06 10:59 ` Paul E. McKenney
2014-10-06 16:21 ` Oleg Nesterov
2014-10-06 16:24 ` Oleg Nesterov
2014-10-04 8:44 ` Peter Zijlstra
2014-10-04 8:44 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542D4756.4030100@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=lkp@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.