* [PATCH] kbuild: arm: Do not define "comma" twice
@ 2014-08-22 10:52 ` Masahiro Yamada
0 siblings, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2014-08-22 10:52 UTC (permalink / raw)
To: linux-kbuild; +Cc: Masahiro Yamada, linux-arm-kernel
The definition of "comma" exists in scripts/Kbuild.include.
We should not double it.
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: linux-arm-kernel@lists.infradead.org
---
arch/arm/Makefile | 2 --
arch/arm64/Makefile | 2 --
2 files changed, 4 deletions(-)
diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index 0ce9d0f..8568b6fb 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -50,8 +50,6 @@ AS += -EL
LD += -EL
endif
-comma = ,
-
# This selects which instruction set is used.
# Note that GCC does not numerically define an architecture version
# macro, but instead defines a whole series of macros which makes
diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
index 5783354..ebd0659 100644
--- a/arch/arm64/Makefile
+++ b/arch/arm64/Makefile
@@ -30,8 +30,6 @@ AS += -EL
LD += -EL
endif
-comma = ,
-
CHECKFLAGS += -D__aarch64__
# Default value
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] kbuild: arm: Do not define "comma" twice
@ 2014-08-22 10:52 ` Masahiro Yamada
0 siblings, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2014-08-22 10:52 UTC (permalink / raw)
To: linux-arm-kernel
The definition of "comma" exists in scripts/Kbuild.include.
We should not double it.
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: linux-arm-kernel at lists.infradead.org
---
arch/arm/Makefile | 2 --
arch/arm64/Makefile | 2 --
2 files changed, 4 deletions(-)
diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index 0ce9d0f..8568b6fb 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -50,8 +50,6 @@ AS += -EL
LD += -EL
endif
-comma = ,
-
# This selects which instruction set is used.
# Note that GCC does not numerically define an architecture version
# macro, but instead defines a whole series of macros which makes
diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
index 5783354..ebd0659 100644
--- a/arch/arm64/Makefile
+++ b/arch/arm64/Makefile
@@ -30,8 +30,6 @@ AS += -EL
LD += -EL
endif
-comma = ,
-
CHECKFLAGS += -D__aarch64__
# Default value
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] kbuild: arm: Do not define "comma" twice
2014-08-22 10:52 ` Masahiro Yamada
@ 2014-10-02 13:11 ` Michal Marek
-1 siblings, 0 replies; 6+ messages in thread
From: Michal Marek @ 2014-10-02 13:11 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-kbuild, linux-arm-kernel
On 2014-08-22 12:52, Masahiro Yamada wrote:
> The definition of "comma" exists in scripts/Kbuild.include.
> We should not double it.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: linux-arm-kernel@lists.infradead.org
I do not see the patch in linux-next, so I applied it to the kbuild tree.
Michal
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] kbuild: arm: Do not define "comma" twice
@ 2014-10-02 13:11 ` Michal Marek
0 siblings, 0 replies; 6+ messages in thread
From: Michal Marek @ 2014-10-02 13:11 UTC (permalink / raw)
To: linux-arm-kernel
On 2014-08-22 12:52, Masahiro Yamada wrote:
> The definition of "comma" exists in scripts/Kbuild.include.
> We should not double it.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: linux-arm-kernel at lists.infradead.org
I do not see the patch in linux-next, so I applied it to the kbuild tree.
Michal
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] kbuild: arm: Do not define "comma" twice
@ 2015-01-13 6:53 Masahiro Yamada
2015-01-13 8:03 ` Sascha Hauer
0 siblings, 1 reply; 6+ messages in thread
From: Masahiro Yamada @ 2015-01-13 6:53 UTC (permalink / raw)
To: barebox
The definition of "comma" exists in scripts/Kbuild.include.
We should not double it.
Note:
This was already fixed in Linux Kernel too.
See commit 226422d08c33 of Linux Kernel.
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---
arch/arm/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index 9dd983b..b75fea3 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -14,8 +14,6 @@ AS += -EL
LD += -EL
endif
-comma = ,
-
# This selects which instruction set is used.
# Note that GCC does not numerically define an architecture version
# macro, but instead defines a whole series of macros which makes
--
1.9.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] kbuild: arm: Do not define "comma" twice
2015-01-13 6:53 Masahiro Yamada
@ 2015-01-13 8:03 ` Sascha Hauer
0 siblings, 0 replies; 6+ messages in thread
From: Sascha Hauer @ 2015-01-13 8:03 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: barebox
On Tue, Jan 13, 2015 at 03:53:18PM +0900, Masahiro Yamada wrote:
> The definition of "comma" exists in scripts/Kbuild.include.
> We should not double it.
>
> Note:
> This was already fixed in Linux Kernel too.
> See commit 226422d08c33 of Linux Kernel.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-01-13 8:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-22 10:52 [PATCH] kbuild: arm: Do not define "comma" twice Masahiro Yamada
2014-08-22 10:52 ` Masahiro Yamada
2014-10-02 13:11 ` Michal Marek
2014-10-02 13:11 ` Michal Marek
-- strict thread matches above, loose matches on Subject: below --
2015-01-13 6:53 Masahiro Yamada
2015-01-13 8:03 ` Sascha Hauer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.