From: Jonathan Cameron <jic23@kernel.org>
To: Denis CIOCCA <denis.ciocca@st.com>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/7] iio:accel: Removed unnecessary parameter on common_probe function
Date: Sat, 04 Oct 2014 11:25:01 +0100 [thread overview]
Message-ID: <542FCAFD.2090200@kernel.org> (raw)
In-Reply-To: <1412350541-29431-2-git-send-email-denis.ciocca@st.com>
On 03/10/14 16:35, Denis CIOCCA wrote:
> Signed-off-by: Denis Ciocca <denis.ciocca@st.com>
Applied
> ---
> drivers/iio/accel/st_accel.h | 3 +--
> drivers/iio/accel/st_accel_core.c | 9 ++++-----
> drivers/iio/accel/st_accel_i2c.c | 2 +-
> drivers/iio/accel/st_accel_spi.c | 2 +-
> 4 files changed, 7 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/iio/accel/st_accel.h b/drivers/iio/accel/st_accel.h
> index c387763..fa96460 100644
> --- a/drivers/iio/accel/st_accel.h
> +++ b/drivers/iio/accel/st_accel.h
> @@ -33,8 +33,7 @@ static const struct st_sensors_platform_data default_accel_pdata = {
> .drdy_int_pin = 1,
> };
>
> -int st_accel_common_probe(struct iio_dev *indio_dev,
> - struct st_sensors_platform_data *pdata);
> +int st_accel_common_probe(struct iio_dev *indio_dev);
> void st_accel_common_remove(struct iio_dev *indio_dev);
>
> #ifdef CONFIG_IIO_BUFFER
> diff --git a/drivers/iio/accel/st_accel_core.c b/drivers/iio/accel/st_accel_core.c
> index 7cbdfae..53f3262 100644
> --- a/drivers/iio/accel/st_accel_core.c
> +++ b/drivers/iio/accel/st_accel_core.c
> @@ -457,8 +457,7 @@ static const struct iio_trigger_ops st_accel_trigger_ops = {
> #define ST_ACCEL_TRIGGER_OPS NULL
> #endif
>
> -int st_accel_common_probe(struct iio_dev *indio_dev,
> - struct st_sensors_platform_data *plat_data)
> +int st_accel_common_probe(struct iio_dev *indio_dev)
> {
> struct st_sensor_data *adata = iio_priv(indio_dev);
> int irq = adata->get_irq_data_ready(indio_dev);
> @@ -484,11 +483,11 @@ int st_accel_common_probe(struct iio_dev *indio_dev,
> &adata->sensor_settings->fs.fs_avl[0];
> adata->odr = adata->sensor_settings->odr.odr_avl[0].hz;
>
> - if (!plat_data)
> - plat_data =
> + if (!adata->dev->platform_data)
> + adata->dev->platform_data =
> (struct st_sensors_platform_data *)&default_accel_pdata;
>
> - err = st_sensors_init_sensor(indio_dev, plat_data);
> + err = st_sensors_init_sensor(indio_dev, adata->dev->platform_data);
> if (err < 0)
> return err;
>
> diff --git a/drivers/iio/accel/st_accel_i2c.c b/drivers/iio/accel/st_accel_i2c.c
> index 7164aef..40adc7e 100644
> --- a/drivers/iio/accel/st_accel_i2c.c
> +++ b/drivers/iio/accel/st_accel_i2c.c
> @@ -84,7 +84,7 @@ static int st_accel_i2c_probe(struct i2c_client *client,
>
> st_sensors_i2c_configure(indio_dev, client, adata);
>
> - err = st_accel_common_probe(indio_dev, client->dev.platform_data);
> + err = st_accel_common_probe(indio_dev);
> if (err < 0)
> return err;
>
> diff --git a/drivers/iio/accel/st_accel_spi.c b/drivers/iio/accel/st_accel_spi.c
> index 1956396..2090d80 100644
> --- a/drivers/iio/accel/st_accel_spi.c
> +++ b/drivers/iio/accel/st_accel_spi.c
> @@ -33,7 +33,7 @@ static int st_accel_spi_probe(struct spi_device *spi)
>
> st_sensors_spi_configure(indio_dev, spi, adata);
>
> - err = st_accel_common_probe(indio_dev, spi->dev.platform_data);
> + err = st_accel_common_probe(indio_dev);
> if (err < 0)
> return err;
>
>
next prev parent reply other threads:[~2014-10-04 10:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 15:35 [PATCH 1/7] iio:imu: changed structure name from st_sensors to st_sensor_settings Denis CIOCCA
2014-10-03 15:35 ` [PATCH 2/7] iio:accel: Removed unnecessary parameter on common_probe function Denis CIOCCA
2014-10-04 10:25 ` Jonathan Cameron [this message]
2014-10-03 15:35 ` [PATCH 3/7] iio:gyro: " Denis CIOCCA
2014-10-04 10:25 ` Jonathan Cameron
2014-10-03 15:35 ` [PATCH 4/7] iio:magnetometer: " Denis CIOCCA
2014-10-04 10:25 ` Jonathan Cameron
2014-10-03 15:35 ` [PATCH 5/7] iio:pressure: " Denis CIOCCA
2014-10-04 10:25 ` Jonathan Cameron
2014-10-03 15:35 ` [PATCH 6/7] iio:pressure: Changed pressure data variable name to press_data Denis CIOCCA
2014-10-04 10:26 ` Jonathan Cameron
2014-10-03 15:35 ` [PATCH 7/7] iio:common: Set the device pointer into ST common sensors library Denis CIOCCA
2014-10-04 10:26 ` Jonathan Cameron
2014-10-04 10:24 ` [PATCH 1/7] iio:imu: changed structure name from st_sensors to st_sensor_settings Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542FCAFD.2090200@kernel.org \
--to=jic23@kernel.org \
--cc=denis.ciocca@st.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.