From: Jonathan Cameron <jic23@kernel.org>
To: Denis CIOCCA <denis.ciocca@st.com>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH 3/7] iio:gyro: Removed unnecessary parameter on common_probe function
Date: Sat, 04 Oct 2014 11:25:15 +0100 [thread overview]
Message-ID: <542FCB0B.3080602@kernel.org> (raw)
In-Reply-To: <1412350541-29431-3-git-send-email-denis.ciocca@st.com>
On 03/10/14 16:35, Denis CIOCCA wrote:
> Signed-off-by: Denis Ciocca <denis.ciocca@st.com>
Applied.
> ---
> drivers/iio/gyro/st_gyro.h | 3 +--
> drivers/iio/gyro/st_gyro_core.c | 6 +++---
> drivers/iio/gyro/st_gyro_i2c.c | 3 +--
> drivers/iio/gyro/st_gyro_spi.c | 3 +--
> 4 files changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/iio/gyro/st_gyro.h b/drivers/iio/gyro/st_gyro.h
> index c197360..5353d63 100644
> --- a/drivers/iio/gyro/st_gyro.h
> +++ b/drivers/iio/gyro/st_gyro.h
> @@ -30,8 +30,7 @@ static const struct st_sensors_platform_data gyro_pdata = {
> .drdy_int_pin = 2,
> };
>
> -int st_gyro_common_probe(struct iio_dev *indio_dev,
> - struct st_sensors_platform_data *pdata);
> +int st_gyro_common_probe(struct iio_dev *indio_dev);
> void st_gyro_common_remove(struct iio_dev *indio_dev);
>
> #ifdef CONFIG_IIO_BUFFER
> diff --git a/drivers/iio/gyro/st_gyro_core.c b/drivers/iio/gyro/st_gyro_core.c
> index 9d41b68..f07a233 100644
> --- a/drivers/iio/gyro/st_gyro_core.c
> +++ b/drivers/iio/gyro/st_gyro_core.c
> @@ -309,8 +309,7 @@ static const struct iio_trigger_ops st_gyro_trigger_ops = {
> #define ST_GYRO_TRIGGER_OPS NULL
> #endif
>
> -int st_gyro_common_probe(struct iio_dev *indio_dev,
> - struct st_sensors_platform_data *pdata)
> +int st_gyro_common_probe(struct iio_dev *indio_dev)
> {
> struct st_sensor_data *gdata = iio_priv(indio_dev);
> int irq = gdata->get_irq_data_ready(indio_dev);
> @@ -336,7 +335,8 @@ int st_gyro_common_probe(struct iio_dev *indio_dev,
> &gdata->sensor_settings->fs.fs_avl[0];
> gdata->odr = gdata->sensor_settings->odr.odr_avl[0].hz;
>
> - err = st_sensors_init_sensor(indio_dev, pdata);
> + err = st_sensors_init_sensor(indio_dev,
> + (struct st_sensors_platform_data *)&gyro_pdata);
> if (err < 0)
> return err;
>
> diff --git a/drivers/iio/gyro/st_gyro_i2c.c b/drivers/iio/gyro/st_gyro_i2c.c
> index 8fa0ad2..94d01fb 100644
> --- a/drivers/iio/gyro/st_gyro_i2c.c
> +++ b/drivers/iio/gyro/st_gyro_i2c.c
> @@ -72,8 +72,7 @@ static int st_gyro_i2c_probe(struct i2c_client *client,
>
> st_sensors_i2c_configure(indio_dev, client, gdata);
>
> - err = st_gyro_common_probe(indio_dev,
> - (struct st_sensors_platform_data *)&gyro_pdata);
> + err = st_gyro_common_probe(indio_dev);
> if (err < 0)
> return err;
>
> diff --git a/drivers/iio/gyro/st_gyro_spi.c b/drivers/iio/gyro/st_gyro_spi.c
> index b4ad3be..3e7a01a 100644
> --- a/drivers/iio/gyro/st_gyro_spi.c
> +++ b/drivers/iio/gyro/st_gyro_spi.c
> @@ -33,8 +33,7 @@ static int st_gyro_spi_probe(struct spi_device *spi)
>
> st_sensors_spi_configure(indio_dev, spi, gdata);
>
> - err = st_gyro_common_probe(indio_dev,
> - (struct st_sensors_platform_data *)&gyro_pdata);
> + err = st_gyro_common_probe(indio_dev);
> if (err < 0)
> return err;
>
>
next prev parent reply other threads:[~2014-10-04 10:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 15:35 [PATCH 1/7] iio:imu: changed structure name from st_sensors to st_sensor_settings Denis CIOCCA
2014-10-03 15:35 ` [PATCH 2/7] iio:accel: Removed unnecessary parameter on common_probe function Denis CIOCCA
2014-10-04 10:25 ` Jonathan Cameron
2014-10-03 15:35 ` [PATCH 3/7] iio:gyro: " Denis CIOCCA
2014-10-04 10:25 ` Jonathan Cameron [this message]
2014-10-03 15:35 ` [PATCH 4/7] iio:magnetometer: " Denis CIOCCA
2014-10-04 10:25 ` Jonathan Cameron
2014-10-03 15:35 ` [PATCH 5/7] iio:pressure: " Denis CIOCCA
2014-10-04 10:25 ` Jonathan Cameron
2014-10-03 15:35 ` [PATCH 6/7] iio:pressure: Changed pressure data variable name to press_data Denis CIOCCA
2014-10-04 10:26 ` Jonathan Cameron
2014-10-03 15:35 ` [PATCH 7/7] iio:common: Set the device pointer into ST common sensors library Denis CIOCCA
2014-10-04 10:26 ` Jonathan Cameron
2014-10-04 10:24 ` [PATCH 1/7] iio:imu: changed structure name from st_sensors to st_sensor_settings Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542FCB0B.3080602@kernel.org \
--to=jic23@kernel.org \
--cc=denis.ciocca@st.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.