All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/6] sunxi: Use PG3 - PG8 as io-pins for mmc1
Date: Mon, 06 Oct 2014 10:37:05 +0200	[thread overview]
Message-ID: <543254B1.3070905@redhat.com> (raw)
In-Reply-To: <1412411824.17796.61.camel@hellion.org.uk>

Hi,

On 10/04/2014 10:37 AM, Ian Campbell wrote:
> On Fri, 2014-10-03 at 17:05 +0200, Hans de Goede wrote:
>> None of the known sunxi devices actually use mmc1 routed through PH, where
>> as some devices do actually use mmc1 routed through PG, so change the routing
>> of mmc1 to PG. If in the future we encounter devices with mmc1 routed through
>> PH, we will need to change things to be a bit more flexible.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> Although it seems that adding a Kconfig choice option would only be a
> dozen or so lines of pretty trivial stuff if we wanted to do it now.

This mostly seems to be a sun4i/sun7i vs sun5i thing. mmc1 could be routed
through PH on sun4i/sun7i, but actually is never used there, as PH typically
is used for gpio purposed on sun4i/sun7i, where as on sun5i (which has way
less pins), mmc1 goes out on PG, and actually is used as such there.

I have considered keeping the old pinmux settings using #if defined SUN5I
for the new ones, but since the old ones are never used just replacing
them seems better.

Regards,

Hans

  reply	other threads:[~2014-10-06  8:37 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-03 15:05 [U-Boot] [PATCH 0/6] sunxi: Add second sdcard slot support, including eMMC boot Hans de Goede
2014-10-03 15:05 ` [U-Boot] [PATCH 1/6] sunxi: Add sunxi_gpio_get_val function Hans de Goede
2014-10-04  8:14   ` Ian Campbell
2014-10-05 14:42     ` Hans de Goede
2014-10-03 15:05 ` [U-Boot] [PATCH 2/6] sunxi: Add mmc card-detect functionality Hans de Goede
2014-10-04  8:30   ` Ian Campbell
2014-10-05 14:58     ` Hans de Goede
2014-10-03 15:05 ` [U-Boot] [PATCH 3/6] sunxi: Turn MMC_SUNXI_SLOT_EXTRA into a proper Kconfig option Hans de Goede
2014-10-04  8:32   ` Ian Campbell
2014-10-05 15:00     ` Hans de Goede
2014-10-06  8:30       ` Ian Campbell
2014-10-03 15:05 ` [U-Boot] [PATCH 4/6] sunxi: When we've both mmc0 and mmc2, detect from which one we're booting Hans de Goede
2014-10-04  8:35   ` Ian Campbell
2014-10-05 15:10     ` Hans de Goede
2014-10-06  8:33       ` Ian Campbell
2014-10-06 14:23         ` Hans de Goede
2014-10-03 15:05 ` [U-Boot] [PATCH 5/6] sunxi: Use PG3 - PG8 as io-pins for mmc1 Hans de Goede
2014-10-04  8:37   ` Ian Campbell
2014-10-06  8:37     ` Hans de Goede [this message]
2014-10-06  8:42       ` Ian Campbell
2014-10-06 14:43     ` Hans de Goede
2014-10-06 15:42       ` Ian Campbell
2014-10-03 15:05 ` [U-Boot] [PATCH 6/6] sunxi: Enable second sdcard slot found on some boards Hans de Goede
2014-10-04  8:38   ` Ian Campbell
2014-10-04  8:39     ` Ian Campbell
2014-10-06  8:37       ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=543254B1.3070905@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.