From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/6] sunxi: When we've both mmc0 and mmc2, detect from which one we're booting
Date: Mon, 06 Oct 2014 16:23:36 +0200 [thread overview]
Message-ID: <5432A5E8.3040706@redhat.com> (raw)
In-Reply-To: <1412584414.12695.48.camel@hellion.org.uk>
Hi,
On 10/06/2014 10:33 AM, Ian Campbell wrote:
> On Sun, 2014-10-05 at 17:10 +0200, Hans de Goede wrote:
>>
>> On 10/04/2014 10:35 AM, Ian Campbell wrote:
>>> On Fri, 2014-10-03 at 17:05 +0200, Hans de Goede wrote:
>>>> sunxi SOCs can boot from both mmc0 and mmc2, detect from which one we're
>>>> booting, and make that one "mmc dev 0" so that a single u-boot binary can
>>>> be used for both the onboard eMMC and for external sdcards.
>>>
>>> Where does the dependency on dev 0 being the boot device come from? Is
>>> it just the env via CONFIG_SYS_MMC_ENV_DEV?
>>
>> No, the main reason why we need dev 0 to be the mmc we're actually booting
>> from is because that is where the SPL will load the tertiary payload
>> (the actual u-boot binary in our case) from, see:
>>
>> common/spl/spl_mmc.c
>>
>> Which has dev 0 hardcoded everywhere.
>
> I see. Could you paste this bit of reasoning into the commit log please?
> (pretty much s/No, t/T/ on the above would do IMHO)
Done for v2.
Regards,
Hans
next prev parent reply other threads:[~2014-10-06 14:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 15:05 [U-Boot] [PATCH 0/6] sunxi: Add second sdcard slot support, including eMMC boot Hans de Goede
2014-10-03 15:05 ` [U-Boot] [PATCH 1/6] sunxi: Add sunxi_gpio_get_val function Hans de Goede
2014-10-04 8:14 ` Ian Campbell
2014-10-05 14:42 ` Hans de Goede
2014-10-03 15:05 ` [U-Boot] [PATCH 2/6] sunxi: Add mmc card-detect functionality Hans de Goede
2014-10-04 8:30 ` Ian Campbell
2014-10-05 14:58 ` Hans de Goede
2014-10-03 15:05 ` [U-Boot] [PATCH 3/6] sunxi: Turn MMC_SUNXI_SLOT_EXTRA into a proper Kconfig option Hans de Goede
2014-10-04 8:32 ` Ian Campbell
2014-10-05 15:00 ` Hans de Goede
2014-10-06 8:30 ` Ian Campbell
2014-10-03 15:05 ` [U-Boot] [PATCH 4/6] sunxi: When we've both mmc0 and mmc2, detect from which one we're booting Hans de Goede
2014-10-04 8:35 ` Ian Campbell
2014-10-05 15:10 ` Hans de Goede
2014-10-06 8:33 ` Ian Campbell
2014-10-06 14:23 ` Hans de Goede [this message]
2014-10-03 15:05 ` [U-Boot] [PATCH 5/6] sunxi: Use PG3 - PG8 as io-pins for mmc1 Hans de Goede
2014-10-04 8:37 ` Ian Campbell
2014-10-06 8:37 ` Hans de Goede
2014-10-06 8:42 ` Ian Campbell
2014-10-06 14:43 ` Hans de Goede
2014-10-06 15:42 ` Ian Campbell
2014-10-03 15:05 ` [U-Boot] [PATCH 6/6] sunxi: Enable second sdcard slot found on some boards Hans de Goede
2014-10-04 8:38 ` Ian Campbell
2014-10-04 8:39 ` Ian Campbell
2014-10-06 8:37 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5432A5E8.3040706@redhat.com \
--to=hdegoede@redhat.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.