From: Chris Zhong <zyw@rock-chips.com>
To: "Mark Brown" <broonie@kernel.org>, "Heiko Stübner" <heiko@sntech.de>
Cc: Doug Anderson <dianders@chromium.org>,
linux-rockchip@lists.infradead.org,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: rk808: Fix min_uV for DCDC1 & DCDC2
Date: Tue, 07 Oct 2014 11:29:15 +0800 [thread overview]
Message-ID: <54335E0B.301@rock-chips.com> (raw)
In-Reply-To: <20140930225241.GO4273@sirena.org.uk>
On 10/01/2014 06:52 AM, Mark Brown wrote:
> On Tue, Sep 30, 2014 at 06:57:51PM +0200, Heiko Stübner wrote:
>> Am Dienstag, 30. September 2014, 09:43:47 schrieb Doug Anderson:
>>> On Tue, Sep 30, 2014 at 2:44 AM, Chris Zhong <zyw@rock-chips.com> wrote:
>>>> - REGULATOR_LINEAR_RANGE(700000, 0, 63, 12500),
>>>> + REGULATOR_LINEAR_RANGE(712500, 0, 63, 12500),
>>> I have no problem with this (and the current "dts" file I see don't go
>>> this low anyway), but it doesn't match the datasheet I have right now
>>> which says "0.700 V" is the min.
>> Then it would be problem.
>> The original statement above says, that a register value of "0" equals 700mV,
>> so changing this in this way would mean everything runs 12.5mV above the
>> target voltage.
>> And I can confirm, that the current datasheet lists 700mV as equallying
>> register value 0.
> Has anyone got a voltmeter?
The latest datasheet has fixed this error.
The register value of "0" equals 712.5mV, so the max value can reach
1.5v but not 1.4875v.
next prev parent reply other threads:[~2014-10-07 3:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 9:44 [PATCH] regulator: rk808: Fix min_uV for DCDC1 & DCDC2 Chris Zhong
2014-09-30 16:43 ` Doug Anderson
2014-09-30 16:57 ` Heiko Stübner
2014-09-30 22:52 ` Mark Brown
2014-10-07 3:29 ` Chris Zhong [this message]
2014-10-07 4:54 ` Doug Anderson
2014-10-07 19:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54335E0B.301@rock-chips.com \
--to=zyw@rock-chips.com \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.