* [PATCH] regulator: rk808: Fix min_uV for DCDC1 & DCDC2 @ 2014-09-30 9:44 Chris Zhong 2014-09-30 16:43 ` Doug Anderson 2014-10-07 19:40 ` Mark Brown 0 siblings, 2 replies; 7+ messages in thread From: Chris Zhong @ 2014-09-30 9:44 UTC (permalink / raw) To: dianders, heiko Cc: linux-rockchip, Chris Zhong, Liam Girdwood, Mark Brown, linux-kernel The min_uv in DCDC1 & DCDC2 should be 712.5mv Signed-off-by: Chris Zhong <zyw@rock-chips.com> --- drivers/regulator/rk808-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/rk808-regulator.c b/drivers/regulator/rk808-regulator.c index e305416..196a5c8 100644 --- a/drivers/regulator/rk808-regulator.c +++ b/drivers/regulator/rk808-regulator.c @@ -44,7 +44,7 @@ static const int rk808_buck_config_regs[] = { }; static const struct regulator_linear_range rk808_buck_voltage_ranges[] = { - REGULATOR_LINEAR_RANGE(700000, 0, 63, 12500), + REGULATOR_LINEAR_RANGE(712500, 0, 63, 12500), }; static const struct regulator_linear_range rk808_buck4_voltage_ranges[] = { -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] regulator: rk808: Fix min_uV for DCDC1 & DCDC2 2014-09-30 9:44 [PATCH] regulator: rk808: Fix min_uV for DCDC1 & DCDC2 Chris Zhong @ 2014-09-30 16:43 ` Doug Anderson 2014-09-30 16:57 ` Heiko Stübner 2014-10-07 19:40 ` Mark Brown 1 sibling, 1 reply; 7+ messages in thread From: Doug Anderson @ 2014-09-30 16:43 UTC (permalink / raw) To: Chris Zhong Cc: Heiko Stübner, linux-rockchip, Liam Girdwood, Mark Brown, linux-kernel@vger.kernel.org Chris, On Tue, Sep 30, 2014 at 2:44 AM, Chris Zhong <zyw@rock-chips.com> wrote: > The min_uv in DCDC1 & DCDC2 should be 712.5mv > > Signed-off-by: Chris Zhong <zyw@rock-chips.com> > > --- > > drivers/regulator/rk808-regulator.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/regulator/rk808-regulator.c b/drivers/regulator/rk808-regulator.c > index e305416..196a5c8 100644 > --- a/drivers/regulator/rk808-regulator.c > +++ b/drivers/regulator/rk808-regulator.c > @@ -44,7 +44,7 @@ static const int rk808_buck_config_regs[] = { > }; > > static const struct regulator_linear_range rk808_buck_voltage_ranges[] = { > - REGULATOR_LINEAR_RANGE(700000, 0, 63, 12500), > + REGULATOR_LINEAR_RANGE(712500, 0, 63, 12500), > }; I have no problem with this (and the current "dts" file I see don't go this low anyway), but it doesn't match the datasheet I have right now which says "0.700 V" is the min. -Doug ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] regulator: rk808: Fix min_uV for DCDC1 & DCDC2 2014-09-30 16:43 ` Doug Anderson @ 2014-09-30 16:57 ` Heiko Stübner 2014-09-30 22:52 ` Mark Brown 0 siblings, 1 reply; 7+ messages in thread From: Heiko Stübner @ 2014-09-30 16:57 UTC (permalink / raw) To: Doug Anderson Cc: Chris Zhong, linux-rockchip, Liam Girdwood, Mark Brown, linux-kernel@vger.kernel.org Am Dienstag, 30. September 2014, 09:43:47 schrieb Doug Anderson: > Chris, > > On Tue, Sep 30, 2014 at 2:44 AM, Chris Zhong <zyw@rock-chips.com> wrote: > > The min_uv in DCDC1 & DCDC2 should be 712.5mv > > > > Signed-off-by: Chris Zhong <zyw@rock-chips.com> > > > > --- > > > > drivers/regulator/rk808-regulator.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/regulator/rk808-regulator.c > > b/drivers/regulator/rk808-regulator.c index e305416..196a5c8 100644 > > --- a/drivers/regulator/rk808-regulator.c > > +++ b/drivers/regulator/rk808-regulator.c > > @@ -44,7 +44,7 @@ static const int rk808_buck_config_regs[] = { > > > > }; > > > > static const struct regulator_linear_range rk808_buck_voltage_ranges[] = > > { > > > > - REGULATOR_LINEAR_RANGE(700000, 0, 63, 12500), > > + REGULATOR_LINEAR_RANGE(712500, 0, 63, 12500), > > > > }; > > I have no problem with this (and the current "dts" file I see don't go > this low anyway), but it doesn't match the datasheet I have right now > which says "0.700 V" is the min. Then it would be problem. The original statement above says, that a register value of "0" equals 700mV, so changing this in this way would mean everything runs 12.5mV above the target voltage. And I can confirm, that the current datasheet lists 700mV as equallying register value 0. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] regulator: rk808: Fix min_uV for DCDC1 & DCDC2 2014-09-30 16:57 ` Heiko Stübner @ 2014-09-30 22:52 ` Mark Brown 2014-10-07 3:29 ` Chris Zhong 0 siblings, 1 reply; 7+ messages in thread From: Mark Brown @ 2014-09-30 22:52 UTC (permalink / raw) To: Heiko Stübner Cc: Doug Anderson, Chris Zhong, linux-rockchip, Liam Girdwood, linux-kernel@vger.kernel.org [-- Attachment #1: Type: text/plain, Size: 866 bytes --] On Tue, Sep 30, 2014 at 06:57:51PM +0200, Heiko Stübner wrote: > Am Dienstag, 30. September 2014, 09:43:47 schrieb Doug Anderson: > > On Tue, Sep 30, 2014 at 2:44 AM, Chris Zhong <zyw@rock-chips.com> wrote: > > > - REGULATOR_LINEAR_RANGE(700000, 0, 63, 12500), > > > + REGULATOR_LINEAR_RANGE(712500, 0, 63, 12500), > > I have no problem with this (and the current "dts" file I see don't go > > this low anyway), but it doesn't match the datasheet I have right now > > which says "0.700 V" is the min. > Then it would be problem. > The original statement above says, that a register value of "0" equals 700mV, > so changing this in this way would mean everything runs 12.5mV above the > target voltage. > And I can confirm, that the current datasheet lists 700mV as equallying > register value 0. Has anyone got a voltmeter? [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 473 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] regulator: rk808: Fix min_uV for DCDC1 & DCDC2 2014-09-30 22:52 ` Mark Brown @ 2014-10-07 3:29 ` Chris Zhong 2014-10-07 4:54 ` Doug Anderson 0 siblings, 1 reply; 7+ messages in thread From: Chris Zhong @ 2014-10-07 3:29 UTC (permalink / raw) To: Mark Brown, Heiko Stübner Cc: Doug Anderson, linux-rockchip, Liam Girdwood, linux-kernel@vger.kernel.org On 10/01/2014 06:52 AM, Mark Brown wrote: > On Tue, Sep 30, 2014 at 06:57:51PM +0200, Heiko Stübner wrote: >> Am Dienstag, 30. September 2014, 09:43:47 schrieb Doug Anderson: >>> On Tue, Sep 30, 2014 at 2:44 AM, Chris Zhong <zyw@rock-chips.com> wrote: >>>> - REGULATOR_LINEAR_RANGE(700000, 0, 63, 12500), >>>> + REGULATOR_LINEAR_RANGE(712500, 0, 63, 12500), >>> I have no problem with this (and the current "dts" file I see don't go >>> this low anyway), but it doesn't match the datasheet I have right now >>> which says "0.700 V" is the min. >> Then it would be problem. >> The original statement above says, that a register value of "0" equals 700mV, >> so changing this in this way would mean everything runs 12.5mV above the >> target voltage. >> And I can confirm, that the current datasheet lists 700mV as equallying >> register value 0. > Has anyone got a voltmeter? The latest datasheet has fixed this error. The register value of "0" equals 712.5mV, so the max value can reach 1.5v but not 1.4875v. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] regulator: rk808: Fix min_uV for DCDC1 & DCDC2 2014-10-07 3:29 ` Chris Zhong @ 2014-10-07 4:54 ` Doug Anderson 0 siblings, 0 replies; 7+ messages in thread From: Doug Anderson @ 2014-10-07 4:54 UTC (permalink / raw) To: Chris Zhong Cc: Mark Brown, Heiko Stübner, linux-rockchip, Liam Girdwood, linux-kernel@vger.kernel.org Chris and Mark, On Mon, Oct 6, 2014 at 8:29 PM, Chris Zhong <zyw@rock-chips.com> wrote: > > On 10/01/2014 06:52 AM, Mark Brown wrote: >> >> On Tue, Sep 30, 2014 at 06:57:51PM +0200, Heiko Stübner wrote: >>> >>> Am Dienstag, 30. September 2014, 09:43:47 schrieb Doug Anderson: >>>> >>>> On Tue, Sep 30, 2014 at 2:44 AM, Chris Zhong <zyw@rock-chips.com> wrote: >>>>> >>>>> - REGULATOR_LINEAR_RANGE(700000, 0, 63, 12500), >>>>> + REGULATOR_LINEAR_RANGE(712500, 0, 63, 12500), >>>> >>>> I have no problem with this (and the current "dts" file I see don't go >>>> this low anyway), but it doesn't match the datasheet I have right now >>>> which says "0.700 V" is the min. >>> >>> Then it would be problem. >>> The original statement above says, that a register value of "0" equals >>> 700mV, >>> so changing this in this way would mean everything runs 12.5mV above the >>> target voltage. >>> And I can confirm, that the current datasheet lists 700mV as equallying >>> register value 0. >> >> Has anyone got a voltmeter? > > The latest datasheet has fixed this error. > The register value of "0" equals 712.5mV, so the max value can reach 1.5v > but not 1.4875v. OK, that sounds like this is the right change, then. To Mark's point, I measured voltage using the builtin voltage measurement feature this board (not 100% sure the accuracy / precision guarantees on them, but...): Asked for 1.300 volts on vdd_arm (dcdc1). * Before: got 1.326 * After: got 1.310 Asked for 1.3 on vdd_gpu (dcdc2): * Before: 1.326 * After: got 1.314 Asked for 1.0 on vdd_gpu: * Before: 1.038 * After: got 1.026 Asked for .8 on vdd_gpu * Before:.836 * After: got .822 It almost sounds like we're still running a little too high for voltages, but this gets us in the right direction I guess. -Doug ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] regulator: rk808: Fix min_uV for DCDC1 & DCDC2 2014-09-30 9:44 [PATCH] regulator: rk808: Fix min_uV for DCDC1 & DCDC2 Chris Zhong 2014-09-30 16:43 ` Doug Anderson @ 2014-10-07 19:40 ` Mark Brown 1 sibling, 0 replies; 7+ messages in thread From: Mark Brown @ 2014-10-07 19:40 UTC (permalink / raw) To: Chris Zhong; +Cc: dianders, heiko, linux-rockchip, Liam Girdwood, linux-kernel [-- Attachment #1: Type: text/plain, Size: 127 bytes --] On Tue, Sep 30, 2014 at 05:44:54PM +0800, Chris Zhong wrote: > The min_uv in DCDC1 & DCDC2 should be 712.5mv Applied, thanks. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 473 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-10-07 19:40 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-09-30 9:44 [PATCH] regulator: rk808: Fix min_uV for DCDC1 & DCDC2 Chris Zhong 2014-09-30 16:43 ` Doug Anderson 2014-09-30 16:57 ` Heiko Stübner 2014-09-30 22:52 ` Mark Brown 2014-10-07 3:29 ` Chris Zhong 2014-10-07 4:54 ` Doug Anderson 2014-10-07 19:40 ` Mark Brown
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.