Re: [RFC PATCH 07/13] xen/arm: enable cpu hotplug

[Julien Grall <julien.grall@linaro.org>]

Hi Oleksandr,

On 10/07/2014 03:19 PM, Oleksandr Dmytryshyn wrote:
> This config is needed for the cpufreq driver.

Can you expand why your really need it? I don't find any usage of those
define except in:
	include/xen/cpumask.h
	include/xen/init.h

Technically, supporting CPU hotplug in Xen ARM will require more than
enabling those defines. I doubt the code is ready for CPU hotplugging
(for instance see setup_virt_paging).

Regards,

> Signed-off-by: Oleksandr Dmytryshyn <oleksandr.dmytryshyn@globallogic.com>
> ---
>  xen/include/asm-arm/config.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/xen/include/asm-arm/config.h b/xen/include/asm-arm/config.h
> index 5b7b1a8..ca17c79 100644
> --- a/xen/include/asm-arm/config.h
> +++ b/xen/include/asm-arm/config.h
> @@ -203,6 +203,9 @@ extern unsigned long frametable_virt_end;
>  #define GIC_VR_OFFSET 0x6000 /* Virtual Machine CPU interface) */
>  #endif /* __ASSEMBLY__ */
>  
> +#define CONFIG_HOTPLUG 1
> +#define CONFIG_HOTPLUG_CPU 1
> +
>  #endif /* __ARM_CONFIG_H__ */
>  /*
>   * Local variables:
> 


-- 
Julien Grall