From: Stephen Boyd <sboyd@codeaurora.org>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Mike Turquette <mturquette@linaro.org>,
Paul Walmsley <paul@pwsan.com>, Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Subject: Re: [PATCH 1/2] clk: Make clk API return per-user struct clk instances
Date: Tue, 07 Oct 2014 11:43:21 -0700 [thread overview]
Message-ID: <54343449.1020605@codeaurora.org> (raw)
In-Reply-To: <CAAObsKD6=xRqR9m8dNATUAuiky-HZW4LHJtnG1BbpO8dsBBJPg@mail.gmail.com>
On 10/07/2014 08:28 AM, Tomeu Vizoso wrote:
> On 4 October 2014 01:15, Stephen Boyd <sboyd@codeaurora.org> wrote:
>> On 10/02, Tomeu Vizoso wrote:
>>> +
>>> #if defined(CONFIG_OF) && defined(CONFIG_COMMON_CLK)
>> These ifdefs look useless.
>>
>>> struct clk *of_clk_get_by_clkspec(struct of_phandle_args *clkspec);
>>> struct clk *__of_clk_get_from_provider(struct of_phandle_args *clkspec);
>>> void of_clk_lock(void);
>>> void of_clk_unlock(void);
>>> #endif
>>> +
>>> +#if defined(CONFIG_COMMON_CLK)
>> So we shouldn't need this one either.
> Actually, i had to put it back so clkdev.c builds on
> !CONFIG_COMMON_CLK. Do you have another idea on how to deal with this?
What's the error? Probably need to add a forward declaration for struct
clk, struct of_phandle_args, and struct clk_hw.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] clk: Make clk API return per-user struct clk instances
Date: Tue, 07 Oct 2014 11:43:21 -0700 [thread overview]
Message-ID: <54343449.1020605@codeaurora.org> (raw)
In-Reply-To: <CAAObsKD6=xRqR9m8dNATUAuiky-HZW4LHJtnG1BbpO8dsBBJPg@mail.gmail.com>
On 10/07/2014 08:28 AM, Tomeu Vizoso wrote:
> On 4 October 2014 01:15, Stephen Boyd <sboyd@codeaurora.org> wrote:
>> On 10/02, Tomeu Vizoso wrote:
>>> +
>>> #if defined(CONFIG_OF) && defined(CONFIG_COMMON_CLK)
>> These ifdefs look useless.
>>
>>> struct clk *of_clk_get_by_clkspec(struct of_phandle_args *clkspec);
>>> struct clk *__of_clk_get_from_provider(struct of_phandle_args *clkspec);
>>> void of_clk_lock(void);
>>> void of_clk_unlock(void);
>>> #endif
>>> +
>>> +#if defined(CONFIG_COMMON_CLK)
>> So we shouldn't need this one either.
> Actually, i had to put it back so clkdev.c builds on
> !CONFIG_COMMON_CLK. Do you have another idea on how to deal with this?
What's the error? Probably need to add a forward declaration for struct
clk, struct of_phandle_args, and struct clk_hw.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-10-07 18:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 13:04 [PATCH 0/2] Per-user clock constraints Tomeu Vizoso
2014-10-02 13:04 ` Tomeu Vizoso
2014-10-02 13:04 ` [PATCH 1/2] clk: Make clk API return per-user struct clk instances Tomeu Vizoso
2014-10-02 13:04 ` Tomeu Vizoso
2014-10-03 23:15 ` Stephen Boyd
2014-10-03 23:15 ` Stephen Boyd
2014-10-06 17:14 ` Tomeu Vizoso
2014-10-06 17:14 ` Tomeu Vizoso
2014-10-06 19:31 ` Stephen Boyd
2014-10-06 19:31 ` Stephen Boyd
2014-10-07 15:28 ` Tomeu Vizoso
2014-10-07 15:28 ` Tomeu Vizoso
2014-10-07 18:43 ` Stephen Boyd [this message]
2014-10-07 18:43 ` Stephen Boyd
2014-10-02 13:04 ` [PATCH 2/2] clk: Add floor and ceiling constraints to clock rates Tomeu Vizoso
2014-10-02 13:04 ` Tomeu Vizoso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54343449.1020605@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=javier.martinez@collabora.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mturquette@linaro.org \
--cc=paul@pwsan.com \
--cc=tomeu.vizoso@collabora.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.