From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
horms@verge.net.au, magnus.damm@gmail.com, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux@arm.linux.org.uk
Cc: devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm: shmobile: lager: enable HS-USB
Date: Tue, 07 Oct 2014 19:15:50 +0000 [thread overview]
Message-ID: <54343BE6.2020903@cogentembedded.com> (raw)
In-Reply-To: <5433DA52.2020005@renesas.com>
Hello.
On 10/07/2014 04:19 PM, Yoshihiro Shimoda wrote:
>>> Since this board doesn't have USB ID pin, we assumes the GP5_18 (USB0_PWEN)
>>> is an ID pin because the gpio is high when the SW5 is Pin 3 side.
>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>> ---
>>> arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
>>> index 719979e..011254a 100644
>>> --- a/arch/arm/boot/dts/r8a7790-lager.dts
>>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
>>> @@ -446,3 +446,8 @@
>>> };
>>> };
>>> };
>>> +
>>> +&hsusb {
>>> + status = "okay";
>>> + renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_HIGH>;
>>> +};
>> As I said before, this is not enough. We need pinctrl-related props. Same is true for other boards.
> Thank you very much for the point again.
> Finally I understood what you said before.
> I will start studying the pinctrl world.
Looks like it will be quicker if I post v3 of your patches.
Unfortunately, there'll be pinctrl-related error messages in the log if
the internal PCI and HS-USB drivers are enabled together but everything should
still work.
> Best regards,
> Yoshihiro Shimoda
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
horms@verge.net.au, magnus.damm@gmail.com, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux@arm.linux.org.uk
Cc: devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm: shmobile: lager: enable HS-USB
Date: Tue, 07 Oct 2014 23:15:50 +0400 [thread overview]
Message-ID: <54343BE6.2020903@cogentembedded.com> (raw)
In-Reply-To: <5433DA52.2020005@renesas.com>
Hello.
On 10/07/2014 04:19 PM, Yoshihiro Shimoda wrote:
>>> Since this board doesn't have USB ID pin, we assumes the GP5_18 (USB0_PWEN)
>>> is an ID pin because the gpio is high when the SW5 is Pin 3 side.
>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>> ---
>>> arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
>>> index 719979e..011254a 100644
>>> --- a/arch/arm/boot/dts/r8a7790-lager.dts
>>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
>>> @@ -446,3 +446,8 @@
>>> };
>>> };
>>> };
>>> +
>>> +&hsusb {
>>> + status = "okay";
>>> + renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_HIGH>;
>>> +};
>> As I said before, this is not enough. We need pinctrl-related props. Same is true for other boards.
> Thank you very much for the point again.
> Finally I understood what you said before.
> I will start studying the pinctrl world.
Looks like it will be quicker if I post v3 of your patches.
Unfortunately, there'll be pinctrl-related error messages in the log if
the internal PCI and HS-USB drivers are enabled together but everything should
still work.
> Best regards,
> Yoshihiro Shimoda
WBR, Sergei
next prev parent reply other threads:[~2014-10-07 19:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 11:10 [PATCH v2 0/2] arm: shimobile: add HS-USB device node on r8a7790 Yoshihiro Shimoda
2014-10-07 11:10 ` Yoshihiro Shimoda
2014-10-07 11:10 ` [PATCH v2 1/2] arm: shmobile: r8a7790: add HS-USB device node Yoshihiro Shimoda
2014-10-07 11:10 ` Yoshihiro Shimoda
[not found] ` <1412680220-4552-1-git-send-email-yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2014-10-07 11:10 ` [PATCH v2 2/2] arm: shmobile: lager: enable HS-USB Yoshihiro Shimoda
2014-10-07 11:10 ` Yoshihiro Shimoda
2014-10-07 11:42 ` Sergei Shtylyov
2014-10-07 11:42 ` Sergei Shtylyov
2014-10-07 12:19 ` Yoshihiro Shimoda
2014-10-07 12:19 ` Yoshihiro Shimoda
2014-10-07 19:15 ` Sergei Shtylyov [this message]
2014-10-07 19:15 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54343BE6.2020903@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=horms@verge.net.au \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-sh@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.