From: Jaehoon Chung <jh80.chung@samsung.com>
To: Doug Anderson <dianders@chromium.org>, Sonny Rao <sonnyrao@chromium.org>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Seungwon Jeon <tgih.jun@samsung.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Eddie Cai <eddie.cai@rock-chips.com>,
Addy Ke <addy.ke@rock-chips.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: dw_mmc: Reset DMA before enabling IDMAC
Date: Wed, 08 Oct 2014 08:59:46 +0900 [thread overview]
Message-ID: <54347E72.8010203@samsung.com> (raw)
In-Reply-To: <CAD=FV=W-GW0c8m_5Oaet=ZhJJwmk4RWJ7QurcySB7T8YvKr6Sg@mail.gmail.com>
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
On 10/07/2014 03:11 AM, Doug Anderson wrote:
> Sonny,
>
> On Mon, Oct 6, 2014 at 10:53 AM, Sonny Rao <sonnyrao@chromium.org> wrote:
>> We've already got a reset of DMA after it's done. Add one before we
>> start DMA too. This fixes a data corruption on Rockchip SoCs which
>> will get bad data when doing a DMA transfer after doing a PIO transfer.
>>
>> We tested this on an Exynos 5800 with HS200 and didn't notice any
>> difference in sequential read throughput.
>>
>> Signed-off-by: Sonny Rao <sonnyrao@chromium.org>
>> Signed-off-by: Doug Anderson <dianders@chromium.org>
>> ---
>> drivers/mmc/host/dw_mmc.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> Tested-by: Doug Anderson <dianders@chromium.org>
>
WARNING: multiple messages have this Message-ID (diff)
From: jh80.chung@samsung.com (Jaehoon Chung)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmc: dw_mmc: Reset DMA before enabling IDMAC
Date: Wed, 08 Oct 2014 08:59:46 +0900 [thread overview]
Message-ID: <54347E72.8010203@samsung.com> (raw)
In-Reply-To: <CAD=FV=W-GW0c8m_5Oaet=ZhJJwmk4RWJ7QurcySB7T8YvKr6Sg@mail.gmail.com>
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
On 10/07/2014 03:11 AM, Doug Anderson wrote:
> Sonny,
>
> On Mon, Oct 6, 2014 at 10:53 AM, Sonny Rao <sonnyrao@chromium.org> wrote:
>> We've already got a reset of DMA after it's done. Add one before we
>> start DMA too. This fixes a data corruption on Rockchip SoCs which
>> will get bad data when doing a DMA transfer after doing a PIO transfer.
>>
>> We tested this on an Exynos 5800 with HS200 and didn't notice any
>> difference in sequential read throughput.
>>
>> Signed-off-by: Sonny Rao <sonnyrao@chromium.org>
>> Signed-off-by: Doug Anderson <dianders@chromium.org>
>> ---
>> drivers/mmc/host/dw_mmc.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> Tested-by: Doug Anderson <dianders@chromium.org>
>
next prev parent reply other threads:[~2014-10-07 23:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 17:53 [PATCH] mmc: dw_mmc: Reset DMA before enabling IDMAC Sonny Rao
2014-10-06 17:53 ` Sonny Rao
2014-10-06 18:11 ` Doug Anderson
2014-10-06 18:11 ` Doug Anderson
2014-10-07 23:59 ` Jaehoon Chung [this message]
2014-10-07 23:59 ` Jaehoon Chung
2014-10-08 11:28 ` Alim Akhtar
2014-10-08 11:28 ` Alim Akhtar
[not found] ` <CAO3aYcqi0g=eJta33s5oM-tAAmAhe86VvHd43p5RJ7qMPZzfrg@mail.gmail.com>
2014-10-09 22:19 ` Alim Akhtar
2014-10-09 22:19 ` Alim Akhtar
2014-10-10 0:36 ` Doug Anderson
2014-10-10 0:36 ` Doug Anderson
2014-10-14 16:51 ` Doug Anderson
2014-10-14 16:51 ` Doug Anderson
2014-10-14 19:58 ` Alim Akhtar
2014-10-14 19:58 ` Alim Akhtar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54347E72.8010203@samsung.com \
--to=jh80.chung@samsung.com \
--cc=addy.ke@rock-chips.com \
--cc=dianders@chromium.org \
--cc=eddie.cai@rock-chips.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=sonnyrao@chromium.org \
--cc=tgih.jun@samsung.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.