All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.coquelin@st.com (Maxime Coquelin)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 0/2] mfd: syscon: declare holes in syscon register maps
Date: Wed, 8 Oct 2014 13:12:37 +0200	[thread overview]
Message-ID: <54351C25.70604@st.com> (raw)
In-Reply-To: <1412688148-20835-1-git-send-email-seraphin.bonnaffe@st.com>

Hi Seraphin,

On 10/07/2014 03:22 PM, Seraphin Bonnaffe wrote:
> In reply to mail: Holes management in syscon driver.
> 
> Hi Dong, Maxime, Lee, all,
> 
> Regmap also offers .rd_table and .wr_table structures that can be used to
> specify valid ranges within agiven regmap configuration.
> 
> This patch uses these structures to declare holes in a syscon instance.
> It takes the description from DT, and fills in the structures accordingly.
> 
> Can I have your opinion on this implementation ?

As discussed face to face, it looks fine to me.

But we would like green light in the new "holes" property introduced.

Thanks,
Maxime

> 
> Thanks and Regards,
> Seraphin
> 
> Seraphin Bonnaffe (2):
>    mfd: syscon: Document new DT binding "holes"
>    mfd: syscon: specify rd_table and wr_table from DT
> 
>   Documentation/devicetree/bindings/mfd/syscon.txt |  5 ++++
>   drivers/mfd/syscon.c                             | 35 ++++++++++++++++++++++++
>   2 files changed, 40 insertions(+)
> 

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Coquelin <maxime.coquelin@st.com>
To: Seraphin Bonnaffe <seraphin.bonnaffe@st.com>,
	b29396@freescale.com, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	lee.jones@linaro.org
Cc: sameo@linux.intel.com, grant.likely@linaro.org,
	robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	arnd@arndb.de
Subject: Re: [RFC PATCH 0/2] mfd: syscon: declare holes in syscon register maps
Date: Wed, 8 Oct 2014 13:12:37 +0200	[thread overview]
Message-ID: <54351C25.70604@st.com> (raw)
In-Reply-To: <1412688148-20835-1-git-send-email-seraphin.bonnaffe@st.com>

Hi Seraphin,

On 10/07/2014 03:22 PM, Seraphin Bonnaffe wrote:
> In reply to mail: Holes management in syscon driver.
> 
> Hi Dong, Maxime, Lee, all,
> 
> Regmap also offers .rd_table and .wr_table structures that can be used to
> specify valid ranges within agiven regmap configuration.
> 
> This patch uses these structures to declare holes in a syscon instance.
> It takes the description from DT, and fills in the structures accordingly.
> 
> Can I have your opinion on this implementation ?

As discussed face to face, it looks fine to me.

But we would like green light in the new "holes" property introduced.

Thanks,
Maxime

> 
> Thanks and Regards,
> Seraphin
> 
> Seraphin Bonnaffe (2):
>    mfd: syscon: Document new DT binding "holes"
>    mfd: syscon: specify rd_table and wr_table from DT
> 
>   Documentation/devicetree/bindings/mfd/syscon.txt |  5 ++++
>   drivers/mfd/syscon.c                             | 35 ++++++++++++++++++++++++
>   2 files changed, 40 insertions(+)
> 

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Coquelin <maxime.coquelin@st.com>
To: Seraphin Bonnaffe <seraphin.bonnaffe@st.com>,
	<b29396@freescale.com>, <linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<lee.jones@linaro.org>
Cc: <sameo@linux.intel.com>, <grant.likely@linaro.org>,
	<robh+dt@kernel.org>, <pawel.moll@arm.com>,
	<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
	<galak@codeaurora.org>, <arnd@arndb.de>
Subject: Re: [RFC PATCH 0/2] mfd: syscon: declare holes in syscon register maps
Date: Wed, 8 Oct 2014 13:12:37 +0200	[thread overview]
Message-ID: <54351C25.70604@st.com> (raw)
In-Reply-To: <1412688148-20835-1-git-send-email-seraphin.bonnaffe@st.com>

Hi Seraphin,

On 10/07/2014 03:22 PM, Seraphin Bonnaffe wrote:
> In reply to mail: Holes management in syscon driver.
> 
> Hi Dong, Maxime, Lee, all,
> 
> Regmap also offers .rd_table and .wr_table structures that can be used to
> specify valid ranges within agiven regmap configuration.
> 
> This patch uses these structures to declare holes in a syscon instance.
> It takes the description from DT, and fills in the structures accordingly.
> 
> Can I have your opinion on this implementation ?

As discussed face to face, it looks fine to me.

But we would like green light in the new "holes" property introduced.

Thanks,
Maxime

> 
> Thanks and Regards,
> Seraphin
> 
> Seraphin Bonnaffe (2):
>    mfd: syscon: Document new DT binding "holes"
>    mfd: syscon: specify rd_table and wr_table from DT
> 
>   Documentation/devicetree/bindings/mfd/syscon.txt |  5 ++++
>   drivers/mfd/syscon.c                             | 35 ++++++++++++++++++++++++
>   2 files changed, 40 insertions(+)
> 

  parent reply	other threads:[~2014-10-08 11:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-25 16:44 Holes management in syscon driver Maxime Coquelin
2014-09-25 16:44 ` Maxime Coquelin
2014-10-07 13:22 ` [RFC PATCH 0/2] mfd: syscon: declare holes in syscon register maps Seraphin Bonnaffe
2014-10-07 13:22   ` Seraphin Bonnaffe
2014-10-07 13:22   ` Seraphin Bonnaffe
2014-10-07 13:22   ` [RFC PATCH 1/2] mfd: syscon: Document new DT binding "holes" Seraphin Bonnaffe
2014-10-07 13:22     ` Seraphin Bonnaffe
2014-10-07 13:22     ` Seraphin Bonnaffe
2014-10-07 13:22   ` [RFC PATCH 2/2] mfd: syscon: specify rd_table and wr_table from DT Seraphin Bonnaffe
2014-10-07 13:22     ` Seraphin Bonnaffe
2014-10-07 13:22     ` Seraphin Bonnaffe
2014-10-08 11:12   ` Maxime Coquelin [this message]
2014-10-08 11:12     ` [RFC PATCH 0/2] mfd: syscon: declare holes in syscon register maps Maxime Coquelin
2014-10-08 11:12     ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54351C25.70604@st.com \
    --to=maxime.coquelin@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.