All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: <linux-mips@linux-mips.org>
Subject: Re: [PATCH v2] MIPS: Kconfig: Add choice symbol to select microMIPS or SmartMIPS
Date: Wed, 8 Oct 2014 14:28:47 +0100	[thread overview]
Message-ID: <54353C0F.6000704@imgtec.com> (raw)
In-Reply-To: <1405928774-20630-1-git-send-email-markos.chandras@imgtec.com>

On 07/21/2014 08:46 AM, Markos Chandras wrote:
> microMIPS and SmartMIPS can't be used together. This fixes the
> following build problem:
> 
> Warning: the 32-bit microMIPS architecture does not support the `smartmips'
> extension
> arch/mips/kernel/entry.S:90: Error: unrecognized opcode `mtlhx $24'
> [...]
> arch/mips/kernel/entry.S:109: Error: unrecognized opcode `mtlhx $24'
> 
> Link: https://dmz-portal.mips.com/bugz/show_bug.cgi?id=1021
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> ---
> Hi Ralf,
> 
> Here is v2 of that patch, making SmartMIPS and microMIPS a
> choice symbol as you requested in
> http://www.linux-mips.org/archives/linux-mips/2014-06/msg00011.html
> 
> However, I still feel this is wrong since these two ASEs are completely
> unrelated. The v1 of the patch is probably better in my opinion.
> If the user fails to find the 'smartmips' option due to having 'micromips'
> enabled, he/she can always search for the 'smartmips' symbol in the
> menuconfig and he/she will notice the dependency on !micromips.
> And if the user knows what he is doing he will probably never want to
> use 'smartmips' and 'micromips' together.
> ---
> 
Hi,

Any comments on that one?

-- 
markos

WARNING: multiple messages have this Message-ID (diff)
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: linux-mips@linux-mips.org
Subject: Re: [PATCH v2] MIPS: Kconfig: Add choice symbol to select microMIPS or SmartMIPS
Date: Wed, 8 Oct 2014 14:28:47 +0100	[thread overview]
Message-ID: <54353C0F.6000704@imgtec.com> (raw)
Message-ID: <20141008132847.J_UfMkQOsjjSnv1xPQYWa38vwO0GOxwbIDlao7qCk9Q@z> (raw)
In-Reply-To: <1405928774-20630-1-git-send-email-markos.chandras@imgtec.com>

On 07/21/2014 08:46 AM, Markos Chandras wrote:
> microMIPS and SmartMIPS can't be used together. This fixes the
> following build problem:
> 
> Warning: the 32-bit microMIPS architecture does not support the `smartmips'
> extension
> arch/mips/kernel/entry.S:90: Error: unrecognized opcode `mtlhx $24'
> [...]
> arch/mips/kernel/entry.S:109: Error: unrecognized opcode `mtlhx $24'
> 
> Link: https://dmz-portal.mips.com/bugz/show_bug.cgi?id=1021
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> ---
> Hi Ralf,
> 
> Here is v2 of that patch, making SmartMIPS and microMIPS a
> choice symbol as you requested in
> http://www.linux-mips.org/archives/linux-mips/2014-06/msg00011.html
> 
> However, I still feel this is wrong since these two ASEs are completely
> unrelated. The v1 of the patch is probably better in my opinion.
> If the user fails to find the 'smartmips' option due to having 'micromips'
> enabled, he/she can always search for the 'smartmips' symbol in the
> menuconfig and he/she will notice the dependency on !micromips.
> And if the user knows what he is doing he will probably never want to
> use 'smartmips' and 'micromips' together.
> ---
> 
Hi,

Any comments on that one?

-- 
markos

  reply	other threads:[~2014-10-08 13:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-03  8:46 [PATCH] MIPS: Kconfig: microMIPS and SmartMIPS are mutually exclusive Markos Chandras
2014-06-03  8:46 ` Markos Chandras
2014-06-03  9:34 ` Ralf Baechle
2014-06-03  9:34   ` Ralf Baechle
2014-06-03  9:45   ` Markos Chandras
2014-06-03  9:45     ` Markos Chandras
2014-06-03 11:18   ` Maciej W. Rozycki
2014-06-03 12:24     ` Ralf Baechle
2014-06-03 13:56       ` Maciej W. Rozycki
2014-07-21  7:46 ` [PATCH v2] MIPS: Kconfig: Add choice symbol to select microMIPS or SmartMIPS Markos Chandras
2014-07-21  7:46   ` Markos Chandras
2014-10-08 13:28   ` Markos Chandras [this message]
2014-10-08 13:28     ` Markos Chandras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54353C0F.6000704@imgtec.com \
    --to=markos.chandras@imgtec.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.