From: Roberto Medina <robertoxmed@gmail.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: gregkh@linuxfoundation.org, josh@joshtripplet.org,
ebru.akagunduz@gmail.com, aaro.koskinen@iki.fi,
ebiederm@xmission.com, devel@driverdev.osuosl.org,
linux-next@vger.kernel.org
Subject: Re: [PATCH v2] Staging: octeon: ethernet-tx: fixed coding style warnings, missing blank lines
Date: Wed, 08 Oct 2014 21:46:55 +0200 [thread overview]
Message-ID: <543594AF.4030507@gmail.com> (raw)
In-Reply-To: <543592FD.9010900@windriver.com>
On 10/08/2014 09:39 PM, Paul Gortmaker wrote:
> On 14-10-08 03:18 PM, Roberto Medina wrote:
>> From: Roberto Medina <robertoxmed@gmail.com>
>>
>> Fixed coding style warnings due to missing blank lines.
>> Dubious additions removed.
>>
>> Signed-off-by: Roberto Medina <robertoxmed@gmail.com>
>>
>> ---
>> @@ -550,6 +559,7 @@ int cvm_oct_xmit_pow(struct sk_buff *skb, struct net_device *dev)
>>
>> /* Get a work queue entry */
>> cvmx_wqe_t *work = cvmx_fpa_alloc(CVMX_FPA_WQE_POOL);
>> +
>> if (unlikely(work == NULL)) {
>
> This one is still bogus.
>
> P.
> --
>
Thank you very much for your feedback. I just want to let you know that
I didn't ignore that annotation from the last patch. I actually added
the white line because checkpatch shows a warning there.
WARNING: Missing a blank line after declarations
#553: FILE: drivers/staging/octeon/ethernet-tx.c:553:
+ cvmx_wqe_t *work = cvmx_fpa_alloc(CVMX_FPA_WQE_POOL);
+ if (unlikely(work == NULL)) {
I don't see why I shouldn't insert a line there.
Cheers,
Roberto Medina
next prev parent reply other threads:[~2014-10-08 19:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 19:18 [PATCH v2] Staging: octeon: ethernet-tx: fixed coding style warnings, missing blank lines Roberto Medina
2014-10-08 19:39 ` Paul Gortmaker
2014-10-08 19:46 ` Roberto Medina [this message]
2014-10-08 20:52 ` Aaro Koskinen
2014-10-08 20:57 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543594AF.4030507@gmail.com \
--to=robertoxmed@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=devel@driverdev.osuosl.org \
--cc=ebiederm@xmission.com \
--cc=ebru.akagunduz@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=josh@joshtripplet.org \
--cc=linux-next@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.