From: "Christian König" <deathsimple@vodafone.de>
To: "Michel Dänzer" <michel@daenzer.net>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/ttm: Don't skip fpfn check if lpfn is 0 in ttm_bo_mem_compat
Date: Thu, 09 Oct 2014 11:56:11 +0200 [thread overview]
Message-ID: <54365BBB.20709@vodafone.de> (raw)
In-Reply-To: <1412834583-24757-1-git-send-email-michel@daenzer.net>
Am 09.10.2014 um 08:03 schrieb Michel Dänzer:
> From: Michel Dänzer <michel.daenzer@amd.com>
>
> Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/ttm/ttm_bo.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index 407fa2d..d395b0b 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -1008,9 +1008,9 @@ static bool ttm_bo_mem_compat(struct ttm_placement *placement,
>
> for (i = 0; i < placement->num_placement; i++) {
> const struct ttm_place *heap = &placement->placement[i];
> - if (mem->mm_node && heap->lpfn != 0 &&
> + if (mem->mm_node &&
> (mem->start < heap->fpfn ||
> - mem->start + mem->num_pages > heap->lpfn))
> + (heap->lpfn != 0 && (mem->start + mem->num_pages) > heap->lpfn)))
> continue;
>
> *new_flags = heap->flags;
> @@ -1021,9 +1021,9 @@ static bool ttm_bo_mem_compat(struct ttm_placement *placement,
>
> for (i = 0; i < placement->num_busy_placement; i++) {
> const struct ttm_place *heap = &placement->busy_placement[i];
> - if (mem->mm_node && heap->lpfn != 0 &&
> + if (mem->mm_node &&
> (mem->start < heap->fpfn ||
> - mem->start + mem->num_pages > heap->lpfn))
> + (heap->lpfn != 0 && (mem->start + mem->num_pages) > heap->lpfn)))
> continue;
>
> *new_flags = heap->flags;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-10-09 9:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 6:03 [PATCH] drm/ttm: Don't skip fpfn check if lpfn is 0 in ttm_bo_mem_compat Michel Dänzer
2014-10-09 9:56 ` Christian König [this message]
2014-10-13 18:20 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54365BBB.20709@vodafone.de \
--to=deathsimple@vodafone.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=michel@daenzer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.