* [PATCH] drm/ttm: Don't skip fpfn check if lpfn is 0 in ttm_bo_mem_compat
@ 2014-10-09 6:03 Michel Dänzer
2014-10-09 9:56 ` Christian König
0 siblings, 1 reply; 3+ messages in thread
From: Michel Dänzer @ 2014-10-09 6:03 UTC (permalink / raw)
To: dri-devel
From: Michel Dänzer <michel.daenzer@amd.com>
Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
---
drivers/gpu/drm/ttm/ttm_bo.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index 407fa2d..d395b0b 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -1008,9 +1008,9 @@ static bool ttm_bo_mem_compat(struct ttm_placement *placement,
for (i = 0; i < placement->num_placement; i++) {
const struct ttm_place *heap = &placement->placement[i];
- if (mem->mm_node && heap->lpfn != 0 &&
+ if (mem->mm_node &&
(mem->start < heap->fpfn ||
- mem->start + mem->num_pages > heap->lpfn))
+ (heap->lpfn != 0 && (mem->start + mem->num_pages) > heap->lpfn)))
continue;
*new_flags = heap->flags;
@@ -1021,9 +1021,9 @@ static bool ttm_bo_mem_compat(struct ttm_placement *placement,
for (i = 0; i < placement->num_busy_placement; i++) {
const struct ttm_place *heap = &placement->busy_placement[i];
- if (mem->mm_node && heap->lpfn != 0 &&
+ if (mem->mm_node &&
(mem->start < heap->fpfn ||
- mem->start + mem->num_pages > heap->lpfn))
+ (heap->lpfn != 0 && (mem->start + mem->num_pages) > heap->lpfn)))
continue;
*new_flags = heap->flags;
--
2.1.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/ttm: Don't skip fpfn check if lpfn is 0 in ttm_bo_mem_compat
2014-10-09 6:03 [PATCH] drm/ttm: Don't skip fpfn check if lpfn is 0 in ttm_bo_mem_compat Michel Dänzer
@ 2014-10-09 9:56 ` Christian König
2014-10-13 18:20 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Christian König @ 2014-10-09 9:56 UTC (permalink / raw)
To: Michel Dänzer, dri-devel
Am 09.10.2014 um 08:03 schrieb Michel Dänzer:
> From: Michel Dänzer <michel.daenzer@amd.com>
>
> Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/ttm/ttm_bo.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index 407fa2d..d395b0b 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -1008,9 +1008,9 @@ static bool ttm_bo_mem_compat(struct ttm_placement *placement,
>
> for (i = 0; i < placement->num_placement; i++) {
> const struct ttm_place *heap = &placement->placement[i];
> - if (mem->mm_node && heap->lpfn != 0 &&
> + if (mem->mm_node &&
> (mem->start < heap->fpfn ||
> - mem->start + mem->num_pages > heap->lpfn))
> + (heap->lpfn != 0 && (mem->start + mem->num_pages) > heap->lpfn)))
> continue;
>
> *new_flags = heap->flags;
> @@ -1021,9 +1021,9 @@ static bool ttm_bo_mem_compat(struct ttm_placement *placement,
>
> for (i = 0; i < placement->num_busy_placement; i++) {
> const struct ttm_place *heap = &placement->busy_placement[i];
> - if (mem->mm_node && heap->lpfn != 0 &&
> + if (mem->mm_node &&
> (mem->start < heap->fpfn ||
> - mem->start + mem->num_pages > heap->lpfn))
> + (heap->lpfn != 0 && (mem->start + mem->num_pages) > heap->lpfn)))
> continue;
>
> *new_flags = heap->flags;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/ttm: Don't skip fpfn check if lpfn is 0 in ttm_bo_mem_compat
2014-10-09 9:56 ` Christian König
@ 2014-10-13 18:20 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2014-10-13 18:20 UTC (permalink / raw)
To: Christian König, Thomas Hellstrom
Cc: Michel Dänzer, Maling list - DRI developers
On Thu, Oct 9, 2014 at 5:56 AM, Christian König <deathsimple@vodafone.de> wrote:
> Am 09.10.2014 um 08:03 schrieb Michel Dänzer:
>>
>> From: Michel Dänzer <michel.daenzer@amd.com>
>>
>> Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
>
Thomas, do you want to pull this through the ttm tree or can I take it
through radeon?
Alex
>> ---
>> drivers/gpu/drm/ttm/ttm_bo.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
>> index 407fa2d..d395b0b 100644
>> --- a/drivers/gpu/drm/ttm/ttm_bo.c
>> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
>> @@ -1008,9 +1008,9 @@ static bool ttm_bo_mem_compat(struct ttm_placement
>> *placement,
>> for (i = 0; i < placement->num_placement; i++) {
>> const struct ttm_place *heap = &placement->placement[i];
>> - if (mem->mm_node && heap->lpfn != 0 &&
>> + if (mem->mm_node &&
>> (mem->start < heap->fpfn ||
>> - mem->start + mem->num_pages > heap->lpfn))
>> + (heap->lpfn != 0 && (mem->start + mem->num_pages) >
>> heap->lpfn)))
>> continue;
>> *new_flags = heap->flags;
>> @@ -1021,9 +1021,9 @@ static bool ttm_bo_mem_compat(struct ttm_placement
>> *placement,
>> for (i = 0; i < placement->num_busy_placement; i++) {
>> const struct ttm_place *heap =
>> &placement->busy_placement[i];
>> - if (mem->mm_node && heap->lpfn != 0 &&
>> + if (mem->mm_node &&
>> (mem->start < heap->fpfn ||
>> - mem->start + mem->num_pages > heap->lpfn))
>> + (heap->lpfn != 0 && (mem->start + mem->num_pages) >
>> heap->lpfn)))
>> continue;
>> *new_flags = heap->flags;
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-13 18:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-09 6:03 [PATCH] drm/ttm: Don't skip fpfn check if lpfn is 0 in ttm_bo_mem_compat Michel Dänzer
2014-10-09 9:56 ` Christian König
2014-10-13 18:20 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.