From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/3] ARM: shmobile: koelsch: enable HS-USB
Date: Thu, 09 Oct 2014 12:51:02 +0000 [thread overview]
Message-ID: <543684B6.6060708@cogentembedded.com> (raw)
In-Reply-To: <5435DFD6.3050609@renesas.com>
Hello.
On 10/09/2014 05:07 AM, Yoshihiro Shimoda wrote:
>> Enable HS-USB device for the Koelsch board, defining the GPIO that the driver
>> should check when probing (which is the ID output from MAX3355 OTG chip).
>> Note that there will be pinctrl-related error messages if both internal PCI
>> and HS-USB drivers are enabled but they should be just ignored.
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> [Sergei: added pin function/group and prop, moved device node, fixed summary,
>> added changelog]
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> ---
>> Changes in version 3:
>> - added pinctrl-related properties;
>> - moved the HS-USB node to precede the USB PHY node;
>> - uppercased "arm" in the summary;
>> - added changelog.
>> arch/arm/boot/dts/r8a7791-koelsch.dts | 7 +++++++
>> 1 file changed, 7 insertions(+)
>> Index: renesas/arch/arm/boot/dts/r8a7791-koelsch.dts
>> =================================>> --- renesas.orig/arch/arm/boot/dts/r8a7791-koelsch.dts
>> +++ renesas/arch/arm/boot/dts/r8a7791-koelsch.dts
>> @@ -464,6 +464,13 @@
>> pinctrl-names = "default";
>> };
>>
>> +&hsusb {
>> + status = "okay";
>> + pinctrl-0 = <&usb0_pins>;
>> + pinctrl-names = "default";
> Perhaps I don't understand the pinctrl world yet, but I have a question.
> In r8a7791, the USB0_PWEN is GP7_23 and the USB0_OVC is GP7_24. And,
> the "usb0_pins" is related to these USB0 pins. But, as you know,
> the koelsch has a OTG ID pin and it connects to GP5_31 via MAX3355 chip.
The GPIO pins are not requested via pinctrl.
> So, would you tell me why koelsch needs the pinctrl?
Because at least USB0_OVC/VBUS is used by HS-USB. I decided not to modify
the R8A7791 PFC driver in order to create a group consisting of that signal
alone (like on R8A7790), because we don't need to read GP7_23 on these boards,
unlike Lager.
> Best regards,
> Yoshihiro Shimoda
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/3] ARM: shmobile: koelsch: enable HS-USB
Date: Thu, 09 Oct 2014 16:51:02 +0400 [thread overview]
Message-ID: <543684B6.6060708@cogentembedded.com> (raw)
In-Reply-To: <5435DFD6.3050609@renesas.com>
Hello.
On 10/09/2014 05:07 AM, Yoshihiro Shimoda wrote:
>> Enable HS-USB device for the Koelsch board, defining the GPIO that the driver
>> should check when probing (which is the ID output from MAX3355 OTG chip).
>> Note that there will be pinctrl-related error messages if both internal PCI
>> and HS-USB drivers are enabled but they should be just ignored.
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> [Sergei: added pin function/group and prop, moved device node, fixed summary,
>> added changelog]
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> ---
>> Changes in version 3:
>> - added pinctrl-related properties;
>> - moved the HS-USB node to precede the USB PHY node;
>> - uppercased "arm" in the summary;
>> - added changelog.
>> arch/arm/boot/dts/r8a7791-koelsch.dts | 7 +++++++
>> 1 file changed, 7 insertions(+)
>> Index: renesas/arch/arm/boot/dts/r8a7791-koelsch.dts
>> ===================================================================
>> --- renesas.orig/arch/arm/boot/dts/r8a7791-koelsch.dts
>> +++ renesas/arch/arm/boot/dts/r8a7791-koelsch.dts
>> @@ -464,6 +464,13 @@
>> pinctrl-names = "default";
>> };
>>
>> +&hsusb {
>> + status = "okay";
>> + pinctrl-0 = <&usb0_pins>;
>> + pinctrl-names = "default";
> Perhaps I don't understand the pinctrl world yet, but I have a question.
> In r8a7791, the USB0_PWEN is GP7_23 and the USB0_OVC is GP7_24. And,
> the "usb0_pins" is related to these USB0 pins. But, as you know,
> the koelsch has a OTG ID pin and it connects to GP5_31 via MAX3355 chip.
The GPIO pins are not requested via pinctrl.
> So, would you tell me why koelsch needs the pinctrl?
Because at least USB0_OVC/VBUS is used by HS-USB. I decided not to modify
the R8A7791 PFC driver in order to create a group consisting of that signal
alone (like on R8A7790), because we don't need to read GP7_23 on these boards,
unlike Lager.
> Best regards,
> Yoshihiro Shimoda
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
"horms@verge.net.au" <horms@verge.net.au>,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc: "magnus.damm@gmail.com" <magnus.damm@gmail.com>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] ARM: shmobile: koelsch: enable HS-USB
Date: Thu, 09 Oct 2014 16:51:02 +0400 [thread overview]
Message-ID: <543684B6.6060708@cogentembedded.com> (raw)
In-Reply-To: <5435DFD6.3050609@renesas.com>
Hello.
On 10/09/2014 05:07 AM, Yoshihiro Shimoda wrote:
>> Enable HS-USB device for the Koelsch board, defining the GPIO that the driver
>> should check when probing (which is the ID output from MAX3355 OTG chip).
>> Note that there will be pinctrl-related error messages if both internal PCI
>> and HS-USB drivers are enabled but they should be just ignored.
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> [Sergei: added pin function/group and prop, moved device node, fixed summary,
>> added changelog]
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> ---
>> Changes in version 3:
>> - added pinctrl-related properties;
>> - moved the HS-USB node to precede the USB PHY node;
>> - uppercased "arm" in the summary;
>> - added changelog.
>> arch/arm/boot/dts/r8a7791-koelsch.dts | 7 +++++++
>> 1 file changed, 7 insertions(+)
>> Index: renesas/arch/arm/boot/dts/r8a7791-koelsch.dts
>> ===================================================================
>> --- renesas.orig/arch/arm/boot/dts/r8a7791-koelsch.dts
>> +++ renesas/arch/arm/boot/dts/r8a7791-koelsch.dts
>> @@ -464,6 +464,13 @@
>> pinctrl-names = "default";
>> };
>>
>> +&hsusb {
>> + status = "okay";
>> + pinctrl-0 = <&usb0_pins>;
>> + pinctrl-names = "default";
> Perhaps I don't understand the pinctrl world yet, but I have a question.
> In r8a7791, the USB0_PWEN is GP7_23 and the USB0_OVC is GP7_24. And,
> the "usb0_pins" is related to these USB0 pins. But, as you know,
> the koelsch has a OTG ID pin and it connects to GP5_31 via MAX3355 chip.
The GPIO pins are not requested via pinctrl.
> So, would you tell me why koelsch needs the pinctrl?
Because at least USB0_OVC/VBUS is used by HS-USB. I decided not to modify
the R8A7791 PFC driver in order to create a group consisting of that signal
alone (like on R8A7790), because we don't need to read GP7_23 on these boards,
unlike Lager.
> Best regards,
> Yoshihiro Shimoda
WBR, Sergei
next prev parent reply other threads:[~2014-10-09 12:51 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 17:59 [PATCH v3 1/3] Add HS-USB device tree support for R8A7791/Koelsch/Henninger board Sergei Shtylyov
2014-10-08 17:59 ` Sergei Shtylyov
2014-10-08 17:59 ` Sergei Shtylyov
2014-10-08 18:00 ` [PATCH v3 1/3] ARM: shmobile: r8a7791: add HS-USB device node Sergei Shtylyov
2014-10-08 18:00 ` Sergei Shtylyov
2014-10-08 18:00 ` Sergei Shtylyov
2014-10-08 18:02 ` [PATCH v3 2/3] ARM: shmobile: koelsch: enable HS-USB Sergei Shtylyov
2014-10-08 18:02 ` Sergei Shtylyov
2014-10-08 18:02 ` Sergei Shtylyov
2014-10-08 18:05 ` Felipe Balbi
2014-10-08 18:05 ` Felipe Balbi
2014-10-08 18:05 ` Felipe Balbi
2014-10-08 18:07 ` Sergei Shtylyov
2014-10-08 18:07 ` Sergei Shtylyov
2014-10-08 18:07 ` Sergei Shtylyov
2014-10-08 18:08 ` Felipe Balbi
2014-10-08 18:08 ` Felipe Balbi
2014-10-08 18:08 ` Felipe Balbi
2014-10-08 18:11 ` Sergei Shtylyov
2014-10-08 18:11 ` Sergei Shtylyov
2014-10-08 18:11 ` Sergei Shtylyov
2014-10-08 18:22 ` Felipe Balbi
2014-10-08 18:22 ` Felipe Balbi
2014-10-08 18:22 ` Felipe Balbi
2014-10-09 1:07 ` Yoshihiro Shimoda
2014-10-09 1:07 ` Yoshihiro Shimoda
2014-10-09 1:07 ` Yoshihiro Shimoda
2014-10-09 12:51 ` Sergei Shtylyov [this message]
2014-10-09 12:51 ` Sergei Shtylyov
2014-10-09 12:51 ` Sergei Shtylyov
2014-10-10 0:17 ` Yoshihiro Shimoda
2014-10-10 0:17 ` Yoshihiro Shimoda
2014-10-10 0:17 ` Yoshihiro Shimoda
2014-10-08 18:04 ` [PATCH v3 3/3] ARM: shmobile: henninger: " Sergei Shtylyov
2014-10-08 18:04 ` Sergei Shtylyov
2014-10-08 18:04 ` Sergei Shtylyov
2014-10-08 18:05 ` [PATCH v3 1/3] Add HS-USB device tree support for R8A7791/Koelsch/Henninger board Sergei Shtylyov
2014-10-08 18:05 ` Sergei Shtylyov
2014-10-08 18:05 ` Sergei Shtylyov
2014-10-24 5:23 ` Yoshihiro Shimoda
2014-10-24 5:23 ` Yoshihiro Shimoda
2014-10-24 5:23 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543684B6.6060708@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.