From: "Andreas Färber" <afaerber@suse.de>
To: Luiz Capitulino <lcapitulino@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
peter.maydell@linaro.org
Cc: qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com
Subject: Re: [Qemu-devel] [PATCH 1/1] hmp: Remove "info pcmcia"
Date: Thu, 09 Oct 2014 16:41:28 +0200 [thread overview]
Message-ID: <54369E98.901@suse.de> (raw)
In-Reply-To: <20141009094751.6e04b4b9@redhat.com>
Am 09.10.2014 um 15:47 schrieb Luiz Capitulino:
> On Wed, 01 Oct 2014 10:54:44 +0200
> Markus Armbruster <armbru@redhat.com> wrote:
>
>> Ping?
>>
>> Markus Armbruster <armbru@redhat.com> writes:
>>
>>> This command lists PCMCIA sockets and cards. Only a few ARM boards
>>> have sockets (akita, borzoi, connex, mainstone, spitz, terrier, tosa,
>>> verdex, z2), the only card is the DSCM-1xxxx Hitachi Microdrive (qdev
>>> "microdrive"), and it is only inserted during machine init, if ever.
>>> So this command doesn't really tell anybody anything new so far.
>>>
>>> Moreover, pcmcia_socket_unregister() has a use-after-free bug, flagged
>>> by Coverity. Has never been used, because there has never been code
>>> to eject a PCMCIA card.
>>>
>>> Not worth fixing & converting to QMP. Remove it.
>
> Sorry for the long delay on this one. But this patch is more about PCMCIA
> support in QEMU than HMP, so I can provide my ACK, but I don't think this
> is HMP material.
>
> Acked-by: Luiz Capitulino <lcapitulino@redhat.com>
As the probably last one to have touched the ugly PCMCIA code,
Acked-by: Andreas Färber <afaerber@suse.de>
Maybe take it through the arm queue due to affected machines, Peter?
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-10-09 14:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 16:40 [Qemu-devel] [PATCH 1/1] hmp: Remove "info pcmcia" Markus Armbruster
2014-10-01 8:54 ` Markus Armbruster
2014-10-09 13:47 ` Luiz Capitulino
2014-10-09 14:41 ` Andreas Färber [this message]
2014-10-09 14:58 ` Peter Maydell
2014-10-09 15:16 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54369E98.901@suse.de \
--to=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.