Re: [Qemu-devel] [PATCH 1/1] hmp: Remove "info pcmcia"

[Markus Armbruster <armbru@redhat.com>]

Peter Maydell <peter.maydell@linaro.org> writes:

> On 9 October 2014 15:41, Andreas Färber <afaerber@suse.de> wrote:
>> Am 09.10.2014 um 15:47 schrieb Luiz Capitulino:
>>> On Wed, 01 Oct 2014 10:54:44 +0200
>>> Markus Armbruster <armbru@redhat.com> wrote:
>>>
>>>> Ping?
>>>>
>>>> Markus Armbruster <armbru@redhat.com> writes:
>>>>
>>>>> This command lists PCMCIA sockets and cards.  Only a few ARM boards
>>>>> have sockets (akita, borzoi, connex, mainstone, spitz, terrier, tosa,
>>>>> verdex, z2), the only card is the DSCM-1xxxx Hitachi Microdrive (qdev
>>>>> "microdrive"), and it is only inserted during machine init, if ever.
>>>>> So this command doesn't really tell anybody anything new so far.
>>>>>
>>>>> Moreover, pcmcia_socket_unregister() has a use-after-free bug, flagged
>>>>> by Coverity.  Has never been used, because there has never been code
>>>>> to eject a PCMCIA card.
>>>>>
>>>>> Not worth fixing & converting to QMP.  Remove it.
>>>
>>> Sorry for the long delay on this one. But this patch is more about PCMCIA
>>> support in QEMU than HMP, so I can provide my ACK, but I don't think this
>>> is HMP material.
>>>
>>> Acked-by: Luiz Capitulino <lcapitulino@redhat.com>
>>
>> As the probably last one to have touched the ugly PCMCIA code,
>>
>> Acked-by: Andreas Färber <afaerber@suse.de>
>>
>> Maybe take it through the arm queue due to affected machines, Peter?
>
> I don't particularly care -- the machines in question are near-dead
> so there's not much chance of conflicts. I can take it if that's
> easiest for everybody I guess?

Yes, please!