From: Eric Blake <eblake@redhat.com>
To: Chen Gang <gang.chen.5i5j@gmail.com>,
peter.maydell@linaro.org, "rth@twiddle.net" <rth@twiddle.net>
Cc: qemu-trivial@nongnu.org, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] disas/libvixl/a64/instructions-a64.h: Remove useless varialbe to avoid building break with '-Werror'
Date: Thu, 09 Oct 2014 08:54:34 -0600 [thread overview]
Message-ID: <5436A1AA.8020004@redhat.com> (raw)
In-Reply-To: <54369514.5000004@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 501 bytes --]
On 10/09/2014 08:00 AM, Chen Gang wrote:
That's a very long subject line. Try to keep subjects around 60
characters or so ('git shortlog -30' can give you an idea of reasonable
subjects). Also, s/varialbe/variable/ in the subject.
> The related variables are useless, need be removed, or can not pass
> microblaze building, after fix it, can build microblaze, successfully.
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: Chen Gang <gang.chen.5i5j@gmail.com>,
peter.maydell@linaro.org, "rth@twiddle.net" <rth@twiddle.net>
Cc: qemu-trivial@nongnu.org, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] disas/libvixl/a64/instructions-a64.h: Remove useless varialbe to avoid building break with '-Werror'
Date: Thu, 09 Oct 2014 08:54:34 -0600 [thread overview]
Message-ID: <5436A1AA.8020004@redhat.com> (raw)
In-Reply-To: <54369514.5000004@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 501 bytes --]
On 10/09/2014 08:00 AM, Chen Gang wrote:
That's a very long subject line. Try to keep subjects around 60
characters or so ('git shortlog -30' can give you an idea of reasonable
subjects). Also, s/varialbe/variable/ in the subject.
> The related variables are useless, need be removed, or can not pass
> microblaze building, after fix it, can build microblaze, successfully.
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-10-09 14:55 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 14:00 [Qemu-trivial] [PATCH] disas/libvixl/a64/instructions-a64.h: Remove useless varialbe to avoid building break with '-Werror' Chen Gang
2014-10-09 14:00 ` [Qemu-devel] " Chen Gang
2014-10-09 14:34 ` [Qemu-trivial] " Peter Maydell
2014-10-09 14:34 ` [Qemu-devel] " Peter Maydell
2014-10-10 1:54 ` [Qemu-trivial] " Chen Gang
2014-10-10 1:54 ` [Qemu-devel] " Chen Gang
2014-10-10 7:37 ` [Qemu-trivial] " Peter Maydell
2014-10-10 7:37 ` [Qemu-devel] " Peter Maydell
2014-10-10 8:53 ` [Qemu-trivial] " Chen Gang
2014-10-10 8:53 ` [Qemu-devel] " Chen Gang
2014-10-10 9:03 ` [Qemu-trivial] " Chen Gang
2014-10-10 9:03 ` [Qemu-devel] " Chen Gang
2014-10-09 14:54 ` Eric Blake [this message]
2014-10-09 14:54 ` Eric Blake
2014-10-10 1:28 ` [Qemu-trivial] " Chen Gang
2014-10-10 1:28 ` Chen Gang
2014-10-21 15:50 ` [Qemu-trivial] " Peter Maydell
2014-10-21 15:50 ` [Qemu-devel] " Peter Maydell
2014-10-23 6:49 ` [Qemu-trivial] " Michael Tokarev
2014-10-23 6:49 ` [Qemu-devel] " Michael Tokarev
2014-10-23 7:14 ` Peter Maydell
2014-10-23 7:14 ` [Qemu-devel] " Peter Maydell
2014-10-23 8:09 ` Michael Tokarev
2014-10-23 8:09 ` [Qemu-devel] " Michael Tokarev
2014-10-23 9:02 ` Peter Maydell
2014-10-23 9:02 ` [Qemu-devel] " Peter Maydell
2014-10-23 10:09 ` Peter Maydell
2014-10-23 10:09 ` [Qemu-devel] " Peter Maydell
2014-10-23 10:27 ` Michael Tokarev
2014-10-23 10:27 ` [Qemu-devel] " Michael Tokarev
2014-10-23 11:05 ` Peter Maydell
2014-10-23 11:05 ` [Qemu-devel] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5436A1AA.8020004@redhat.com \
--to=eblake@redhat.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.