From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, olaf@aepfle.de, xen-devel@lists.xen.org
Cc: wei.liu2@citrix.com, ian.campbell@citrix.com,
stefano.stabellini@eu.citrix.com, tim@xen.org,
ian.jackson@eu.citrix.com, samuel.thibault@ens-lyon.org,
keir@xen.org, dave.scott@eu.citrix.com
Subject: Re: [PATCH v4] Separate runtime debug output from debug symbols
Date: Thu, 9 Oct 2014 15:58:10 +0100 [thread overview]
Message-ID: <5436A282.6060604@citrix.com> (raw)
In-Reply-To: <5436A49B02000078000BEF1F@mail.emea.novell.com>
On 09/10/14 15:07, Jan Beulich wrote:
>>>> Olaf Hering <olaf@aepfle.de> 10/09/14 9:59 AM >>>
>> --- a/Config.mk
>> +++ b/Config.mk
>> @@ -18,7 +18,7 @@ or = $(if $(strip $(1)),$(1),$(if $(strip $(2)),$(2),$(if $(strip $(3)),$(
> >
>> # A debug build of Xen and tools?
>> debug ?= y
>> -debug_symbols ?= $(debug)
>> +debug_symbols ?= y
>
> Even if this may be what Ian asked you to do (albeit it's not entirely clear
> to me), I don't think I'm in agreement with this change being done: I
> personally expect to be able to disable debug_symbols as a side effect
> of disabling debug.
>
> Jan
Agreed, which is why I (as the author of the debug_symbols change) left
it that way.
FWIW, I believe that v3 of this patch is correct. I did not follow the
reasoning for the objection.
Anyone building for themselves will (should) be doing debug builds.
Anyone packaging RPMs will want debug_symbols enabled to generate
-debuginfo RPMs. I presume .debs have a similar principle.
~Andrew
prev parent reply other threads:[~2014-10-09 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 7:58 [PATCH v4] Separate runtime debug output from debug symbols Olaf Hering
2014-10-09 14:07 ` Jan Beulich
2014-10-09 14:58 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5436A282.6060604@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=dave.scott@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=olaf@aepfle.de \
--cc=samuel.thibault@ens-lyon.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.