From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: John Crispin <blogic@openwrt.org>, Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH 05/10] MIPS: ralink: add illegal access driver
Date: Thu, 09 Oct 2014 20:19:29 +0400 [thread overview]
Message-ID: <5436B591.3000008@cogentembedded.com> (raw)
In-Reply-To: <1412812385-64820-6-git-send-email-blogic@openwrt.org>
Hello.
On 10/09/2014 03:53 AM, John Crispin wrote:
> These SoCs have a special irq that fires upon an illegal memmory access.
> Signed-off-by: John Crispin <blogic@openwrt.org>
> ---
> arch/mips/ralink/Makefile | 2 +
> arch/mips/ralink/ill_acc.c | 87 ++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 89 insertions(+)
> create mode 100644 arch/mips/ralink/ill_acc.c
[...]
> diff --git a/arch/mips/ralink/ill_acc.c b/arch/mips/ralink/ill_acc.c
> new file mode 100644
> index 0000000..e20b02e
> --- /dev/null
> +++ b/arch/mips/ralink/ill_acc.c
> @@ -0,0 +1,87 @@
[...]
> +static const char * const ill_acc_ids[] = {
> + "cpu", "dma", "ppe", "pdma rx", "pdma tx", "pci/e", "wmac", "usb",
> +};
> +
> +static irqreturn_t ill_acc_irq_handler(int irq, void *_priv)
> +{
> + struct device *dev = (struct device *) _priv;
> + u32 addr = rt_memc_r32(REG_ILL_ACC_ADDR);
> + u32 type = rt_memc_r32(REG_ILL_ACC_TYPE);
> +
> + dev_err(dev, "illegal %s access from %s - addr:0x%08x offset:%d len:%d\n",
> + (type & ILL_ACC_WRITE) ? ("write") : ("read"),
Hm, why these () around string literals? Not that the ones before ? are
needed too...
WBR, Sergei
next prev parent reply other threads:[~2014-10-09 16:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 23:52 [PATCH 00/10] MIPS: ralink: various minor fixes and features John Crispin
2014-10-08 23:52 ` [PATCH 01/10] MIPS: ralink: add verbose pmu info John Crispin
2014-10-08 23:52 ` [PATCH 02/10] MIPS: ralink: add a helper for reading the ECO version John Crispin
2014-10-08 23:52 ` [PATCH 03/10] MIPS: ralink: add rt_sysc_m32 helper John Crispin
2014-10-08 23:52 ` [PATCH 04/10] MIPS: ralink: add a bootrom dumper module John Crispin
2014-10-08 23:53 ` [PATCH 05/10] MIPS: ralink: add illegal access driver John Crispin
2014-10-09 16:19 ` Sergei Shtylyov [this message]
2014-10-08 23:53 ` [PATCH 06/10] MIPS: ralink: allow manual memory override John Crispin
2014-10-08 23:53 ` [PATCH 07/10] MIPS: ralink: add missing clk_set_rate() to clk.c John Crispin
2014-10-08 23:53 ` [PATCH 08/10] MIPS: ralink: add rt2880 wmac clock John Crispin
2014-10-09 16:20 ` Sergei Shtylyov
2014-10-09 16:42 ` John Crispin
2014-10-08 23:53 ` [PATCH 09/10] MIPS: ralink: add rt3883 " John Crispin
2014-10-08 23:53 ` [PATCH 10/10] MIPS: ralink: copy the commandline from the devicetree John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5436B591.3000008@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=blogic@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.