From: John Crispin <blogic@openwrt.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH 08/10] MIPS: ralink: add rt2880 wmac clock
Date: Thu, 09 Oct 2014 18:42:18 +0200 [thread overview]
Message-ID: <5436BAEA.4020702@openwrt.org> (raw)
In-Reply-To: <5436B5E1.4060201@cogentembedded.com>
On 09/10/2014 18:20, Sergei Shtylyov wrote:
> On 10/09/2014 03:53 AM, John Crispin wrote:
>
>> Register the wireleass mac clock on rt2880. This is required by the
>> wifi driver.
>
>> Signed-off-by: John Crispin <blogic@openwrt.org>
>> ---
>> arch/mips/ralink/rt288x.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>> diff --git a/arch/mips/ralink/rt288x.c b/arch/mips/ralink/rt288x.c
>> index f87de1a..90e8934 100644
>> --- a/arch/mips/ralink/rt288x.c
>> +++ b/arch/mips/ralink/rt288x.c
>> @@ -76,7 +76,7 @@ struct ralink_pinmux rt_gpio_pinmux = {
>>
>> void __init ralink_clk_init(void)
>> {
>> - unsigned long cpu_rate;
>> + unsigned long cpu_rate, wmac_rate = 40000000;
>
> Why you need this variable at all?
in theory there can be a 20mhz clock. the code follows the same pattern
as the other SoCs. due to lack of datasheet do however not know how to
read the clock register. if you see this as a problem we can change it.
John
next prev parent reply other threads:[~2014-10-09 16:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 23:52 [PATCH 00/10] MIPS: ralink: various minor fixes and features John Crispin
2014-10-08 23:52 ` [PATCH 01/10] MIPS: ralink: add verbose pmu info John Crispin
2014-10-08 23:52 ` [PATCH 02/10] MIPS: ralink: add a helper for reading the ECO version John Crispin
2014-10-08 23:52 ` [PATCH 03/10] MIPS: ralink: add rt_sysc_m32 helper John Crispin
2014-10-08 23:52 ` [PATCH 04/10] MIPS: ralink: add a bootrom dumper module John Crispin
2014-10-08 23:53 ` [PATCH 05/10] MIPS: ralink: add illegal access driver John Crispin
2014-10-09 16:19 ` Sergei Shtylyov
2014-10-08 23:53 ` [PATCH 06/10] MIPS: ralink: allow manual memory override John Crispin
2014-10-08 23:53 ` [PATCH 07/10] MIPS: ralink: add missing clk_set_rate() to clk.c John Crispin
2014-10-08 23:53 ` [PATCH 08/10] MIPS: ralink: add rt2880 wmac clock John Crispin
2014-10-09 16:20 ` Sergei Shtylyov
2014-10-09 16:42 ` John Crispin [this message]
2014-10-08 23:53 ` [PATCH 09/10] MIPS: ralink: add rt3883 " John Crispin
2014-10-08 23:53 ` [PATCH 10/10] MIPS: ralink: copy the commandline from the devicetree John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5436BAEA.4020702@openwrt.org \
--to=blogic@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.