All of lore.kernel.org
 help / color / mirror / Atom feed
From: Corey Minyard <cminyard@mvista.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	minyard@acm.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] qemu-sockets: Add error to non-blocking connect handler
Date: Thu, 09 Oct 2014 12:48:52 -0500	[thread overview]
Message-ID: <5436CA84.5070804@mvista.com> (raw)
In-Reply-To: <54365E6E.8030001@redhat.com>

On 10/09/2014 05:07 AM, Paolo Bonzini wrote:
>> +        error_setg_errno(&err, errno, "Error connecting to socket");
>> >          closesocket(s->fd);
>> >          s->fd = rc;
>> >      }
> This is missing above this hunk:
>
> diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
> index e6a9644..a76bb3c 100644
> --- a/util/qemu-sockets.c
> +++ b/util/qemu-sockets.c
> @@ -245,6 +245,7 @@ static void wait_for_connect(void *opaque)
>      /* update rc to contain error */
>      if (!rc && val) {
>          rc = -1;
> +        errno = val;
>      }
>
>      /* connect error */
>

Yes, it is.  I see that everything went in, thanks for your work on this.

Now on to IPMI...

-corey

  reply	other threads:[~2014-10-09 17:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-08 12:11 [Qemu-devel] [PATCH v2 0/3] Clean up non-blocking error reporting minyard
2014-10-08 12:11 ` [Qemu-devel] [PATCH 1/3] qemu-error: Add error_vreport() minyard
2014-10-08 14:38   ` Eric Blake
2014-10-08 12:11 ` [Qemu-devel] [PATCH 2/3] qemu-char: Fix reconnect socket error reporting minyard
2014-10-08 12:11 ` [Qemu-devel] [PATCH 3/3] qemu-sockets: Add error to non-blocking connect handler minyard
2014-10-09 10:07   ` Paolo Bonzini
2014-10-09 17:48     ` Corey Minyard [this message]
2014-10-08 12:56 ` [Qemu-devel] [PATCH v2 0/3] Clean up non-blocking error reporting Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5436CA84.5070804@mvista.com \
    --to=cminyard@mvista.com \
    --cc=minyard@acm.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.