From: Peter Hurley <peter@hurleysoftware.com>
To: Jingchang Lu <jingchang.lu@freescale.com>,
Stephen Warren <swarren@wwwdotorg.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "arnd@arndb.de" <arnd@arndb.de>, Joseph Lo <josephl@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] serial: of-serial: fix up PM ops on no_console_suspend
Date: Fri, 10 Oct 2014 06:25:26 -0400 [thread overview]
Message-ID: <5437B416.2080606@hurleysoftware.com> (raw)
In-Reply-To: <01583b7f252b4f81a5655009f6f73aba@BL2PR03MB467.namprd03.prod.outlook.com>
On 10/10/2014 02:16 AM, Jingchang Lu wrote:
>> From: Stephen Warren [mailto:swarren@wwwdotorg.org]
>> On 10/09/2014 02:10 AM, Jingchang Lu wrote:
>>> Mandatorily disabling the uart clock will cause register access hung
>>> on "no_console_suspend". This patch add condition check on it and only
>>> disable the clock with console_suspend_enabled true.
>>
>> It would be useful if the email/patch subject line said "V2", and there
>> was a changelog below.
> This is not a v2, patch "serial: of-serial: add PM suspend/resume support
> (commit 2dea53bf57783f243c892e99c10c6921e956aa7e)" has been merged into
> linux-next tree, this is a fixup on that PM ops.
Then please say so in the commit log. Something like,
Fix commit 2dea53bf57783f243c892e99c10c6921e956aa7e,
"serial: of-serial: add PM suspend/resume support", which
disables the uart clock on suspend, but also causes a hardware
hang on register access if no_console_suspend command line option
is used.
Regards,
Peter Hurley
WARNING: multiple messages have this Message-ID (diff)
From: peter@hurleysoftware.com (Peter Hurley)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial: of-serial: fix up PM ops on no_console_suspend
Date: Fri, 10 Oct 2014 06:25:26 -0400 [thread overview]
Message-ID: <5437B416.2080606@hurleysoftware.com> (raw)
In-Reply-To: <01583b7f252b4f81a5655009f6f73aba@BL2PR03MB467.namprd03.prod.outlook.com>
On 10/10/2014 02:16 AM, Jingchang Lu wrote:
>> From: Stephen Warren [mailto:swarren at wwwdotorg.org]
>> On 10/09/2014 02:10 AM, Jingchang Lu wrote:
>>> Mandatorily disabling the uart clock will cause register access hung
>>> on "no_console_suspend". This patch add condition check on it and only
>>> disable the clock with console_suspend_enabled true.
>>
>> It would be useful if the email/patch subject line said "V2", and there
>> was a changelog below.
> This is not a v2, patch "serial: of-serial: add PM suspend/resume support
> (commit 2dea53bf57783f243c892e99c10c6921e956aa7e)" has been merged into
> linux-next tree, this is a fixup on that PM ops.
Then please say so in the commit log. Something like,
Fix commit 2dea53bf57783f243c892e99c10c6921e956aa7e,
"serial: of-serial: add PM suspend/resume support", which
disables the uart clock on suspend, but also causes a hardware
hang on register access if no_console_suspend command line option
is used.
Regards,
Peter Hurley
next prev parent reply other threads:[~2014-10-10 10:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 9:10 [PATCH] serial: of-serial: fix up PM ops on no_console_suspend Jingchang Lu
2014-10-09 9:10 ` Jingchang Lu
2014-10-09 9:10 ` Jingchang Lu
2014-10-10 5:04 ` Stephen Warren
2014-10-10 5:04 ` Stephen Warren
2014-10-10 6:16 ` Jingchang Lu
2014-10-10 6:16 ` Jingchang Lu
2014-10-10 6:16 ` Jingchang Lu
2014-10-10 10:25 ` Peter Hurley [this message]
2014-10-10 10:25 ` Peter Hurley
2014-10-10 11:39 ` Peter Hurley
2014-10-10 11:39 ` Peter Hurley
2014-10-11 3:37 ` Jingchang Lu
2014-10-11 3:37 ` Jingchang Lu
2014-10-11 3:37 ` Jingchang Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5437B416.2080606@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jingchang.lu@freescale.com \
--cc=josephl@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.