From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 1/1 linux-next] GFS2: directly return gfs2_dir_check()
Date: Fri, 10 Oct 2014 14:21:29 +0100 [thread overview]
Message-ID: <5437DD59.5000906@redhat.com> (raw)
In-Reply-To: <1412887761-15293-1-git-send-email-fabf@skynet.be>
Hi,
On 09/10/14 21:49, Fabian Frederick wrote:
> No need to store gfs2_dir_check result and test it before returning.
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Since I've already sent a pull request for this merge window, and this
is not urgent, I'll keep this one and use it to start off the new tree
in due course, once the merge window has closed. Thanks,
Steve,
> ---
> fs/gfs2/inode.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
> index c4ed823..b41b5c7 100644
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -1045,11 +1045,7 @@ static int gfs2_unlink_ok(struct gfs2_inode *dip, const struct qstr *name,
> if (error)
> return error;
>
> - error = gfs2_dir_check(&dip->i_inode, name, ip);
> - if (error)
> - return error;
> -
> - return 0;
> + return gfs2_dir_check(&dip->i_inode, name, ip);
> }
>
> /**
WARNING: multiple messages have this Message-ID (diff)
From: Steven Whitehouse <swhiteho@redhat.com>
To: Fabian Frederick <fabf@skynet.be>, linux-kernel@vger.kernel.org
Cc: cluster-devel@redhat.com
Subject: Re: [PATCH 1/1 linux-next] GFS2: directly return gfs2_dir_check()
Date: Fri, 10 Oct 2014 14:21:29 +0100 [thread overview]
Message-ID: <5437DD59.5000906@redhat.com> (raw)
In-Reply-To: <1412887761-15293-1-git-send-email-fabf@skynet.be>
Hi,
On 09/10/14 21:49, Fabian Frederick wrote:
> No need to store gfs2_dir_check result and test it before returning.
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Since I've already sent a pull request for this merge window, and this
is not urgent, I'll keep this one and use it to start off the new tree
in due course, once the merge window has closed. Thanks,
Steve,
> ---
> fs/gfs2/inode.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
> index c4ed823..b41b5c7 100644
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -1045,11 +1045,7 @@ static int gfs2_unlink_ok(struct gfs2_inode *dip, const struct qstr *name,
> if (error)
> return error;
>
> - error = gfs2_dir_check(&dip->i_inode, name, ip);
> - if (error)
> - return error;
> -
> - return 0;
> + return gfs2_dir_check(&dip->i_inode, name, ip);
> }
>
> /**
next prev parent reply other threads:[~2014-10-10 13:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 20:49 [Cluster-devel] [PATCH 1/1 linux-next] GFS2: directly return gfs2_dir_check() Fabian Frederick
2014-10-09 20:49 ` Fabian Frederick
2014-10-10 13:21 ` Steven Whitehouse [this message]
2014-10-10 13:21 ` Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5437DD59.5000906@redhat.com \
--to=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.