From: Eric Blake <eblake@redhat.com>
To: arei.gonglei@huawei.com, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, qemu-trivial@nongnu.org,
weidong.huang@huawei.com, stefanha@redhat.com,
pbonzini@redhat.com
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] oslib-posix: change free to g_free
Date: Fri, 10 Oct 2014 21:23:52 -0600 [thread overview]
Message-ID: <5438A2C8.80508@redhat.com> (raw)
In-Reply-To: <1412996048-6384-1-git-send-email-arei.gonglei@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 652 bytes --]
On 10/10/2014 08:54 PM, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> The caller of qemu_vfree() maybe not check whether parameter
> ptr pointer is NULL or not, such as vpc_open().
> Using g_free() is more safe.
NACK. g_free is only safe for pointers allocated by g_malloc.
qemu_vfree is for use on pointers allocated by qemu_try_memalign and
friends (matching the name valloc which is an older spelling of
posix_memalign), which are NOT allocated by g_malloc. Furthermore,
free(NULL) is safe.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: arei.gonglei@huawei.com, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, qemu-trivial@nongnu.org,
weidong.huang@huawei.com, stefanha@redhat.com,
pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH] oslib-posix: change free to g_free
Date: Fri, 10 Oct 2014 21:23:52 -0600 [thread overview]
Message-ID: <5438A2C8.80508@redhat.com> (raw)
In-Reply-To: <1412996048-6384-1-git-send-email-arei.gonglei@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 652 bytes --]
On 10/10/2014 08:54 PM, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> The caller of qemu_vfree() maybe not check whether parameter
> ptr pointer is NULL or not, such as vpc_open().
> Using g_free() is more safe.
NACK. g_free is only safe for pointers allocated by g_malloc.
qemu_vfree is for use on pointers allocated by qemu_try_memalign and
friends (matching the name valloc which is an older spelling of
posix_memalign), which are NOT allocated by g_malloc. Furthermore,
free(NULL) is safe.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-10-11 3:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 2:54 [Qemu-trivial] [PATCH] oslib-posix: change free to g_free arei.gonglei
2014-10-11 2:54 ` [Qemu-devel] " arei.gonglei
2014-10-11 3:10 ` [Qemu-trivial] " zhanghailiang
2014-10-11 3:10 ` zhanghailiang
2014-10-11 3:21 ` [Qemu-trivial] " Gonglei
2014-10-11 3:21 ` Gonglei
2014-10-11 3:26 ` [Qemu-trivial] " Eric Blake
2014-10-11 3:26 ` Eric Blake
2014-10-11 3:32 ` [Qemu-trivial] " Gonglei
2014-10-11 3:32 ` Gonglei
2014-10-11 3:44 ` [Qemu-trivial] " Eric Blake
2014-10-11 3:44 ` Eric Blake
2014-10-11 3:47 ` [Qemu-trivial] " Gonglei
2014-10-11 3:47 ` Gonglei
2014-10-11 3:23 ` Eric Blake [this message]
2014-10-11 3:23 ` Eric Blake
2014-10-12 7:44 ` [Qemu-trivial] " Kevin Wolf
2014-10-12 7:44 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5438A2C8.80508@redhat.com \
--to=eblake@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.