* [PATCH 1/1] ALSA: ALC283 codec - Avoid pop noise on headphones during suspend/resume
@ 2014-10-09 11:04 Harsha Priya
2014-10-09 18:41 ` Takashi Iwai
0 siblings, 1 reply; 8+ messages in thread
From: Harsha Priya @ 2014-10-09 11:04 UTC (permalink / raw)
To: patch; +Cc: Harsha Priya, alsa-devel
This patch sets the headphones mode to default before suspending
which helps avoid the pop noise on headphones
Signed-off-by: Harsha Priya <harshapriya.n@intel.com>
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 69d1236..e839e7a 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -2884,6 +2884,9 @@ static void alc283_shutup(struct hda_codec *codec)
alc_write_coef_idx(codec, 0x43, 0x9004);
+ /*depop hp during suspend*/
+ alc_write_coef_idx(codec, 0x06, 0x2100);
+
snd_hda_codec_write(codec, hp_pin, 0,
AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_MUTE);
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] ALSA: ALC283 codec - Avoid pop noise on headphones during suspend/resume
2014-10-09 11:04 [PATCH 1/1] ALSA: ALC283 codec - Avoid pop noise on headphones during suspend/resume Harsha Priya
@ 2014-10-09 18:41 ` Takashi Iwai
2014-10-13 10:50 ` David Henningsson
0 siblings, 1 reply; 8+ messages in thread
From: Takashi Iwai @ 2014-10-09 18:41 UTC (permalink / raw)
To: Harsha Priya; +Cc: alsa-devel, David Henningsson
At Thu, 9 Oct 2014 11:04:56 +0000,
Harsha Priya wrote:
>
> This patch sets the headphones mode to default before suspending
> which helps avoid the pop noise on headphones
The change looks simple, but since it's a mysterious COEF, I'd like to
hear from people testing with other machines with this codec before
applying the patch.
David, do you know anyone in your team have such a machine to test?
thanks,
Takashi
>
> Signed-off-by: Harsha Priya <harshapriya.n@intel.com>
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 69d1236..e839e7a 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -2884,6 +2884,9 @@ static void alc283_shutup(struct hda_codec *codec)
>
> alc_write_coef_idx(codec, 0x43, 0x9004);
>
> + /*depop hp during suspend*/
> + alc_write_coef_idx(codec, 0x06, 0x2100);
> +
> snd_hda_codec_write(codec, hp_pin, 0,
> AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_MUTE);
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] ALSA: ALC283 codec - Avoid pop noise on headphones during suspend/resume
2014-10-09 18:41 ` Takashi Iwai
@ 2014-10-13 10:50 ` David Henningsson
2014-10-14 16:10 ` Hui Wang
2014-10-19 20:25 ` Hui Wang
0 siblings, 2 replies; 8+ messages in thread
From: David Henningsson @ 2014-10-13 10:50 UTC (permalink / raw)
To: Takashi Iwai, Harsha Priya; +Cc: hui.wang, alsa-devel
On 2014-10-09 20:41, Takashi Iwai wrote:
> At Thu, 9 Oct 2014 11:04:56 +0000,
> Harsha Priya wrote:
>> This patch sets the headphones mode to default before suspending
>> which helps avoid the pop noise on headphones
> The change looks simple, but since it's a mysterious COEF, I'd like to
> hear from people testing with other machines with this codec before
> applying the patch.
>
> David, do you know anyone in your team have such a machine to test?
Looping Hui here, do you have a machine with ALC283 to test with or
knows who has one?
>
>
> thanks,
>
> Takashi
>
>> Signed-off-by: Harsha Priya <harshapriya.n@intel.com>
>>
>> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>> index 69d1236..e839e7a 100644
>> --- a/sound/pci/hda/patch_realtek.c
>> +++ b/sound/pci/hda/patch_realtek.c
>> @@ -2884,6 +2884,9 @@ static void alc283_shutup(struct hda_codec *codec)
>>
>> alc_write_coef_idx(codec, 0x43, 0x9004);
>>
>> + /*depop hp during suspend*/
>> + alc_write_coef_idx(codec, 0x06, 0x2100);
>> +
>> snd_hda_codec_write(codec, hp_pin, 0,
>> AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_MUTE);
>>
>> --
>> 1.9.1
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] ALSA: ALC283 codec - Avoid pop noise on headphones during suspend/resume
2014-10-13 10:50 ` David Henningsson
@ 2014-10-14 16:10 ` Hui Wang
2014-10-15 9:34 ` Takashi Iwai
2014-10-19 20:25 ` Hui Wang
1 sibling, 1 reply; 8+ messages in thread
From: Hui Wang @ 2014-10-14 16:10 UTC (permalink / raw)
To: David Henningsson, Takashi Iwai, Harsha Priya; +Cc: alsa-devel
On 10/13/2014 06:50 PM, David Henningsson wrote:
>
> On 2014-10-09 20:41, Takashi Iwai wrote:
>> At Thu, 9 Oct 2014 11:04:56 +0000,
>> Harsha Priya wrote:
>>> This patch sets the headphones mode to default before suspending
>>> which helps avoid the pop noise on headphones
>> The change looks simple, but since it's a mysterious COEF, I'd like to
>> hear from people testing with other machines with this codec before
>> applying the patch.
>>
>> David, do you know anyone in your team have such a machine to test?
>
> Looping Hui here, do you have a machine with ALC283 to test with or
> knows who has one?
I will find one or two machines with ALC283 to do a test. Since I am not
in the office right now, after I find the machines, I will ask someone
else to help do the test, it will take more time. So give me couple of days.
>
>>
>>
>> thanks,
>>
>> Takashi
>>
>>> Signed-off-by: Harsha Priya <harshapriya.n@intel.com>
>>>
>>> diff --git a/sound/pci/hda/patch_realtek.c
>>> b/sound/pci/hda/patch_realtek.c
>>> index 69d1236..e839e7a 100644
>>> --- a/sound/pci/hda/patch_realtek.c
>>> +++ b/sound/pci/hda/patch_realtek.c
>>> @@ -2884,6 +2884,9 @@ static void alc283_shutup(struct hda_codec
>>> *codec)
>>> alc_write_coef_idx(codec, 0x43, 0x9004);
>>> + /*depop hp during suspend*/
>>> + alc_write_coef_idx(codec, 0x06, 0x2100);
>>> +
>>> snd_hda_codec_write(codec, hp_pin, 0,
>>> AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_MUTE);
>>> --
>>> 1.9.1
>>>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] ALSA: ALC283 codec - Avoid pop noise on headphones during suspend/resume
2014-10-14 16:10 ` Hui Wang
@ 2014-10-15 9:34 ` Takashi Iwai
0 siblings, 0 replies; 8+ messages in thread
From: Takashi Iwai @ 2014-10-15 9:34 UTC (permalink / raw)
To: Hui Wang; +Cc: Harsha Priya, alsa-devel, David Henningsson
At Wed, 15 Oct 2014 00:10:54 +0800,
Hui Wang wrote:
>
> On 10/13/2014 06:50 PM, David Henningsson wrote:
> >
> > On 2014-10-09 20:41, Takashi Iwai wrote:
> >> At Thu, 9 Oct 2014 11:04:56 +0000,
> >> Harsha Priya wrote:
> >>> This patch sets the headphones mode to default before suspending
> >>> which helps avoid the pop noise on headphones
> >> The change looks simple, but since it's a mysterious COEF, I'd like to
> >> hear from people testing with other machines with this codec before
> >> applying the patch.
> >>
> >> David, do you know anyone in your team have such a machine to test?
> >
> > Looping Hui here, do you have a machine with ALC283 to test with or
> > knows who has one?
>
> I will find one or two machines with ALC283 to do a test. Since I am not
> in the office right now, after I find the machines, I will ask someone
> else to help do the test, it will take more time. So give me couple of days.
Sure, thanks! The patch itself is small, so it can go into 3.18 once
when it's confirmed to work and not break.
Takashi
>
> >
> >>
> >>
> >> thanks,
> >>
> >> Takashi
> >>
> >>> Signed-off-by: Harsha Priya <harshapriya.n@intel.com>
> >>>
> >>> diff --git a/sound/pci/hda/patch_realtek.c
> >>> b/sound/pci/hda/patch_realtek.c
> >>> index 69d1236..e839e7a 100644
> >>> --- a/sound/pci/hda/patch_realtek.c
> >>> +++ b/sound/pci/hda/patch_realtek.c
> >>> @@ -2884,6 +2884,9 @@ static void alc283_shutup(struct hda_codec
> >>> *codec)
> >>> alc_write_coef_idx(codec, 0x43, 0x9004);
> >>> + /*depop hp during suspend*/
> >>> + alc_write_coef_idx(codec, 0x06, 0x2100);
> >>> +
> >>> snd_hda_codec_write(codec, hp_pin, 0,
> >>> AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_MUTE);
> >>> --
> >>> 1.9.1
> >>>
> >
> >
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] ALSA: ALC283 codec - Avoid pop noise on headphones during suspend/resume
2014-10-13 10:50 ` David Henningsson
2014-10-14 16:10 ` Hui Wang
@ 2014-10-19 20:25 ` Hui Wang
2014-10-20 5:50 ` Takashi Iwai
1 sibling, 1 reply; 8+ messages in thread
From: Hui Wang @ 2014-10-19 20:25 UTC (permalink / raw)
To: David Henningsson, Takashi Iwai, Harsha Priya; +Cc: alsa-devel
On 10/13/2014 06:50 PM, David Henningsson wrote:
>
> On 2014-10-09 20:41, Takashi Iwai wrote:
>> At Thu, 9 Oct 2014 11:04:56 +0000,
>> Harsha Priya wrote:
>>> This patch sets the headphones mode to default before suspending
>>> which helps avoid the pop noise on headphones
>> The change looks simple, but since it's a mysterious COEF, I'd like to
>> hear from people testing with other machines with this codec before
>> applying the patch.
>>
>> David, do you know anyone in your team have such a machine to test?
>
> Looping Hui here, do you have a machine with ALC283 to test with or
> knows who has one?
One of my colleague performed the test, and seems the patch did work.
Below is the feedback from my colleague:
"I tested the patch on Dell Inspiron 3531 which has ALC283 Codec on it.
Without the patch, I can hear a pop noise from the headphone, not very harshly, but I can
hear there is a pop sound clearly when suspend or reboot.
With the patch, there is still a pop sound with very low volume when
suspend, you can notice the sound when listening it carefully.
When reboot, there is no pop sound."
Regards,
Hui.
>
>>
>>
>> thanks,
>>
>> Takashi
>>
>>> Signed-off-by: Harsha Priya <harshapriya.n@intel.com>
>>>
>>> diff --git a/sound/pci/hda/patch_realtek.c
>>> b/sound/pci/hda/patch_realtek.c
>>> index 69d1236..e839e7a 100644
>>> --- a/sound/pci/hda/patch_realtek.c
>>> +++ b/sound/pci/hda/patch_realtek.c
>>> @@ -2884,6 +2884,9 @@ static void alc283_shutup(struct hda_codec
>>> *codec)
>>> alc_write_coef_idx(codec, 0x43, 0x9004);
>>> + /*depop hp during suspend*/
>>> + alc_write_coef_idx(codec, 0x06, 0x2100);
>>> +
>>> snd_hda_codec_write(codec, hp_pin, 0,
>>> AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_MUTE);
>>> --
>>> 1.9.1
>>>
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] ALSA: ALC283 codec - Avoid pop noise on headphones during suspend/resume
2014-10-19 20:25 ` Hui Wang
@ 2014-10-20 5:50 ` Takashi Iwai
0 siblings, 0 replies; 8+ messages in thread
From: Takashi Iwai @ 2014-10-20 5:50 UTC (permalink / raw)
To: Hui Wang; +Cc: Harsha Priya, alsa-devel, David Henningsson
At Mon, 20 Oct 2014 04:25:00 +0800,
Hui Wang wrote:
>
> On 10/13/2014 06:50 PM, David Henningsson wrote:
> >
> > On 2014-10-09 20:41, Takashi Iwai wrote:
> >> At Thu, 9 Oct 2014 11:04:56 +0000,
> >> Harsha Priya wrote:
> >>> This patch sets the headphones mode to default before suspending
> >>> which helps avoid the pop noise on headphones
> >> The change looks simple, but since it's a mysterious COEF, I'd like to
> >> hear from people testing with other machines with this codec before
> >> applying the patch.
> >>
> >> David, do you know anyone in your team have such a machine to test?
> >
> > Looping Hui here, do you have a machine with ALC283 to test with or
> > knows who has one?
> One of my colleague performed the test, and seems the patch did work.
> Below is the feedback from my colleague:
>
> "I tested the patch on Dell Inspiron 3531 which has ALC283 Codec on it.
> Without the patch, I can hear a pop noise from the headphone, not very harshly, but I can
> hear there is a pop sound clearly when suspend or reboot.
> With the patch, there is still a pop sound with very low volume when
> suspend, you can notice the sound when listening it carefully.
> When reboot, there is no pop sound."
Thanks for a quick test!
Now I applied it. I added Cc to stable as it deserves.
Takashi
>
>
> Regards,
> Hui.
>
> >
> >>
> >>
> >> thanks,
> >>
> >> Takashi
> >>
> >>> Signed-off-by: Harsha Priya <harshapriya.n@intel.com>
> >>>
> >>> diff --git a/sound/pci/hda/patch_realtek.c
> >>> b/sound/pci/hda/patch_realtek.c
> >>> index 69d1236..e839e7a 100644
> >>> --- a/sound/pci/hda/patch_realtek.c
> >>> +++ b/sound/pci/hda/patch_realtek.c
> >>> @@ -2884,6 +2884,9 @@ static void alc283_shutup(struct hda_codec
> >>> *codec)
> >>> alc_write_coef_idx(codec, 0x43, 0x9004);
> >>> + /*depop hp during suspend*/
> >>> + alc_write_coef_idx(codec, 0x06, 0x2100);
> >>> +
> >>> snd_hda_codec_write(codec, hp_pin, 0,
> >>> AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_MUTE);
> >>> --
> >>> 1.9.1
> >>>
> >
> > _______________________________________________
> > Alsa-devel mailing list
> > Alsa-devel@alsa-project.org
> > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> >
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/1] ALSA: ALC283 codec - Avoid pop noise on headphones during suspend/resume
@ 2014-10-09 11:32 Harsha Priya
0 siblings, 0 replies; 8+ messages in thread
From: Harsha Priya @ 2014-10-09 11:32 UTC (permalink / raw)
To: patch; +Cc: Harsha Priya, alsa-devel
This patch sets the headphones mode to default before suspending
which helps avoid the pop noise on headphones
Signed-off-by: Harsha Priya <harshapriya.n@intel.com>
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 69d1236..e839e7a 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -2884,6 +2884,9 @@ static void alc283_shutup(struct hda_codec *codec)
alc_write_coef_idx(codec, 0x43, 0x9004);
+ /*depop hp during suspend*/
+ alc_write_coef_idx(codec, 0x06, 0x2100);
+
snd_hda_codec_write(codec, hp_pin, 0,
AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_MUTE);
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-10-20 5:50 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-09 11:04 [PATCH 1/1] ALSA: ALC283 codec - Avoid pop noise on headphones during suspend/resume Harsha Priya
2014-10-09 18:41 ` Takashi Iwai
2014-10-13 10:50 ` David Henningsson
2014-10-14 16:10 ` Hui Wang
2014-10-15 9:34 ` Takashi Iwai
2014-10-19 20:25 ` Hui Wang
2014-10-20 5:50 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2014-10-09 11:32 Harsha Priya
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.