All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Gang <gang.chen.5i5j@gmail.com>
To: agraf@suse.de, pbonzini@redhat.com
Cc: qemu-trivial@nongnu.org, qemu-ppc@nongnu.org,
	qemu-devel <qemu-devel@nongnu.org>,
	kvm@vger.kernel.org
Subject: [Qemu-trivial] [PATCH] target-ppc: kvm: Fix memory overflow issue about strncat()
Date: Mon, 13 Oct 2014 22:36:02 +0800	[thread overview]
Message-ID: <543BE352.3080609@gmail.com> (raw)

strncat() will append additional '\0' to destination buffer, so need
additional 1 byte for it, or may cause memory overflow, just like other
area within QEMU have done.

Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 target-ppc/kvm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
index 9c23c6b..66e7ce5 100644
--- a/target-ppc/kvm.c
+++ b/target-ppc/kvm.c
@@ -1794,8 +1794,8 @@ static uint64_t kvmppc_read_int_cpu_dt(const char *propname)
         return -1;
     }
 
-    strncat(buf, "/", sizeof(buf) - strlen(buf));
-    strncat(buf, propname, sizeof(buf) - strlen(buf));
+    strncat(buf, "/", sizeof(buf) - strlen(buf) - 1);
+    strncat(buf, propname, sizeof(buf) - strlen(buf) - 1);
 
     f = fopen(buf, "rb");
     if (!f) {
-- 
1.9.3


WARNING: multiple messages have this Message-ID (diff)
From: Chen Gang <gang.chen.5i5j@gmail.com>
To: agraf@suse.de, pbonzini@redhat.com
Cc: qemu-ppc@nongnu.org, kvm@vger.kernel.org,
	qemu-devel <qemu-devel@nongnu.org>,
	qemu-trivial@nongnu.org
Subject: [PATCH] target-ppc: kvm: Fix memory overflow issue about strncat()
Date: Mon, 13 Oct 2014 22:36:02 +0800	[thread overview]
Message-ID: <543BE352.3080609@gmail.com> (raw)

strncat() will append additional '\0' to destination buffer, so need
additional 1 byte for it, or may cause memory overflow, just like other
area within QEMU have done.

Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 target-ppc/kvm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
index 9c23c6b..66e7ce5 100644
--- a/target-ppc/kvm.c
+++ b/target-ppc/kvm.c
@@ -1794,8 +1794,8 @@ static uint64_t kvmppc_read_int_cpu_dt(const char *propname)
         return -1;
     }
 
-    strncat(buf, "/", sizeof(buf) - strlen(buf));
-    strncat(buf, propname, sizeof(buf) - strlen(buf));
+    strncat(buf, "/", sizeof(buf) - strlen(buf) - 1);
+    strncat(buf, propname, sizeof(buf) - strlen(buf) - 1);
 
     f = fopen(buf, "rb");
     if (!f) {
-- 
1.9.3

WARNING: multiple messages have this Message-ID (diff)
From: Chen Gang <gang.chen.5i5j@gmail.com>
To: agraf@suse.de, pbonzini@redhat.com
Cc: qemu-trivial@nongnu.org, qemu-ppc@nongnu.org,
	qemu-devel <qemu-devel@nongnu.org>,
	kvm@vger.kernel.org
Subject: [Qemu-devel] [PATCH] target-ppc: kvm: Fix memory overflow issue about strncat()
Date: Mon, 13 Oct 2014 22:36:02 +0800	[thread overview]
Message-ID: <543BE352.3080609@gmail.com> (raw)

strncat() will append additional '\0' to destination buffer, so need
additional 1 byte for it, or may cause memory overflow, just like other
area within QEMU have done.

Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 target-ppc/kvm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
index 9c23c6b..66e7ce5 100644
--- a/target-ppc/kvm.c
+++ b/target-ppc/kvm.c
@@ -1794,8 +1794,8 @@ static uint64_t kvmppc_read_int_cpu_dt(const char *propname)
         return -1;
     }
 
-    strncat(buf, "/", sizeof(buf) - strlen(buf));
-    strncat(buf, propname, sizeof(buf) - strlen(buf));
+    strncat(buf, "/", sizeof(buf) - strlen(buf) - 1);
+    strncat(buf, propname, sizeof(buf) - strlen(buf) - 1);
 
     f = fopen(buf, "rb");
     if (!f) {
-- 
1.9.3

             reply	other threads:[~2014-10-13 14:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-13 14:36 Chen Gang [this message]
2014-10-13 14:36 ` [Qemu-devel] [PATCH] target-ppc: kvm: Fix memory overflow issue about strncat() Chen Gang
2014-10-13 14:36 ` Chen Gang
2014-10-13 14:47 ` [Qemu-trivial] " Alexander Graf
2014-10-13 14:47   ` [Qemu-devel] " Alexander Graf
2014-10-13 14:47   ` Alexander Graf
2014-10-13 15:43   ` [Qemu-trivial] " Chen Gang
2014-10-13 15:43     ` [Qemu-devel] " Chen Gang
2014-10-13 15:43     ` Chen Gang
2014-10-24  7:49   ` [Qemu-trivial] " Michael Tokarev
2014-10-24  7:49     ` [Qemu-devel] " Michael Tokarev
2014-10-24  8:05     ` Alexander Graf
2014-10-24  8:05       ` [Qemu-devel] " Alexander Graf
2014-10-24  8:05       ` Alexander Graf
2014-10-24  8:19     ` Chen Gang
2014-10-24  8:19       ` [Qemu-devel] " Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=543BE352.3080609@gmail.com \
    --to=gang.chen.5i5j@gmail.com \
    --cc=agraf@suse.de \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.