From: Peter Hurley <peter@hurleysoftware.com>
To: Jingchang Lu <jingchang.lu@freescale.com>, gregkh@linuxfoundation.org
Cc: arnd@arndb.de, linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv4] serial: of-serial: fix up PM ops on no_console_suspend and port type
Date: Tue, 14 Oct 2014 06:31:05 -0400 [thread overview]
Message-ID: <543CFB69.50300@hurleysoftware.com> (raw)
In-Reply-To: <1413276146-20388-1-git-send-email-jingchang.lu@freescale.com>
On 10/14/2014 04:42 AM, Jingchang Lu wrote:
> This patch fixes commit 2dea53bf57783f243c892e99c10c6921e956aa7e,
> "serial: of-serial: add PM suspend/resume support", which disables
> the uart clock on suspend, but also causes a hardware hang on register
> access if no_console_suspend command line option is used.
>
> Also, not every of_serial device is an 8250 port, so the serial8250
> suspend/resume functions should only be applied to a real 8250 port.
Thanks.
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
WARNING: multiple messages have this Message-ID (diff)
From: peter@hurleysoftware.com (Peter Hurley)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv4] serial: of-serial: fix up PM ops on no_console_suspend and port type
Date: Tue, 14 Oct 2014 06:31:05 -0400 [thread overview]
Message-ID: <543CFB69.50300@hurleysoftware.com> (raw)
In-Reply-To: <1413276146-20388-1-git-send-email-jingchang.lu@freescale.com>
On 10/14/2014 04:42 AM, Jingchang Lu wrote:
> This patch fixes commit 2dea53bf57783f243c892e99c10c6921e956aa7e,
> "serial: of-serial: add PM suspend/resume support", which disables
> the uart clock on suspend, but also causes a hardware hang on register
> access if no_console_suspend command line option is used.
>
> Also, not every of_serial device is an 8250 port, so the serial8250
> suspend/resume functions should only be applied to a real 8250 port.
Thanks.
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
next prev parent reply other threads:[~2014-10-14 10:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 8:42 [PATCHv4] serial: of-serial: fix up PM ops on no_console_suspend and port type Jingchang Lu
2014-10-14 8:42 ` Jingchang Lu
2014-10-14 8:42 ` Jingchang Lu
2014-10-14 10:31 ` Peter Hurley [this message]
2014-10-14 10:31 ` Peter Hurley
2014-10-15 1:01 ` Joseph Lo
2014-10-15 1:01 ` Joseph Lo
2014-10-15 6:32 ` Jingchang Lu
2014-10-15 6:32 ` Jingchang Lu
2014-10-15 6:32 ` Jingchang Lu
2014-10-15 6:41 ` Joseph Lo
2014-10-15 6:41 ` Joseph Lo
2014-10-15 6:52 ` Joseph Lo
2014-10-15 6:52 ` Joseph Lo
2014-10-15 7:16 ` Jingchang Lu
2014-10-15 7:16 ` Jingchang Lu
2014-10-15 7:16 ` Jingchang Lu
2014-10-15 6:53 ` Jingchang Lu
2014-10-15 6:53 ` Jingchang Lu
2014-10-15 6:53 ` Jingchang Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543CFB69.50300@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jingchang.lu@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.