From: Michael Opdenacker <michael.opdenacker@free-electrons.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: jg1.han@samsung.com, computersforpeace@gmail.com,
dwmw2@infradead.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: orion_nand: fix error code path in probe
Date: Thu, 16 Oct 2014 07:06:12 +0200 [thread overview]
Message-ID: <543F5244.1010408@free-electrons.com> (raw)
In-Reply-To: <20141014213503.GD5331@lunn.ch>
On 10/14/2014 11:35 PM, Andrew Lunn wrote:
>
>
> if (pdev->dev.of_node) {
> board = devm_kzalloc(&pdev->dev, sizeof(struct orion_nand_data),
> GFP_KERNEL);
> if (!board) {
> - ret = -ENOMEM;
> - goto no_res;
> + return -ENOMEM;
> }
> Doesn't this now break the coding style? No need to have the {} since
> it is a single statement.
Right, I've checked Documentation/CodingStyle, and this is just
recommended, not absolutely required. That could be the reason why
check_patch.pl didn't complain.
My v2 changes this.
Thanks!
Michael.
--
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098
WARNING: multiple messages have this Message-ID (diff)
From: Michael Opdenacker <michael.opdenacker@free-electrons.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: dwmw2@infradead.org, computersforpeace@gmail.com,
jg1.han@samsung.com, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: orion_nand: fix error code path in probe
Date: Thu, 16 Oct 2014 07:06:12 +0200 [thread overview]
Message-ID: <543F5244.1010408@free-electrons.com> (raw)
In-Reply-To: <20141014213503.GD5331@lunn.ch>
On 10/14/2014 11:35 PM, Andrew Lunn wrote:
>
>
> if (pdev->dev.of_node) {
> board = devm_kzalloc(&pdev->dev, sizeof(struct orion_nand_data),
> GFP_KERNEL);
> if (!board) {
> - ret = -ENOMEM;
> - goto no_res;
> + return -ENOMEM;
> }
> Doesn't this now break the coding style? No need to have the {} since
> it is a single statement.
Right, I've checked Documentation/CodingStyle, and this is just
recommended, not absolutely required. That could be the reason why
check_patch.pl didn't complain.
My v2 changes this.
Thanks!
Michael.
--
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098
next prev parent reply other threads:[~2014-10-16 5:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 14:16 [PATCH] mtd: orion_nand: fix error code path in probe Michael Opdenacker
2014-10-14 14:16 ` Michael Opdenacker
2014-10-14 21:35 ` Andrew Lunn
2014-10-14 21:35 ` Andrew Lunn
2014-10-15 21:39 ` Ezequiel Garcia
2014-10-15 21:39 ` Ezequiel Garcia
2014-10-16 4:43 ` Michael Opdenacker
2014-10-16 4:43 ` Michael Opdenacker
2014-10-16 4:58 ` [PATCH v2] " Michael Opdenacker
2014-10-16 4:58 ` Michael Opdenacker
2014-10-16 7:39 ` Jingoo Han
2014-10-16 7:39 ` Jingoo Han
2014-10-18 19:35 ` Andrew Lunn
2014-10-18 19:35 ` Andrew Lunn
2014-10-22 8:49 ` Brian Norris
2014-10-22 8:49 ` Brian Norris
2014-10-16 5:06 ` Michael Opdenacker [this message]
2014-10-16 5:06 ` [PATCH] " Michael Opdenacker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543F5244.1010408@free-electrons.com \
--to=michael.opdenacker@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.