From: Khiem Nguyen <khiem.nguyen.xt@renesas.com>
To: Simon Horman <horms@verge.net.au>,
Yoshihiro Kaneko <ykaneko0929@gmail.com>
Cc: khiem.nguyen.xt@renesas.com, linux-ide@vger.kernel.org,
Tejun Heo <tj@kernel.org>, Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2] ata: sata_rcar: Add r8a7793 device support
Date: Thu, 16 Oct 2014 14:43:05 +0900 [thread overview]
Message-ID: <543F5AE9.7030603@renesas.com> (raw)
In-Reply-To: <20141016052054.GF1265@verge.net.au>
Hi,
On 10/16/2014 2:20 PM, Simon Horman wrote:
> On Wed, Oct 15, 2014 at 05:59:37PM +0900, Yoshihiro Kaneko wrote:
>> From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
>>
>> Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>
> Acked-by: Simon Horman <horms+renesas@verge.net.au>
>
> Tejun, could you consider picking up this change?
Uhmm, R8A7793 SoC hadn't been supported in upstream Linux kernel yet.
So, is it still OK to take this patch now ?
>> ---
>>
>> This patch is against for-next branch of Tejun's libata repo.
>>
>> v2 [Yoshihiro Kaneko]
>> * Update the binding documentation
>>
>> Documentation/devicetree/bindings/ata/sata_rcar.txt | 3 ++-
>> drivers/ata/sata_rcar.c | 5 +++++
>> 2 files changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/ata/sata_rcar.txt b/Documentation/devicetree/bindings/ata/sata_rcar.txt
>> index 1e61113..74b1130 100644
>> --- a/Documentation/devicetree/bindings/ata/sata_rcar.txt
>> +++ b/Documentation/devicetree/bindings/ata/sata_rcar.txt
>> @@ -4,7 +4,8 @@ Required properties:
>> - compatible : should contain one of the following:
>> - "renesas,sata-r8a7779" for R-Car H1
>> - "renesas,sata-r8a7790" for R-Car H2
>> - - "renesas,sata-r8a7791" for R-Car M2
>> + - "renesas,sata-r8a7791" for R-Car M2-W
>> + - "renesas,sata-r8a7793" for R-Car M2-N
>> - reg : address and length of the SATA registers;
>> - interrupts : must consist of one interrupt specifier.
>>
>> diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c
>> index 61eb6d7..6f8ed8e 100644
>> --- a/drivers/ata/sata_rcar.c
>> +++ b/drivers/ata/sata_rcar.c
>> @@ -841,6 +841,10 @@ static struct of_device_id sata_rcar_match[] = {
>> .compatible = "renesas,sata-r8a7791",
>> .data = (void *)RCAR_GEN2_SATA
>> },
>> + {
>> + .compatible = "renesas,sata-r8a7793",
>> + .data = (void *)RCAR_GEN2_SATA
>> + },
>> { },
>> };
>> MODULE_DEVICE_TABLE(of, sata_rcar_match);
>> @@ -850,6 +854,7 @@ static const struct platform_device_id sata_rcar_id_table[] = {
>> { "sata-r8a7779", RCAR_GEN1_SATA },
>> { "sata-r8a7790", RCAR_GEN2_SATA },
>> { "sata-r8a7791", RCAR_GEN2_SATA },
>> + { "sata-r8a7793", RCAR_GEN2_SATA },
>> { },
>> };
>> MODULE_DEVICE_TABLE(platform, sata_rcar_id_table);
>> --
>> 1.9.1
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Best regards,
KHIEM Nguyen
WARNING: multiple messages have this Message-ID (diff)
From: Khiem Nguyen <khiem.nguyen.xt@renesas.com>
To: Simon Horman <horms@verge.net.au>,
Yoshihiro Kaneko <ykaneko0929@gmail.com>
Cc: khiem.nguyen.xt@renesas.com, linux-ide@vger.kernel.org,
Tejun Heo <tj@kernel.org>, Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2] ata: sata_rcar: Add r8a7793 device support
Date: Thu, 16 Oct 2014 05:43:05 +0000 [thread overview]
Message-ID: <543F5AE9.7030603@renesas.com> (raw)
In-Reply-To: <20141016052054.GF1265@verge.net.au>
Hi,
On 10/16/2014 2:20 PM, Simon Horman wrote:
> On Wed, Oct 15, 2014 at 05:59:37PM +0900, Yoshihiro Kaneko wrote:
>> From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
>>
>> Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>
> Acked-by: Simon Horman <horms+renesas@verge.net.au>
>
> Tejun, could you consider picking up this change?
Uhmm, R8A7793 SoC hadn't been supported in upstream Linux kernel yet.
So, is it still OK to take this patch now ?
>> ---
>>
>> This patch is against for-next branch of Tejun's libata repo.
>>
>> v2 [Yoshihiro Kaneko]
>> * Update the binding documentation
>>
>> Documentation/devicetree/bindings/ata/sata_rcar.txt | 3 ++-
>> drivers/ata/sata_rcar.c | 5 +++++
>> 2 files changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/ata/sata_rcar.txt b/Documentation/devicetree/bindings/ata/sata_rcar.txt
>> index 1e61113..74b1130 100644
>> --- a/Documentation/devicetree/bindings/ata/sata_rcar.txt
>> +++ b/Documentation/devicetree/bindings/ata/sata_rcar.txt
>> @@ -4,7 +4,8 @@ Required properties:
>> - compatible : should contain one of the following:
>> - "renesas,sata-r8a7779" for R-Car H1
>> - "renesas,sata-r8a7790" for R-Car H2
>> - - "renesas,sata-r8a7791" for R-Car M2
>> + - "renesas,sata-r8a7791" for R-Car M2-W
>> + - "renesas,sata-r8a7793" for R-Car M2-N
>> - reg : address and length of the SATA registers;
>> - interrupts : must consist of one interrupt specifier.
>>
>> diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c
>> index 61eb6d7..6f8ed8e 100644
>> --- a/drivers/ata/sata_rcar.c
>> +++ b/drivers/ata/sata_rcar.c
>> @@ -841,6 +841,10 @@ static struct of_device_id sata_rcar_match[] = {
>> .compatible = "renesas,sata-r8a7791",
>> .data = (void *)RCAR_GEN2_SATA
>> },
>> + {
>> + .compatible = "renesas,sata-r8a7793",
>> + .data = (void *)RCAR_GEN2_SATA
>> + },
>> { },
>> };
>> MODULE_DEVICE_TABLE(of, sata_rcar_match);
>> @@ -850,6 +854,7 @@ static const struct platform_device_id sata_rcar_id_table[] = {
>> { "sata-r8a7779", RCAR_GEN1_SATA },
>> { "sata-r8a7790", RCAR_GEN2_SATA },
>> { "sata-r8a7791", RCAR_GEN2_SATA },
>> + { "sata-r8a7793", RCAR_GEN2_SATA },
>> { },
>> };
>> MODULE_DEVICE_TABLE(platform, sata_rcar_id_table);
>> --
>> 1.9.1
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Best regards,
KHIEM Nguyen
next prev parent reply other threads:[~2014-10-16 5:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 8:59 [PATCH v2] ata: sata_rcar: Add r8a7793 device support Yoshihiro Kaneko
2014-10-15 8:59 ` Yoshihiro Kaneko
2014-10-16 5:20 ` Simon Horman
2014-10-16 5:20 ` Simon Horman
2014-10-16 5:43 ` Khiem Nguyen [this message]
2014-10-16 5:43 ` Khiem Nguyen
2014-10-16 5:55 ` Simon Horman
2014-10-16 5:55 ` Simon Horman
2014-10-16 6:20 ` Khiem Nguyen
2014-10-16 6:20 ` Khiem Nguyen
2014-10-16 6:27 ` Simon Horman
2014-10-16 6:27 ` Simon Horman
2014-10-27 15:05 ` Tejun Heo
2014-10-27 15:05 ` Tejun Heo
2014-10-28 3:15 ` Yoshihiro Kaneko
2014-10-28 3:15 ` Yoshihiro Kaneko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543F5AE9.7030603@renesas.com \
--to=khiem.nguyen.xt@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=horms@verge.net.au \
--cc=linux-ide@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=tj@kernel.org \
--cc=ykaneko0929@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.