From: Lars-Peter Clausen <lars@metafoo.de>
To: Shuah Khan <shuahkh@osg.samsung.com>,
m.chehab@samsung.com, akpm@linux-foundation.org,
gregkh@linuxfoundation.org, crope@iki.fi, olebowle@gmx.com,
dheitmueller@kernellabs.com, hverkuil@xs4all.nl,
ramakrmu@cisco.com, sakari.ailus@linux.intel.com,
laurent.pinchart@ideasonboard.com, perex@perex.cz, tiwai@suse.de,
prabhakar.csengg@gmail.com, tim.gardner@canonical.com,
linux@eikelenboom.it
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2 5/6] sound/usb: pcm changes to use media token api
Date: Thu, 16 Oct 2014 14:00:52 +0200 [thread overview]
Message-ID: <543FB374.8020604@metafoo.de> (raw)
In-Reply-To: <cf1059cc2606f20d921e5691e3d59945a19a7871.1413246372.git.shuahkh@osg.samsung.com>
On 10/14/2014 04:58 PM, Shuah Khan wrote:
[...]
> switch (cmd) {
> case SNDRV_PCM_TRIGGER_START:
> + err = media_get_audio_tkn(&subs->dev->dev);
> + if (err == -EBUSY) {
> + dev_info(&subs->dev->dev, "%s device is busy\n",
> + __func__);
In my opinion this should not dev_info() as this is out of band error
signaling and also as the potential to spam the log. The userspace
application is already properly notified by the return code.
> + return err;
> + }
> err = start_endpoints(subs, false);
> if (err < 0)
> return err;
WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars@metafoo.de>
To: Shuah Khan <shuahkh@osg.samsung.com>,
m.chehab@samsung.com, akpm@linux-foundation.org,
gregkh@linuxfoundation.org, crope@iki.fi, olebowle@gmx.com,
dheitmueller@kernellabs.com, hverkuil@xs4all.nl,
ramakrmu@cisco.com, sakari.ailus@linux.intel.com,
laurent.pinchart@ideasonboard.com, perex@perex.cz, tiwai@suse.de,
prabhakar.csengg@gmail.com, tim.gardner@canonical.com,
linux@eikelenboom.it
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
linux-media@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api
Date: Thu, 16 Oct 2014 14:00:52 +0200 [thread overview]
Message-ID: <543FB374.8020604@metafoo.de> (raw)
In-Reply-To: <cf1059cc2606f20d921e5691e3d59945a19a7871.1413246372.git.shuahkh@osg.samsung.com>
On 10/14/2014 04:58 PM, Shuah Khan wrote:
[...]
> switch (cmd) {
> case SNDRV_PCM_TRIGGER_START:
> + err = media_get_audio_tkn(&subs->dev->dev);
> + if (err == -EBUSY) {
> + dev_info(&subs->dev->dev, "%s device is busy\n",
> + __func__);
In my opinion this should not dev_info() as this is out of band error
signaling and also as the potential to spam the log. The userspace
application is already properly notified by the return code.
> + return err;
> + }
> err = start_endpoints(subs, false);
> if (err < 0)
> return err;
next prev parent reply other threads:[~2014-10-16 12:00 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 14:58 [PATCH v2 0/6] media token resource framework Shuah Khan
2014-10-14 14:58 ` [PATCH v2 1/6] media: add media token device " Shuah Khan
2014-10-15 17:05 ` Takashi Iwai
2014-10-16 0:53 ` Shuah Khan
2014-10-16 14:00 ` Takashi Iwai
2014-10-16 14:39 ` Shuah Khan
2014-10-21 10:46 ` Hans Verkuil
2014-10-21 11:51 ` Takashi Iwai
2014-10-21 11:58 ` Hans Verkuil
2014-10-21 13:07 ` Takashi Iwai
2014-11-18 21:33 ` Sakari Ailus
2014-10-14 14:58 ` [PATCH v2 2/6] media: v4l2-core changes to use media token api Shuah Khan
2014-10-14 14:58 ` [PATCH v2 3/6] media: au0828-video " Shuah Khan
2014-10-14 14:58 ` [PATCH v2 4/6] media: dvb-core " Shuah Khan
2014-10-14 14:58 ` [PATCH v2 5/6] sound/usb: pcm " Shuah Khan
2014-10-16 12:00 ` Lars-Peter Clausen [this message]
2014-10-16 12:00 ` [alsa-devel] " Lars-Peter Clausen
2014-10-16 13:10 ` Shuah Khan
2014-10-16 14:01 ` Takashi Iwai
2014-10-16 14:10 ` Shuah Khan
2014-10-16 14:16 ` Takashi Iwai
2014-10-16 14:39 ` Shuah Khan
2014-10-16 14:48 ` Takashi Iwai
2014-10-16 14:59 ` Shuah Khan
2014-10-16 14:59 ` [alsa-devel] " Shuah Khan
2014-10-18 18:49 ` Mauro Carvalho Chehab
2014-10-19 9:00 ` Takashi Iwai
2014-10-19 9:00 ` [alsa-devel] " Takashi Iwai
2014-10-21 15:42 ` Hans Verkuil
2014-10-21 16:05 ` Takashi Iwai
2014-10-21 16:08 ` Devin Heitmueller
2014-10-21 16:14 ` Takashi Iwai
2014-10-22 19:26 ` Pierre-Louis Bossart
2014-10-22 19:45 ` Devin Heitmueller
2014-10-24 14:44 ` Shuah Khan
2014-10-25 12:44 ` Mauro Carvalho Chehab
2014-10-25 12:44 ` [alsa-devel] " Mauro Carvalho Chehab
2014-10-25 13:20 ` Mauro Carvalho Chehab
2014-10-25 13:41 ` Mauro Carvalho Chehab
2014-10-25 13:41 ` [alsa-devel] " Mauro Carvalho Chehab
2014-10-26 8:27 ` Takashi Iwai
2014-10-27 12:52 ` Mauro Carvalho Chehab
2014-10-28 21:15 ` Shuah Khan
2014-10-28 23:42 ` [RFCv1] Media Token API needs - Was: " Mauro Carvalho Chehab
2014-10-29 0:00 ` Mauro Carvalho Chehab
2014-10-29 11:19 ` Mauro Carvalho Chehab
2014-10-29 16:06 ` Shuah Khan
2014-10-29 17:56 ` Mauro Carvalho Chehab
2014-11-04 23:08 ` [RFCv2] Media Token API Spec Shuah Khan
2014-11-10 14:15 ` Hans Verkuil
2014-11-10 14:15 ` Hans Verkuil
2014-11-18 21:15 ` Sakari Ailus
2014-11-18 21:27 ` Shuah Khan
2014-10-21 17:32 ` [alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api Shuah Khan
2014-10-22 15:24 ` Hans Verkuil
2014-10-25 10:57 ` Mauro Carvalho Chehab
2014-10-27 15:47 ` [alsa-devel] " Shuah Khan
2014-10-14 14:58 ` [PATCH v2 6/6] media: au0828-core changes to create and destroy media Shuah Khan
2014-10-15 16:48 ` [PATCH v2 0/6] media token resource framework Takashi Iwai
2014-10-15 20:21 ` Shuah Khan
2014-10-16 14:02 ` Takashi Iwai
2014-10-29 9:17 ` Sakari Ailus
2014-10-29 9:33 ` Mauro Carvalho Chehab
2014-10-29 9:33 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543FB374.8020604@metafoo.de \
--to=lars@metafoo.de \
--cc=akpm@linux-foundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=crope@iki.fi \
--cc=dheitmueller@kernellabs.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux@eikelenboom.it \
--cc=m.chehab@samsung.com \
--cc=olebowle@gmx.com \
--cc=perex@perex.cz \
--cc=prabhakar.csengg@gmail.com \
--cc=ramakrmu@cisco.com \
--cc=sakari.ailus@linux.intel.com \
--cc=shuahkh@osg.samsung.com \
--cc=tim.gardner@canonical.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.