* [PATCHv3] Add SPI nodes to Altera SOCFPGA DT @ 2014-10-16 22:07 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 0 siblings, 0 replies; 11+ messages in thread From: tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx @ 2014-10-16 22:07 UTC (permalink / raw) To: dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx, broonie-DgEjT+Ai2ygdnm+yROfE0A, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, galak-sgV2jX0FEOL9JmXXK+q4OQ Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx, tthayer.linux-Re5JQEeQqe8AvxtiuMwx3w, tthayer-EIB2kfCEclfQT0dZR+AlfA, axel.lin-8E1dMatC8ynQT0dZR+AlfA, baruch-NswTu9S1W3P6gbPvEgmw2w, andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA, s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ From: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> This patch adds the SPI nodes to the SOCFPGA device tree. Both nodes are left in the disabled state since no devices are present on the development boards. Thor Thayer (1): arm: dts: socfpga: Add SPI nodes to SOCFPGA DT. arch/arm/boot/dts/socfpga.dtsi | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCHv3] Add SPI nodes to Altera SOCFPGA DT @ 2014-10-16 22:07 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 0 siblings, 0 replies; 11+ messages in thread From: tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx @ 2014-10-16 22:07 UTC (permalink / raw) To: dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx, broonie-DgEjT+Ai2ygdnm+yROfE0A, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, galak-sgV2jX0FEOL9JmXXK+q4OQ Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx, tthayer.linux-Re5JQEeQqe8AvxtiuMwx3w, tthayer-EIB2kfCEclfQT0dZR+AlfA, axel.lin-8E1dMatC8ynQT0dZR+AlfA, baruch-NswTu9S1W3P6gbPvEgmw2w, andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA, s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ From: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> This patch adds the SPI nodes to the SOCFPGA device tree. Both nodes are left in the disabled state since no devices are present on the development boards. Thor Thayer (1): arm: dts: socfpga: Add SPI nodes to SOCFPGA DT. arch/arm/boot/dts/socfpga.dtsi | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <1413497251-21954-1-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>]
* [PATCHv3] arm: dts: socfpga: Add SPI nodes to SOCFPGA DT. [not found] ` <1413497251-21954-1-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> @ 2014-10-16 22:07 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 0 siblings, 0 replies; 11+ messages in thread From: tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx @ 2014-10-16 22:07 UTC (permalink / raw) To: dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx, broonie-DgEjT+Ai2ygdnm+yROfE0A, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, galak-sgV2jX0FEOL9JmXXK+q4OQ Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx, tthayer.linux-Re5JQEeQqe8AvxtiuMwx3w, tthayer-EIB2kfCEclfQT0dZR+AlfA, axel.lin-8E1dMatC8ynQT0dZR+AlfA, baruch-NswTu9S1W3P6gbPvEgmw2w, andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA, s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ From: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> Add 2 SPI nodes to SOCFPGA device tree. Signed-off-by: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> --- v2: Remove extra files. Move SPIDEV into board specific file. v3: Remove dts file since SPIDEV is not allowed. --- arch/arm/boot/dts/socfpga.dtsi | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi index 4d77ad6..d81bc2d3 100644 --- a/arch/arm/boot/dts/socfpga.dtsi +++ b/arch/arm/boot/dts/socfpga.dtsi @@ -628,6 +628,30 @@ clock-names = "biu", "ciu"; }; + spi0: spi@fff00000 { + compatible = "snps,dw-apb-ssi"; + #address-cells = <1>; + #size-cells = <0>; + reg = <0xfff00000 0x1000>; + interrupts = <0 154 4>; + num-cs = <4>; + bus-num = <0>; + clocks = <&spi_m_clk>; + status = "disabled"; + }; + + spi1: spi@fff01000 { + compatible = "snps,dw-apb-ssi"; + #address-cells = <1>; + #size-cells = <0>; + reg = <0xfff01000 0x1000>; + interrupts = <0 156 4>; + num-cs = <4>; + bus-num = <1>; + clocks = <&spi_m_clk>; + status = "disabled"; + }; + /* Local timer */ timer@fffec600 { compatible = "arm,cortex-a9-twd-timer"; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCHv3] arm: dts: socfpga: Add SPI nodes to SOCFPGA DT. @ 2014-10-16 22:07 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 0 siblings, 0 replies; 11+ messages in thread From: tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx @ 2014-10-16 22:07 UTC (permalink / raw) To: dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx, broonie-DgEjT+Ai2ygdnm+yROfE0A, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, galak-sgV2jX0FEOL9JmXXK+q4OQ Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx, tthayer.linux-Re5JQEeQqe8AvxtiuMwx3w, tthayer-EIB2kfCEclfQT0dZR+AlfA, axel.lin-8E1dMatC8ynQT0dZR+AlfA, baruch-NswTu9S1W3P6gbPvEgmw2w, andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA, s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ From: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> Add 2 SPI nodes to SOCFPGA device tree. Signed-off-by: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> --- v2: Remove extra files. Move SPIDEV into board specific file. v3: Remove dts file since SPIDEV is not allowed. --- arch/arm/boot/dts/socfpga.dtsi | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi index 4d77ad6..d81bc2d3 100644 --- a/arch/arm/boot/dts/socfpga.dtsi +++ b/arch/arm/boot/dts/socfpga.dtsi @@ -628,6 +628,30 @@ clock-names = "biu", "ciu"; }; + spi0: spi@fff00000 { + compatible = "snps,dw-apb-ssi"; + #address-cells = <1>; + #size-cells = <0>; + reg = <0xfff00000 0x1000>; + interrupts = <0 154 4>; + num-cs = <4>; + bus-num = <0>; + clocks = <&spi_m_clk>; + status = "disabled"; + }; + + spi1: spi@fff01000 { + compatible = "snps,dw-apb-ssi"; + #address-cells = <1>; + #size-cells = <0>; + reg = <0xfff01000 0x1000>; + interrupts = <0 156 4>; + num-cs = <4>; + bus-num = <1>; + clocks = <&spi_m_clk>; + status = "disabled"; + }; + /* Local timer */ timer@fffec600 { compatible = "arm,cortex-a9-twd-timer"; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 11+ messages in thread
[parent not found: <1413497251-21954-2-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>]
* Re: [PATCHv3] arm: dts: socfpga: Add SPI nodes to SOCFPGA DT. [not found] ` <1413497251-21954-2-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> @ 2014-10-17 6:52 ` Steffen Trumtrar [not found] ` <20141017065233.GA10262-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 0 siblings, 1 reply; 11+ messages in thread From: Steffen Trumtrar @ 2014-10-17 6:52 UTC (permalink / raw) To: tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx Cc: dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx, broonie-DgEjT+Ai2ygdnm+yROfE0A, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-spi-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, tthayer.linux-Re5JQEeQqe8AvxtiuMwx3w, tthayer-EIB2kfCEclfQT0dZR+AlfA, axel.lin-8E1dMatC8ynQT0dZR+AlfA, baruch-NswTu9S1W3P6gbPvEgmw2w, andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA Hi! On Thu, Oct 16, 2014 at 05:07:31PM -0500, tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org wrote: > From: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> > > Add 2 SPI nodes to SOCFPGA device tree. > > Signed-off-by: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> > --- > v2: Remove extra files. Move SPIDEV into board specific file. > > v3: Remove dts file since SPIDEV is not allowed. > --- > arch/arm/boot/dts/socfpga.dtsi | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi > index 4d77ad6..d81bc2d3 100644 > --- a/arch/arm/boot/dts/socfpga.dtsi > +++ b/arch/arm/boot/dts/socfpga.dtsi > @@ -628,6 +628,30 @@ > clock-names = "biu", "ciu"; > }; > > + spi0: spi@fff00000 { > + compatible = "snps,dw-apb-ssi"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0xfff00000 0x1000>; > + interrupts = <0 154 4>; > + num-cs = <4>; > + bus-num = <0>; ^^^^^^^^^^^^^^ I think you can/should get rid of this property. It is only used/documented for fsl-dspi as far as I can see. > + clocks = <&spi_m_clk>; > + status = "disabled"; > + }; > + > + spi1: spi@fff01000 { > + compatible = "snps,dw-apb-ssi"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0xfff01000 0x1000>; > + interrupts = <0 156 4>; > + num-cs = <4>; > + bus-num = <1>; > + clocks = <&spi_m_clk>; > + status = "disabled"; > + }; > + > /* Local timer */ > timer@fffec600 { > compatible = "arm,cortex-a9-twd-timer"; The rest looks good IMO. Regards, Steffen -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <20141017065233.GA10262-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]
* Re: [PATCHv3] arm: dts: socfpga: Add SPI nodes to SOCFPGA DT. [not found] ` <20141017065233.GA10262-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> @ 2014-10-17 11:13 ` Mark Brown 2014-10-17 13:55 ` Thor Thayer 1 sibling, 0 replies; 11+ messages in thread From: Mark Brown @ 2014-10-17 11:13 UTC (permalink / raw) To: Steffen Trumtrar Cc: tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx, dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-spi-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, tthayer.linux-Re5JQEeQqe8AvxtiuMwx3w, tthayer-EIB2kfCEclfQT0dZR+AlfA, axel.lin-8E1dMatC8ynQT0dZR+AlfA, baruch-NswTu9S1W3P6gbPvEgmw2w, andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA [-- Attachment #1: Type: text/plain, Size: 374 bytes --] On Fri, Oct 17, 2014 at 08:52:33AM +0200, Steffen Trumtrar wrote: > On Thu, Oct 16, 2014 at 05:07:31PM -0500, tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org wrote: > > + bus-num = <0>; > ^^^^^^^^^^^^^^ > I think you can/should get rid of this property. It is only used/documented for > fsl-dspi as far as I can see. Yes, and it shouldn't be there either. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 473 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCHv3] arm: dts: socfpga: Add SPI nodes to SOCFPGA DT. [not found] ` <20141017065233.GA10262-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> @ 2014-10-17 13:55 ` Thor Thayer 2014-10-17 13:55 ` Thor Thayer 1 sibling, 0 replies; 11+ messages in thread From: Thor Thayer @ 2014-10-17 13:55 UTC (permalink / raw) To: Steffen Trumtrar Cc: dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx, broonie-DgEjT+Ai2ygdnm+yROfE0A, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-spi-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, tthayer.linux-Re5JQEeQqe8AvxtiuMwx3w, tthayer-EIB2kfCEclfQT0dZR+AlfA, axel.lin-8E1dMatC8ynQT0dZR+AlfA, baruch-NswTu9S1W3P6gbPvEgmw2w, andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA On 10/17/2014 01:52 AM, Steffen Trumtrar wrote: > Hi! > > On Thu, Oct 16, 2014 at 05:07:31PM -0500, tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org wrote: >> From: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> >> >> Add 2 SPI nodes to SOCFPGA device tree. >> >> Signed-off-by: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> >> --- >> v2: Remove extra files. Move SPIDEV into board specific file. >> >> v3: Remove dts file since SPIDEV is not allowed. >> --- >> arch/arm/boot/dts/socfpga.dtsi | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi >> index 4d77ad6..d81bc2d3 100644 >> --- a/arch/arm/boot/dts/socfpga.dtsi >> +++ b/arch/arm/boot/dts/socfpga.dtsi >> @@ -628,6 +628,30 @@ >> clock-names = "biu", "ciu"; >> }; >> >> + spi0: spi@fff00000 { >> + compatible = "snps,dw-apb-ssi"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + reg = <0xfff00000 0x1000>; >> + interrupts = <0 154 4>; >> + num-cs = <4>; >> + bus-num = <0>; > ^^^^^^^^^^^^^^ > > I think you can/should get rid of this property. It is only used/documented for > fsl-dspi as far as I can see. Hi Steffen! You are right, I will remove this. I didn't see it documented in the dw-spi bindings but I did see a reference to .bus_num in the static structure (spi_board_info) shown in spi-summary.txt. If the bus-num isn't defined or used, the bus ends up as 32766 (0x7FE). However, the main point is that this isn't used in the code so I should remove it. Thanks for your input and for reviewing! Thor >> + clocks = <&spi_m_clk>; >> + status = "disabled"; >> + }; >> + >> + spi1: spi@fff01000 { >> + compatible = "snps,dw-apb-ssi"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + reg = <0xfff01000 0x1000>; >> + interrupts = <0 156 4>; >> + num-cs = <4>; >> + bus-num = <1>; >> + clocks = <&spi_m_clk>; >> + status = "disabled"; >> + }; >> + >> /* Local timer */ >> timer@fffec600 { >> compatible = "arm,cortex-a9-twd-timer"; > The rest looks good IMO. > > Regards, > Steffen > -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCHv3] arm: dts: socfpga: Add SPI nodes to SOCFPGA DT. @ 2014-10-17 13:55 ` Thor Thayer 0 siblings, 0 replies; 11+ messages in thread From: Thor Thayer @ 2014-10-17 13:55 UTC (permalink / raw) To: Steffen Trumtrar Cc: dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx, broonie-DgEjT+Ai2ygdnm+yROfE0A, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-spi-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, tthayer.linux-Re5JQEeQqe8AvxtiuMwx3w, tthayer-EIB2kfCEclfQT0dZR+AlfA, axel.lin-8E1dMatC8ynQT0dZR+AlfA, baruch-NswTu9S1W3P6gbPvEgmw2w, andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA On 10/17/2014 01:52 AM, Steffen Trumtrar wrote: > Hi! > > On Thu, Oct 16, 2014 at 05:07:31PM -0500, tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org wrote: >> From: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> >> >> Add 2 SPI nodes to SOCFPGA device tree. >> >> Signed-off-by: Thor Thayer <tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> >> --- >> v2: Remove extra files. Move SPIDEV into board specific file. >> >> v3: Remove dts file since SPIDEV is not allowed. >> --- >> arch/arm/boot/dts/socfpga.dtsi | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi >> index 4d77ad6..d81bc2d3 100644 >> --- a/arch/arm/boot/dts/socfpga.dtsi >> +++ b/arch/arm/boot/dts/socfpga.dtsi >> @@ -628,6 +628,30 @@ >> clock-names = "biu", "ciu"; >> }; >> >> + spi0: spi@fff00000 { >> + compatible = "snps,dw-apb-ssi"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + reg = <0xfff00000 0x1000>; >> + interrupts = <0 154 4>; >> + num-cs = <4>; >> + bus-num = <0>; > ^^^^^^^^^^^^^^ > > I think you can/should get rid of this property. It is only used/documented for > fsl-dspi as far as I can see. Hi Steffen! You are right, I will remove this. I didn't see it documented in the dw-spi bindings but I did see a reference to .bus_num in the static structure (spi_board_info) shown in spi-summary.txt. If the bus-num isn't defined or used, the bus ends up as 32766 (0x7FE). However, the main point is that this isn't used in the code so I should remove it. Thanks for your input and for reviewing! Thor >> + clocks = <&spi_m_clk>; >> + status = "disabled"; >> + }; >> + >> + spi1: spi@fff01000 { >> + compatible = "snps,dw-apb-ssi"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + reg = <0xfff01000 0x1000>; >> + interrupts = <0 156 4>; >> + num-cs = <4>; >> + bus-num = <1>; >> + clocks = <&spi_m_clk>; >> + status = "disabled"; >> + }; >> + >> /* Local timer */ >> timer@fffec600 { >> compatible = "arm,cortex-a9-twd-timer"; > The rest looks good IMO. > > Regards, > Steffen > -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <54411FC9.3050109-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>]
* Re: [PATCHv3] arm: dts: socfpga: Add SPI nodes to SOCFPGA DT. [not found] ` <54411FC9.3050109-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> @ 2014-10-17 14:27 ` Mark Brown [not found] ` <20141017142713.GV1820-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> 0 siblings, 1 reply; 11+ messages in thread From: Mark Brown @ 2014-10-17 14:27 UTC (permalink / raw) To: Thor Thayer Cc: Steffen Trumtrar, dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-spi-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, tthayer.linux-Re5JQEeQqe8AvxtiuMwx3w, tthayer-EIB2kfCEclfQT0dZR+AlfA, axel.lin-8E1dMatC8ynQT0dZR+AlfA, baruch-NswTu9S1W3P6gbPvEgmw2w, andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA [-- Attachment #1: Type: text/plain, Size: 536 bytes --] On Fri, Oct 17, 2014 at 08:55:21AM -0500, Thor Thayer wrote: > I didn't see it documented in the dw-spi bindings but I did see a reference > to .bus_num in the static structure (spi_board_info) shown in > spi-summary.txt. If the bus-num isn't defined or used, the bus ends up as > 32766 (0x7FE). However, the main point is that this isn't used in the code > so I should remove it. Defining the bus number is important for use in board files to allow devices to be referenced but should never have any practical effect for DT systems. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 473 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <20141017142713.GV1820-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>]
* Re: [PATCHv3] arm: dts: socfpga: Add SPI nodes to SOCFPGA DT. [not found] ` <20141017142713.GV1820-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> @ 2014-10-17 15:05 ` Thor Thayer 0 siblings, 0 replies; 11+ messages in thread From: Thor Thayer @ 2014-10-17 15:05 UTC (permalink / raw) To: Mark Brown Cc: Steffen Trumtrar, dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-spi-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, tthayer.linux-Re5JQEeQqe8AvxtiuMwx3w, tthayer-EIB2kfCEclfQT0dZR+AlfA, axel.lin-8E1dMatC8ynQT0dZR+AlfA, baruch-NswTu9S1W3P6gbPvEgmw2w, andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA On 10/17/2014 09:27 AM, Mark Brown wrote: > On Fri, Oct 17, 2014 at 08:55:21AM -0500, Thor Thayer wrote: > >> I didn't see it documented in the dw-spi bindings but I did see a reference >> to .bus_num in the static structure (spi_board_info) shown in >> spi-summary.txt. If the bus-num isn't defined or used, the bus ends up as >> 32766 (0x7FE). However, the main point is that this isn't used in the code >> so I should remove it. > Defining the bus number is important for use in board files to allow > devices to be referenced but should never have any practical effect for > DT systems. Thank you for the explanation, Mark. I'll make the change and resubmit. -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCHv3] arm: dts: socfpga: Add SPI nodes to SOCFPGA DT. @ 2014-10-17 15:05 ` Thor Thayer 0 siblings, 0 replies; 11+ messages in thread From: Thor Thayer @ 2014-10-17 15:05 UTC (permalink / raw) To: Mark Brown Cc: Steffen Trumtrar, dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-spi-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, tthayer.linux-Re5JQEeQqe8AvxtiuMwx3w, tthayer-EIB2kfCEclfQT0dZR+AlfA, axel.lin-8E1dMatC8ynQT0dZR+AlfA, baruch-NswTu9S1W3P6gbPvEgmw2w, andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA On 10/17/2014 09:27 AM, Mark Brown wrote: > On Fri, Oct 17, 2014 at 08:55:21AM -0500, Thor Thayer wrote: > >> I didn't see it documented in the dw-spi bindings but I did see a reference >> to .bus_num in the static structure (spi_board_info) shown in >> spi-summary.txt. If the bus-num isn't defined or used, the bus ends up as >> 32766 (0x7FE). However, the main point is that this isn't used in the code >> so I should remove it. > Defining the bus number is important for use in board files to allow > devices to be referenced but should never have any practical effect for > DT systems. Thank you for the explanation, Mark. I'll make the change and resubmit. -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2014-10-17 15:05 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-16 22:07 [PATCHv3] Add SPI nodes to Altera SOCFPGA DT tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
2014-10-16 22:07 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
[not found] ` <1413497251-21954-1-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2014-10-16 22:07 ` [PATCHv3] arm: dts: socfpga: Add SPI nodes to " tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
2014-10-16 22:07 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
[not found] ` <1413497251-21954-2-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2014-10-17 6:52 ` Steffen Trumtrar
[not found] ` <20141017065233.GA10262-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-10-17 11:13 ` Mark Brown
2014-10-17 13:55 ` Thor Thayer
2014-10-17 13:55 ` Thor Thayer
[not found] ` <54411FC9.3050109-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2014-10-17 14:27 ` Mark Brown
[not found] ` <20141017142713.GV1820-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-10-17 15:05 ` Thor Thayer
2014-10-17 15:05 ` Thor Thayer
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.