Re: [Printing-architecture] Number of copies in pure PDF workflow

[Till Kamppeter <till.kamppeter@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1397 bytes --]

Thank you very much.

Pushed the attached additional patch to the BZR repo (rev. 7300).

   Till

On 10/17/2014 06:22 PM, Alex Korobkin wrote:
> Works beautifully, thank you. And thanks for digging up the exact rules
> of QTY and COPIES application. 
> 
> 
> 2014-10-16 16:59 GMT-04:00 Tobias Hoffmann
> <lprint-list@thax.hardliners.org <mailto:lprint-list@thax.hardliners.org>>:
> 
>     On 16/10/14 18:52, Alex Korobkin wrote:
> 
>         Turns out, there should be one additional line for collate to
>         work with multiple copies and multiple pages:
>         PJL SET QTY=X
> 
>         Could you please modify your patch to generate two lines at
>         once: PJL SET COPIES=X and PJL SET QTY=X?
> 
>     The attached patch does that. It's based on BZR rev. 7299, which
>     already includes the SET COPIES modifications (Till also posted the
>     corresponding .patch, earlier).
> 
>     I did some research, though... and it seem that (only) "SET COPIES"
>     should be used for non-collated and only(!) "SET QTY" should be used
>     for collated duplicates.
>     Please do try whether just SET QTY is enough:
>               if (param.deviceCollate) {
>                 snprintf(ppd->jcl_ps, size, "@PJL SET QTY=%d\n%s",
>                        param.deviceCopies, attr->value);
>              } else {
>              [...]
> 
>       Tobias
> 
> 
> 
> 
> 
> 
> -- 
> -Alex


[-- Attachment #2: pjlcollate-v2.patch --]
[-- Type: text/x-patch, Size: 848 bytes --]

=== modified file 'filter/pdftopdf/pdftopdf_jcl.cc'
--- filter/pdftopdf/pdftopdf_jcl.cc	2014-10-16 15:48:05 +0000
+++ filter/pdftopdf/pdftopdf_jcl.cc	2014-10-17 16:37:10 +0000
@@ -152,8 +152,13 @@
 	/* Add a PJL command to implement the hardware copies */
         const size_t size=strlen(attr->value)+1+30;
         ppd->jcl_ps=(char *)malloc(size*sizeof(char));
-        snprintf(ppd->jcl_ps, size, "@PJL SET COPIES=%d\n%s",
-		 param.deviceCopies, attr->value);
+        if (param.deviceCollate) {
+          snprintf(ppd->jcl_ps, size, "@PJL SET QTY=%d\n%s",
+                   param.deviceCopies, attr->value);
+        } else {
+          snprintf(ppd->jcl_ps, size, "@PJL SET COPIES=%d\n%s",
+                   param.deviceCopies, attr->value);
+        }
       } else
 	ppd->jcl_ps=strdup(attr->value);
       ppd_decode(ppd->jcl_ps);