From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Kaneko <ykaneko0929@gmail.com>, linux-media@vger.kernel.org
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH] media: soc_camera: rcar_vin: Enable VSYNC field toggle mode
Date: Sat, 18 Oct 2014 15:01:56 +0000 [thread overview]
Message-ID: <544280E4.20101@cogentembedded.com> (raw)
In-Reply-To: <1413267956-8342-1-git-send-email-ykaneko0929@gmail.com>
Hello.
On 10/14/2014 10:25 AM, Yoshihiro Kaneko wrote:
> From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> By applying this patch, it sets to VSYNC field toggle mode not only
> at the time of progressive mode but at the time of an interlace mode.
> Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---
> This patch is against master branch of linuxtv.org/media_tree.git.
> drivers/media/platform/soc_camera/rcar_vin.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c
> index 5196c81..bf97ed6 100644
> --- a/drivers/media/platform/soc_camera/rcar_vin.c
> +++ b/drivers/media/platform/soc_camera/rcar_vin.c
> @@ -108,6 +108,7 @@
> #define VNDMR2_VPS (1 << 30)
> #define VNDMR2_HPS (1 << 29)
> #define VNDMR2_FTEV (1 << 17)
> +#define VNDMR2_VLV_1 (1 << 12)
Please instead do:
#define VNDMR2_VLV(n) ((n & 0xf) << 12)
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Kaneko <ykaneko0929@gmail.com>, linux-media@vger.kernel.org
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH] media: soc_camera: rcar_vin: Enable VSYNC field toggle mode
Date: Sat, 18 Oct 2014 19:01:56 +0400 [thread overview]
Message-ID: <544280E4.20101@cogentembedded.com> (raw)
In-Reply-To: <1413267956-8342-1-git-send-email-ykaneko0929@gmail.com>
Hello.
On 10/14/2014 10:25 AM, Yoshihiro Kaneko wrote:
> From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> By applying this patch, it sets to VSYNC field toggle mode not only
> at the time of progressive mode but at the time of an interlace mode.
> Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---
> This patch is against master branch of linuxtv.org/media_tree.git.
> drivers/media/platform/soc_camera/rcar_vin.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c
> index 5196c81..bf97ed6 100644
> --- a/drivers/media/platform/soc_camera/rcar_vin.c
> +++ b/drivers/media/platform/soc_camera/rcar_vin.c
> @@ -108,6 +108,7 @@
> #define VNDMR2_VPS (1 << 30)
> #define VNDMR2_HPS (1 << 29)
> #define VNDMR2_FTEV (1 << 17)
> +#define VNDMR2_VLV_1 (1 << 12)
Please instead do:
#define VNDMR2_VLV(n) ((n & 0xf) << 12)
WBR, Sergei
next prev parent reply other threads:[~2014-10-18 15:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 6:25 [PATCH] media: soc_camera: rcar_vin: Enable VSYNC field toggle mode Yoshihiro Kaneko
2014-10-14 6:25 ` Yoshihiro Kaneko
2014-10-16 5:25 ` Simon Horman
2014-10-16 5:25 ` Simon Horman
2014-10-18 15:01 ` Sergei Shtylyov [this message]
2014-10-18 15:01 ` Sergei Shtylyov
2014-10-21 3:30 ` Yoshihiro Kaneko
2014-10-21 3:30 ` Yoshihiro Kaneko
2014-10-21 7:09 ` Geert Uytterhoeven
2014-10-21 7:09 ` Geert Uytterhoeven
2014-10-22 3:17 ` Yoshihiro Kaneko
2014-10-22 3:17 ` Yoshihiro Kaneko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544280E4.20101@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=g.liakhovetski@gmx.de \
--cc=horms@verge.net.au \
--cc=linux-media@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ykaneko0929@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.