From: zyw@rock-chips.com (Chris Zhong)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] pinctrl: rockchip: Parse pin groups before calling pinctrl_register()
Date: Mon, 20 Oct 2014 17:19:21 -0700 [thread overview]
Message-ID: <5445A689.8040707@rock-chips.com> (raw)
In-Reply-To: <1413847670-12245-3-git-send-email-dianders@chromium.org>
On 10/20/2014 04:27 PM, Doug Anderson wrote:
> Just like in (529301c pinctrl: samsung: Parse pin groups before
> calling pinctrl_register()), Rockchip also needs to parse pin groups
> earlier to make hogs work.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
> drivers/pinctrl/pinctrl-rockchip.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
> index 65efb88..14a5683 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -1263,6 +1263,10 @@ static int rockchip_pinctrl_register(struct platform_device *pdev,
> }
> }
>
> + ret = rockchip_pinctrl_parse_dt(pdev, info);
> + if (ret)
> + return ret;
> +
> info->pctl_dev = pinctrl_register(ctrldesc, &pdev->dev, info);
> if (!info->pctl_dev) {
> dev_err(&pdev->dev, "could not register pinctrl driver\n");
> @@ -1280,12 +1284,6 @@ static int rockchip_pinctrl_register(struct platform_device *pdev,
> pinctrl_add_gpio_range(info->pctl_dev, &pin_bank->grange);
> }
>
> - ret = rockchip_pinctrl_parse_dt(pdev, info);
> - if (ret) {
> - pinctrl_unregister(info->pctl_dev);
> - return ret;
> - }
> -
> return 0;
> }
>
Tested-by: Chris Zhong <zyw@rock-chips.com>
WARNING: multiple messages have this Message-ID (diff)
From: Chris Zhong <zyw@rock-chips.com>
To: Doug Anderson <dianders@chromium.org>,
Linus Walleij <linus.walleij@linaro.org>,
Heiko Stuebner <heiko@sntech.de>
Cc: Sonny Rao <sonnyrao@chromium.org>,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] pinctrl: rockchip: Parse pin groups before calling pinctrl_register()
Date: Mon, 20 Oct 2014 17:19:21 -0700 [thread overview]
Message-ID: <5445A689.8040707@rock-chips.com> (raw)
In-Reply-To: <1413847670-12245-3-git-send-email-dianders@chromium.org>
On 10/20/2014 04:27 PM, Doug Anderson wrote:
> Just like in (529301c pinctrl: samsung: Parse pin groups before
> calling pinctrl_register()), Rockchip also needs to parse pin groups
> earlier to make hogs work.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
> drivers/pinctrl/pinctrl-rockchip.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
> index 65efb88..14a5683 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -1263,6 +1263,10 @@ static int rockchip_pinctrl_register(struct platform_device *pdev,
> }
> }
>
> + ret = rockchip_pinctrl_parse_dt(pdev, info);
> + if (ret)
> + return ret;
> +
> info->pctl_dev = pinctrl_register(ctrldesc, &pdev->dev, info);
> if (!info->pctl_dev) {
> dev_err(&pdev->dev, "could not register pinctrl driver\n");
> @@ -1280,12 +1284,6 @@ static int rockchip_pinctrl_register(struct platform_device *pdev,
> pinctrl_add_gpio_range(info->pctl_dev, &pin_bank->grange);
> }
>
> - ret = rockchip_pinctrl_parse_dt(pdev, info);
> - if (ret) {
> - pinctrl_unregister(info->pctl_dev);
> - return ret;
> - }
> -
> return 0;
> }
>
Tested-by: Chris Zhong <zyw@rock-chips.com>
next prev parent reply other threads:[~2014-10-21 0:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 23:27 [PATCH 1/4] pinctrl: rockchip: Set wake_enabled Doug Anderson
2014-10-20 23:27 ` Doug Anderson
2014-10-20 23:27 ` [PATCH 2/4] pinctrl: rockchip: Don't call pinctrl_gpio_direction_output() in pin_config_set() Doug Anderson
2014-10-20 23:27 ` Doug Anderson
2014-10-21 0:18 ` Chris Zhong
2014-10-21 0:18 ` Chris Zhong
2014-10-21 16:32 ` Doug Anderson
2014-10-21 16:32 ` Doug Anderson
2014-10-20 23:27 ` [PATCH 3/4] pinctrl: rockchip: Parse pin groups before calling pinctrl_register() Doug Anderson
2014-10-20 23:27 ` Doug Anderson
2014-10-21 0:19 ` Chris Zhong [this message]
2014-10-21 0:19 ` Chris Zhong
2014-10-20 23:27 ` [PATCH 4/4] pinctrl: rockchip: Protect read-modify-write with the spinlock Doug Anderson
2014-10-20 23:27 ` Doug Anderson
2014-10-20 23:57 ` Doug Anderson
2014-10-20 23:57 ` Doug Anderson
2014-10-21 0:15 ` [PATCH 1/4] pinctrl: rockchip: Set wake_enabled Chris Zhong
2014-10-21 0:15 ` Chris Zhong
2014-10-28 15:51 ` Linus Walleij
2014-10-28 15:51 ` Linus Walleij
2014-10-28 16:06 ` Doug Anderson
2014-10-28 16:06 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5445A689.8040707@rock-chips.com \
--to=zyw@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.