All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tanya Brokhman <tlinder@codeaurora.org>
To: dedekind1@gmail.com
Cc: ezequiel.garcia@free-electrons.com,
	linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org,
	David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Richard Weinberger <richard@nod.at>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V5] mtd: ubi: Extend UBI layer debug/messaging capabilities
Date: Tue, 21 Oct 2014 11:52:43 +0300	[thread overview]
Message-ID: <54461EDB.6020100@codeaurora.org> (raw)
In-Reply-To: <1413878186.7906.405.camel@sauron.fi.intel.com>

On 10/21/2014 10:56 AM, Artem Bityutskiy wrote:
> On Mon, 2014-10-20 at 19:57 +0300, Tanya Brokhman wrote:
>> If there is more then one UBI device mounted, there is no way to
>> distinguish between messages from different UBI devices.
>> Add device number to all ubi layer message types.
>>
>> The R/O block driver messages were replaced by pr_* since
>> ubi_device structure is not used by it.
>>
>> Signed-off-by: Tanya Brokhman <tlinder@codeaurora.org>
>
> Pushed to linux-ubifs.git, thanks.
>
> You did not get indentations right, though, so I amended your patch.
> Also, some lines were split unnecessarily. My amendments are in the diff
> below. Please, take this into account for the similar UBIFS patch which
> you was going to send. Thank you!

Thanks Artem and sorry for the extra work for you. I was trying to find 
the balance between pleasing checkpatch and your request to have the 
message in the same line :)
Will be extra careful about the indentation next time (guess my editor 
needs re-configuration). Sorry about that.


Thanks,
Tanya Brokhman
-- 
Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum, a Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: Tanya Brokhman <tlinder@codeaurora.org>
To: dedekind1@gmail.com
Cc: linux-arm-msm@vger.kernel.org,
	open list <linux-kernel@vger.kernel.org>,
	linux-mtd@lists.infradead.org,
	ezequiel.garcia@free-electrons.com,
	Richard Weinberger <richard@nod.at>,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH V5] mtd: ubi: Extend UBI layer debug/messaging capabilities
Date: Tue, 21 Oct 2014 11:52:43 +0300	[thread overview]
Message-ID: <54461EDB.6020100@codeaurora.org> (raw)
In-Reply-To: <1413878186.7906.405.camel@sauron.fi.intel.com>

On 10/21/2014 10:56 AM, Artem Bityutskiy wrote:
> On Mon, 2014-10-20 at 19:57 +0300, Tanya Brokhman wrote:
>> If there is more then one UBI device mounted, there is no way to
>> distinguish between messages from different UBI devices.
>> Add device number to all ubi layer message types.
>>
>> The R/O block driver messages were replaced by pr_* since
>> ubi_device structure is not used by it.
>>
>> Signed-off-by: Tanya Brokhman <tlinder@codeaurora.org>
>
> Pushed to linux-ubifs.git, thanks.
>
> You did not get indentations right, though, so I amended your patch.
> Also, some lines were split unnecessarily. My amendments are in the diff
> below. Please, take this into account for the similar UBIFS patch which
> you was going to send. Thank you!

Thanks Artem and sorry for the extra work for you. I was trying to find 
the balance between pleasing checkpatch and your request to have the 
message in the same line :)
Will be extra careful about the indentation next time (guess my editor 
needs re-configuration). Sorry about that.


Thanks,
Tanya Brokhman
-- 
Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum, a Linux Foundation Collaborative Project

  reply	other threads:[~2014-10-21  8:52 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-20 16:57 [PATCH V5] mtd: ubi: Extend UBI layer debug/messaging capabilities Tanya Brokhman
2014-10-20 16:57 ` Tanya Brokhman
2014-10-20 16:57 ` Tanya Brokhman
2014-10-21  7:56 ` Artem Bityutskiy
2014-10-21  7:56   ` Artem Bityutskiy
2014-10-21  8:52   ` Tanya Brokhman [this message]
2014-10-21  8:52     ` Tanya Brokhman
2014-10-22  6:06   ` hujianyang
2014-10-22  6:06     ` hujianyang
2014-10-22  6:06     ` hujianyang
2014-10-24  3:33 ` hujianyang
2014-10-24  3:33   ` hujianyang
2014-10-24  3:33   ` hujianyang
2014-10-24  3:39   ` hujianyang
2014-10-24  3:39     ` hujianyang
2014-10-24  3:39     ` hujianyang
2014-10-30  8:40   ` Artem Bityutskiy
2014-10-30  8:40     ` Artem Bityutskiy
2014-10-30 12:22     ` Tanya Brokhman
2014-10-30 12:22       ` Tanya Brokhman
2014-11-02 17:14   ` Tanya Brokhman
2014-11-02 17:14     ` Tanya Brokhman
2014-11-03  3:08     ` hujianyang
2014-11-03  3:08       ` hujianyang
2014-11-03  3:08       ` hujianyang
2014-11-03  7:15       ` Tanya Brokhman
2014-11-03  7:15         ` Tanya Brokhman
2014-11-06  8:18     ` Artem Bityutskiy
2014-11-06  8:18       ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54461EDB.6020100@codeaurora.org \
    --to=tlinder@codeaurora.org \
    --cc=computersforpeace@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.