All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Xianwei Zhao <xianwei.zhao@amlogic.com>,
	Junyi Zhao <junyi.zhao@amlogic.com>,
	linux-amlogic@lists.infradead.org, linux-i2c@vger.kernel.org,
	devicetree@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
	Andi Shyti <andi.shyti@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh@kernel.org>
Subject: Re: [v9 2/2] i2c: amlogic: Add Amlogic A9 I2C controller driver
Date: Tue, 17 Nov 2026 11:06:12 +0100	[thread overview]
Message-ID: <54461ef0-033d-4ea4-b160-7da5afd34a43@web.de> (raw)
In-Reply-To: <cd3d821b-1cc7-4134-b902-1f05ca2526dc@amlogic.com>

>> …
>>> +module_platform_driver(aml_i2c_driver);
>>> +
>>> +MODULE_DESCRIPTION("Amlogic I2C Bus driver");
>>> +MODULE_AUTHOR("Junyi Zhao<junyi.zhao@amlogic.com>");…
>> Would another macro call “MODULE_AUTHOR” become helpful here?
>> https://elixir.bootlin.com/linux/v7.4-rc1/source/include/linux/module.h#L233-L236
> 
> Do you mean put MODULE_AUTHOR in front of MODULE_DESCRIPTION?
No.

I suggest to call this macro multiple times (on demand).

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Xianwei Zhao <xianwei.zhao@amlogic.com>,
	Junyi Zhao <junyi.zhao@amlogic.com>,
	linux-amlogic@lists.infradead.org, linux-i2c@vger.kernel.org,
	devicetree@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
	Andi Shyti <andi.shyti@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh@kernel.org>
Subject: Re: [v9 2/2] i2c: amlogic: Add Amlogic A9 I2C controller driver
Date: Tue, 17 Nov 2026 11:06:12 +0100	[thread overview]
Message-ID: <54461ef0-033d-4ea4-b160-7da5afd34a43@web.de> (raw)
In-Reply-To: <cd3d821b-1cc7-4134-b902-1f05ca2526dc@amlogic.com>

>> …
>>> +module_platform_driver(aml_i2c_driver);
>>> +
>>> +MODULE_DESCRIPTION("Amlogic I2C Bus driver");
>>> +MODULE_AUTHOR("Junyi Zhao<junyi.zhao@amlogic.com>");…
>> Would another macro call “MODULE_AUTHOR” become helpful here?
>> https://elixir.bootlin.com/linux/v7.4-rc1/source/include/linux/module.h#L233-L236
> 
> Do you mean put MODULE_AUTHOR in front of MODULE_DESCRIPTION?
No.

I suggest to call this macro multiple times (on demand).

Regards,
Markus

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2026-11-17 10:06 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  5:44 [PATCH v9 0/2] i2c: Add driver support Amlogic A9 I2C Xianwei Zhao via B4 Relay
2026-11-17  5:44 ` Xianwei Zhao
2026-11-17  5:44 ` Xianwei Zhao via B4 Relay
2026-11-17  5:44 ` [PATCH v9 1/2] dt-bindings: i2c: add Amlogic A9 I2C controller Xianwei Zhao via B4 Relay
2026-11-17  5:44   ` Xianwei Zhao
2026-11-17  5:44   ` Xianwei Zhao via B4 Relay
2026-11-17  9:05   ` Markus Elfring
2026-11-17  9:05     ` Markus Elfring
2026-11-17  9:32     ` Xianwei Zhao
2026-11-17  9:32       ` Xianwei Zhao
2026-11-17  5:44 ` [PATCH v9 2/2] i2c: amlogic: Add Amlogic A9 I2C controller driver Xianwei Zhao via B4 Relay
2026-11-17  5:44   ` Xianwei Zhao
2026-11-17  5:44   ` Xianwei Zhao via B4 Relay
2026-11-17  6:07   ` sashiko-bot
2026-11-17  6:07     ` sashiko-bot
2026-11-17  9:36   ` Markus Elfring
2026-11-17  9:36     ` Markus Elfring
2026-11-17 10:01     ` Xianwei Zhao
2026-11-17 10:01       ` Xianwei Zhao
2026-11-17 10:06       ` Markus Elfring [this message]
2026-11-17 10:06         ` [v9 " Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54461ef0-033d-4ea4-b160-7da5afd34a43@web.de \
    --to=markus.elfring@web.de \
    --cc=andi.shyti@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=junyi.zhao@amlogic.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=xianwei.zhao@amlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.