From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Cc: Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>
Subject: Re: [PATCH 2/2] ARM: dts: exynos4412-trats: Add suspend configuration for max77686 regulators
Date: Tue, 21 Oct 2014 12:00:18 +0200 [thread overview]
Message-ID: <54462EB2.2070302@collabora.co.uk> (raw)
In-Reply-To: <1413883424.26980.7.camel@AMDC1943>
Hello Krzysztof,
On 10/21/2014 11:23 AM, Krzysztof Kozlowski wrote:
>> >
>> > ldo9_reg: ldo9 {
>> > @@ -295,7 +311,9 @@
>> > regulator-name = "CAM_ISP_MIPI_1.2V";
>> > regulator-min-microvolt = <1200000>;
>> > regulator-max-microvolt = <1200000>;
>> > - regulator-mem-idle;
>> > + regulator-state-mem {
>> > + regulator-on-in-suspend;
>>
>> CAM_ISP_MIPI_1.2V is used for camera, I think this regulator should turn off in suspend state
>> because camear could not be used in suspend state.
>
> LDO9 does not support off in suspend mode controlled by PWRREQ. It
> supports only switching to low power mode if PWRREQ level goes low.
>
> Thus the driver does not provide set_suspend_enable or
> set_suspend_disable for LDO0. Do you want to add such function to the
> max77686 driver which will explicitly disable the regulator (write 0x0
> to control reg)?
>
>
I think for those regulators you can just use regulator_disable_regmap()
as the .set_suspend_disable function handler?
Best regards,
Javier
WARNING: multiple messages have this Message-ID (diff)
From: javier.martinez@collabora.co.uk (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: exynos4412-trats: Add suspend configuration for max77686 regulators
Date: Tue, 21 Oct 2014 12:00:18 +0200 [thread overview]
Message-ID: <54462EB2.2070302@collabora.co.uk> (raw)
In-Reply-To: <1413883424.26980.7.camel@AMDC1943>
Hello Krzysztof,
On 10/21/2014 11:23 AM, Krzysztof Kozlowski wrote:
>> >
>> > ldo9_reg: ldo9 {
>> > @@ -295,7 +311,9 @@
>> > regulator-name = "CAM_ISP_MIPI_1.2V";
>> > regulator-min-microvolt = <1200000>;
>> > regulator-max-microvolt = <1200000>;
>> > - regulator-mem-idle;
>> > + regulator-state-mem {
>> > + regulator-on-in-suspend;
>>
>> CAM_ISP_MIPI_1.2V is used for camera, I think this regulator should turn off in suspend state
>> because camear could not be used in suspend state.
>
> LDO9 does not support off in suspend mode controlled by PWRREQ. It
> supports only switching to low power mode if PWRREQ level goes low.
>
> Thus the driver does not provide set_suspend_enable or
> set_suspend_disable for LDO0. Do you want to add such function to the
> max77686 driver which will explicitly disable the regulator (write 0x0
> to control reg)?
>
>
I think for those regulators you can just use regulator_disable_regmap()
as the .set_suspend_disable function handler?
Best regards,
Javier
next prev parent reply other threads:[~2014-10-21 10:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 8:25 [PATCH 0/2] regulator: max77686/trats2: Disable some regulators in suspend Krzysztof Kozlowski
2014-10-21 8:25 ` Krzysztof Kozlowski
2014-10-21 8:25 ` [PATCH 1/2] regulator: max77686: Implement suspend disable for some LDOs Krzysztof Kozlowski
2014-10-21 8:25 ` Krzysztof Kozlowski
2014-10-21 9:10 ` Javier Martinez Canillas
2014-10-21 9:10 ` Javier Martinez Canillas
2014-10-21 9:36 ` Krzysztof Kozlowski
2014-10-21 9:36 ` Krzysztof Kozlowski
2014-10-21 9:54 ` Javier Martinez Canillas
2014-10-21 9:54 ` Javier Martinez Canillas
2014-10-21 8:25 ` [PATCH 2/2] ARM: dts: exynos4412-trats: Add suspend configuration for max77686 regulators Krzysztof Kozlowski
2014-10-21 8:25 ` Krzysztof Kozlowski
2014-10-21 8:25 ` Krzysztof Kozlowski
2014-10-21 8:44 ` Javier Martinez Canillas
2014-10-21 8:44 ` Javier Martinez Canillas
2014-10-21 8:56 ` Chanwoo Choi
2014-10-21 8:56 ` Chanwoo Choi
2014-10-21 9:23 ` Krzysztof Kozlowski
2014-10-21 9:23 ` Krzysztof Kozlowski
2014-10-21 10:00 ` Javier Martinez Canillas [this message]
2014-10-21 10:00 ` Javier Martinez Canillas
2014-10-21 10:14 ` Krzysztof Kozlowski
2014-10-21 10:14 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54462EB2.2070302@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=b.zolnierkie@samsung.com \
--cc=ben-linux@fluff.org \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.