Re: [PATCH v5 0/2] Adding support for CAN busses via SPI interface

[Stefano Babic <sbabic@denx.de>]

Hi Marc,

On 28/07/2014 18:38, Stefano Babic wrote:
> Hi all,
> 
> after some time, I post an updated version of the spi_can driver.
> Sorry for that, but I had to wait for the requested modifications
> on the microcontroller's firmware to test it again.
> 
> The majork change is the GET_CFG message to query the remote
> CAN microcontroller for the CAN bittiming. I hope also I have fixed
> all issues from previous reviews.
> 
> 
> Changes in v5:
> - drop Patch 2/3, already applied.
> - sort include headers
> - match open parenthesis (globally fixed)
> - add newline to dev_err() in insert_cfg_msg()
> - use sizeof(*p)
> - drop unused variable val in ISR
> - proper return code instead of -1
> - move device ids after probe/remove
> - drop #ifdef CONFIG_OF (not needed anymore)
> - use devm_ API
> - use module_spi_driver()

The driver needs to be rebased on current tree, but before doing that I
want kindly ask you which is the best way to proceed. As far as I can
see in the previous threads, I have not found any open points for V5. Do
you think there are any issue that block this driver to flow into
mainline ? Or which is in your opinion the best way to do ? Maybe should
I post it for inclusion in drivers/staging ?

Thanks,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================