From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Stefano Babic <sbabic@denx.de>, linux-can@vger.kernel.org
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Wolfgang Grandegger <wg@grandegger.com>
Subject: Re: [PATCH v5 1/2] Add documentation for SPI to CAN driver
Date: Thu, 30 Oct 2014 21:41:46 +0100 [thread overview]
Message-ID: <5452A28A.1070401@hartkopp.net> (raw)
In-Reply-To: <54526584.3060300@denx.de>
On 10/30/2014 05:21 PM, Stefano Babic wrote:
> On 29/10/2014 21:33, Oliver Hartkopp wrote:
>> Why is ctrlmode not 32 bit?
>>
>>> + 23-27 clock
>>> + 28-29 Checksum
>>
>
> I admit this is a limitation on the Slave Controller. I was asked to not
> send a configuration frame bigger as 32 bytes, and I have tried to save
> space in some ways. Indeed, only some bits in the ctrlmode are used.
>
> Anyway, I was unsure if I can reduce the size for the brp_* fields.
> Using 32bit for brp_min looks like excessive, and I could drop its size
> instead of ctrlmode. Do you think I can use 8bit values for all brp_*
> fields ?
At least for CAN FD these values are increased remarkably. So we should
probably leave it as-is.
>
>> Some more stuff in the other patch.
>
> I check it, thanks for review !
Tnx!
Best regards,
Oliver
next prev parent reply other threads:[~2014-10-30 20:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 16:38 [PATCH v5 0/2] Adding support for CAN busses via SPI interface Stefano Babic
2014-07-28 16:38 ` [PATCH v5 1/2] Add documentation for SPI to CAN driver Stefano Babic
2014-10-29 20:33 ` Oliver Hartkopp
2014-10-30 16:21 ` Stefano Babic
2014-10-30 20:41 ` Oliver Hartkopp [this message]
2014-11-05 12:19 ` Marc Kleine-Budde
2014-11-06 13:48 ` Stefano Babic
2014-07-28 16:38 ` [PATCH v5 2/2] CAN: CAN driver to support multiple CAN bus on SPI interface Stefano Babic
2014-10-29 20:57 ` Oliver Hartkopp
2014-10-31 10:57 ` Stefano Babic
2014-10-31 18:23 ` Oliver Hartkopp
2014-11-05 13:15 ` Marc Kleine-Budde
2014-11-06 16:13 ` Stefano Babic
2014-08-07 8:06 ` [PATCH v5 0/2] Adding support for CAN busses via " Stefano Babic
2014-09-16 13:01 ` Stefano Babic
2014-10-21 12:25 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5452A28A.1070401@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=sbabic@denx.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.