All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Jianqun <jay.xu@rock-chips.com>,
	heiko@sntech.de, lgirdwood@gmail.com, broonie@kernel.org,
	perex@perex.cz, tiwai@suse.de,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	alsa-devel@alsa-project.org
Cc: huangtao@rock-chips.com, cf@rock-chips.com
Subject: Re: [alsa-devel] [PATCH] ASoC: rockchip-i2s: add rockchip-max98090 driver support
Date: Tue, 21 Oct 2014 14:39:09 +0200	[thread overview]
Message-ID: <544653ED.8000304@metafoo.de> (raw)
In-Reply-To: <1413891110-21059-1-git-send-email-jay.xu@rock-chips.com>

On 10/21/2014 01:31 PM, Jianqun wrote:
> This patch is to add support for rockchip board with max98090 codec.
> It also needs sound node in dt file.
>
> Tested on rockchip board based on rk3288.
>
> Signed-off-by: Jianqun <jay.xu@rock-chips.com>
> ---
>   sound/soc/rockchip/Kconfig | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>
> diff --git a/sound/soc/rockchip/Kconfig b/sound/soc/rockchip/Kconfig
> index 78fc159..482cbba 100644
> --- a/sound/soc/rockchip/Kconfig
> +++ b/sound/soc/rockchip/Kconfig
> @@ -9,3 +9,16 @@ config SND_SOC_ROCKCHIP
>
>   config SND_SOC_ROCKCHIP_I2S
>   	tristate
> +	depends on CLKDEV_LOOKUP && SND_SOC_ROCKCHIP
> +	help
> +	  Say Y or M if you want to add support for I2S driver for Rockchip
> +	  I2S device.
> +
> +config SND_SOC_ROCKCHIP_MAX98090
> +	tristate "ASoC support Rockchip board with max98090"
> +	depends on I2C && GPIOLIB
> +	select SND_SOC_ROCKCHIP_I2S
> +	select SND_SOC_MAX98090
> +	help
> +	  Say Y or M here if you want to add support for Rockchio board using
> +	  a max98090 codec.
>

Just make the max98090 driver directly selectable. That's what we typically 
do for DT based designs.

- Lars

WARNING: multiple messages have this Message-ID (diff)
From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH] ASoC: rockchip-i2s: add rockchip-max98090 driver support
Date: Tue, 21 Oct 2014 14:39:09 +0200	[thread overview]
Message-ID: <544653ED.8000304@metafoo.de> (raw)
In-Reply-To: <1413891110-21059-1-git-send-email-jay.xu@rock-chips.com>

On 10/21/2014 01:31 PM, Jianqun wrote:
> This patch is to add support for rockchip board with max98090 codec.
> It also needs sound node in dt file.
>
> Tested on rockchip board based on rk3288.
>
> Signed-off-by: Jianqun <jay.xu@rock-chips.com>
> ---
>   sound/soc/rockchip/Kconfig | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>
> diff --git a/sound/soc/rockchip/Kconfig b/sound/soc/rockchip/Kconfig
> index 78fc159..482cbba 100644
> --- a/sound/soc/rockchip/Kconfig
> +++ b/sound/soc/rockchip/Kconfig
> @@ -9,3 +9,16 @@ config SND_SOC_ROCKCHIP
>
>   config SND_SOC_ROCKCHIP_I2S
>   	tristate
> +	depends on CLKDEV_LOOKUP && SND_SOC_ROCKCHIP
> +	help
> +	  Say Y or M if you want to add support for I2S driver for Rockchip
> +	  I2S device.
> +
> +config SND_SOC_ROCKCHIP_MAX98090
> +	tristate "ASoC support Rockchip board with max98090"
> +	depends on I2C && GPIOLIB
> +	select SND_SOC_ROCKCHIP_I2S
> +	select SND_SOC_MAX98090
> +	help
> +	  Say Y or M here if you want to add support for Rockchio board using
> +	  a max98090 codec.
>

Just make the max98090 driver directly selectable. That's what we typically 
do for DT based designs.

- Lars

  reply	other threads:[~2014-10-21 12:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-21 11:31 [PATCH] ASoC: rockchip-i2s: add rockchip-max98090 driver support Jianqun
2014-10-21 11:31 ` Jianqun
2014-10-21 12:39 ` Lars-Peter Clausen [this message]
2014-10-21 12:39   ` [alsa-devel] " Lars-Peter Clausen
2014-10-22  0:40 ` Jianqun
2014-10-22  0:40   ` Jianqun
2014-10-31 18:11   ` Mark Brown
2014-10-31 18:11     ` Mark Brown
2014-10-22  2:59 ` [PATCH v3] ASoC: rockchip-i2s: add MAX98090 support to Kconfig Jianqun
2014-10-22  2:59   ` Jianqun
2014-10-22 10:49   ` Mark Brown
2014-10-22 10:49     ` Mark Brown
2014-11-01  2:58 ` [PATCH v2] ASoC: rockchip: i2s: add text after tristate for SND_SOC_ROCKCHIP_I2S Jianqun
2014-11-01  2:58   ` Jianqun
2014-11-03 12:09   ` Mark Brown
2014-11-03 12:09     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=544653ED.8000304@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=cf@rock-chips.com \
    --cc=heiko@sntech.de \
    --cc=huangtao@rock-chips.com \
    --cc=jay.xu@rock-chips.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.